Fixing Sale Price Issue (#456)

* Fixing Sale Price Issue

* fixing the exception in calling trim

---------

Co-authored-by: Avinash Singhal <[email protected]>

Author: singhalavi

app/code/Meta/Catalog/Model/Product/Feed/Builder/Tools.php

@@ -82,11 +82,11 @@ class Tools
     public function __construct(
         PriceCurrencyInterface $priceCurrency,
         ObjectManagerInterface $objectManager,
-        Escaper $escaper,
-        SystemConfig $systemConfig,
-        CatalogHelper $catalogHelper,
-        ModuleManager $moduleManager,
-        StoreManagerInterface $storeManager
+        Escaper                $escaper,
+        SystemConfig           $systemConfig,
+        CatalogHelper          $catalogHelper,
+        ModuleManager          $moduleManager,
+        StoreManagerInterface  $storeManager
     ) {
         $this->priceCurrency = $priceCurrency;
         $this->objectManager = $objectManager;
@@ -144,7 +144,7 @@ public function formatPrice($price, $storeId = null)
                 $baseCurrency->getCode()
             );
             // workaround for 2.4.3
-            $price = trim($price, $currencySymbol);
+            $price = trim($price, $currencySymbol ?? '');
             return $price;
         } catch (Exception $e) {
             return '';
@@ -204,10 +204,10 @@ public function getProductPrice(Product $product)
      */
     public function getProductSalePrice(Product $product)
     {
-        if ($product->getFinalPrice() > 0 && $product->getPrice() > $product->getFinalPrice()) {
+        if ($product->getSpecialPrice() > 0 && $product->getPrice() > $product->getSpecialPrice()) {
             $price = $this->systemConfig->isPriceInclTax()
-                ? $this->catalogHelper->getTaxPrice($product, $product->getFinalPrice(), true)
-                : $product->getFinalPrice();
+                ? $this->catalogHelper->getTaxPrice($product, $product->getSpecialPrice(), true)
+                : $product->getSpecialPrice();
             return $this->formatPrice($price, $product->getStoreId());
         }
         return '';