Handle phone number (#689)

* populate address information if it is missing

* update comments

* fix static analysis issues

* add phone number to shipping address, and make discount nullable in product item

* poopulate phone number

* remove phone from phpdocs

---------

Co-authored-by: Ameya Savale <[email protected]>
Co-authored-by: Paul Kang <[email protected]>

Author: 3 people

app/code/Meta/BusinessExtension/Model/Api/CustomApiKey/Authenticator.php

@@ -45,14 +45,14 @@ class Authenticator
     /**
      * Authenticator constructor
      *
-     * @param ScopeConfigInterface  $scopeConfig
-     * @param Http                  $httpRequest
-     * @param SystemConfig          $systemConfig
+     * @param ScopeConfigInterface $scopeConfig
+     * @param Http $httpRequest
+     * @param SystemConfig $systemConfig
      */
     public function __construct(
-        ScopeConfigInterface    $scopeConfig,
-        Http                    $httpRequest,
-        SystemConfig            $systemConfig
+        ScopeConfigInterface $scopeConfig,
+        Http                 $httpRequest,
+        SystemConfig         $systemConfig
     ) {
         $this->scopeConfig = $scopeConfig;
         $this->httpRequest = $httpRequest;

app/code/Meta/Sales/Api/Data/CreateOrderApiProductItemInterface.php

@@ -158,9 +158,9 @@ public function setQuantity(int $quantity): CreateOrderApiProductItemInterface;
     /**
      * Get discount
      *
-     * @return \Meta\Sales\Api\Data\CreateOrderApiDiscountInterface
+     * @return \Meta\Sales\Api\Data\CreateOrderApiDiscountInterface | null
      */
-    public function getDiscount(): CreateOrderApiDiscountInterface;
+    public function getDiscount(): ?CreateOrderApiDiscountInterface;
 
     /**
      * Set discount

app/code/Meta/Sales/Model/Api/CreateOrderApi.php

@@ -302,6 +302,10 @@ private function populateAddress(
         if (!$address->getLastname()) {
             $address->setLastname($metaAddressInfo->getLastname());
         }
+
+        if (!$address->getTelephone()) {
+            $address->setTelephone($metaAddressInfo->getTelephone());
+        }
     }
 
     /**
@@ -477,6 +481,9 @@ public function createOrder(
             'email' => $email,
             'firstName' => $firstName,
             'lastName' => $lastName,
+            'productItems' => $productItems,
+            'shipmentDetails' => $shipmentDetails,
+            'billingAddress' => $billingAddress,
             'channel' => $channel,
             'buyerRemarketingOptIn' => $buyerRemarketingOptIn,
             'createInvoice' => $createInvoice

app/code/Meta/Sales/Model/Api/Data/CreateOrderApiProductItem.php

@@ -40,7 +40,7 @@ public function getName(): string
     /**
      * Sets the name of the product item.
      *
-     * @param  string $name
+     * @param string $name
      * @return CreateOrderApiProductItemInterface
      */
     public function setName(string $name): CreateOrderApiProductItemInterface
@@ -61,7 +61,7 @@ public function getSku(): string
     /**
      * Sets the SKU of the product item.
      *
-     * @param  string $sku
+     * @param string $sku
      * @return CreateOrderApiProductItemInterface
      */
     public function setSku(string $sku): CreateOrderApiProductItemInterface
@@ -82,7 +82,7 @@ public function getPerUnitBasePrice(): float
     /**
      * Sets the per unit base price of the product item.
      *
-     * @param  float $perUnitBasePrice
+     * @param float $perUnitBasePrice
      * @return CreateOrderApiProductItemInterface
      */
     public function setPerUnitBasePrice(float $perUnitBasePrice): CreateOrderApiProductItemInterface
@@ -103,7 +103,7 @@ public function getNetPrice(): float
     /**
      * Sets the net price of the product item.
      *
-     * @param  float $netPrice
+     * @param float $netPrice
      * @return CreateOrderApiProductItemInterface
      */
     public function setNetPrice(float $netPrice): CreateOrderApiProductItemInterface
@@ -124,7 +124,7 @@ public function getSubTotalPrice(): float
     /**
      * Sets the subtotal price of the product item.
      *
-     * @param  float $subTotalPrice
+     * @param float $subTotalPrice
      * @return CreateOrderApiProductItemInterface
      */
     public function setSubTotalPrice(float $subTotalPrice): CreateOrderApiProductItemInterface
@@ -145,7 +145,7 @@ public function getTax(): float
     /**
      * Sets the tax amount of the product item.
      *
-     * @param  float $tax
+     * @param float $tax
      * @return CreateOrderApiProductItemInterface
      */
     public function setTax(float $tax): CreateOrderApiProductItemInterface
@@ -166,7 +166,7 @@ public function getTaxRate(): float
     /**
      * Sets the tax rate of the product item.
      *
-     * @param  float $taxRate
+     * @param float $taxRate
      * @return CreateOrderApiProductItemInterface
      */
     public function setTaxRate(float $taxRate): CreateOrderApiProductItemInterface
@@ -187,7 +187,7 @@ public function getQuantity(): int
     /**
      * Sets the quantity of the product item.
      *
-     * @param  int $quantity
+     * @param int $quantity
      * @return CreateOrderApiProductItemInterface
      */
     public function setQuantity(int $quantity): CreateOrderApiProductItemInterface
@@ -198,17 +198,17 @@ public function setQuantity(int $quantity): CreateOrderApiProductItemInterface
     /**
      * Retrieves the discount applied to the product item.
      *
-     * @return CreateOrderApiDiscountInterface
+     * @return CreateOrderApiDiscountInterface | null
      */
-    public function getDiscount(): CreateOrderApiDiscountInterface
+    public function getDiscount(): ?CreateOrderApiDiscountInterface
     {
         return $this->_getData(self::DATA_DISCOUNT);
     }
 
     /**
      * Sets the discount applied to the product item.
      *
-     * @param  CreateOrderApiDiscountInterface $discount
+     * @param CreateOrderApiDiscountInterface $discount
      * @return CreateOrderApiProductItemInterface
      */
     public function setDiscount(CreateOrderApiDiscountInterface $discount): CreateOrderApiProductItemInterface