Improved add to cart stability (#763)

* improved add to cart stability

* use last added product id if swatch data is not available

Author: zlik

app/code/Meta/Conversion/view/frontend/templates/pixel/add_to_cart.phtml

@@ -1,24 +1,28 @@
 <?php
+
+use Magento\Framework\Escaper;
+use Meta\Conversion\Block\Pixel\AddToCart;
+
 /**
- * @var \Meta\Conversion\Block\Pixel\AddToCart $block
- * @var $escaper \Magento\Framework\Escaper
+ * @var AddToCart $block
+ * @var Escaper $escaper
  */
+
 $trackerUrl = $block->getTrackerUrl();
 ?>
 <?php if ($block->getFacebookPixelID()): ?>
     <!-- Added the new component below to track server events -->
     <script>
         window.addToCartData =
             <?= /* @noEscape */ json_encode([
-                "url" => $escaper->escapeUrl($trackerUrl),
-                "eventName" => $block->getEventToObserveName(),
+                'url' => $escaper->escapeUrl($trackerUrl),
+                'eventName' => $block->getEventToObserveName(),
                 'fbAgentVersion' => $block->getFacebookAgentVersion(),
                 'fbPixelId' => $block->getFacebookPixelID(),
                 'source' => $block->getSource(),
                 'pluginVersion' => $block->getPluginVersion(),
                 'track' => 'track',
                 'event' => 'AddToCart'
-
             ]); ?>
     </script>
     <script>
@@ -27,33 +31,38 @@ $trackerUrl = $block->getTrackerUrl();
             'Meta_Conversion/js/metaPixelTracker'
         ], function ($, metaPixelTracker) {
 
-            var product_info_url = '<?= /* @noEscape */ $block->getProductInfoUrl() ?>';
+            const product_info_url = '<?= /* @noEscape */ $block->getProductInfoUrl() ?>';
 
             $(document).on('ajax:addToCart', function (event, data) {
+                let simpleProductId;
+                // Get id of last added product
+                const productId = data.productIds[data.productIds.length - 1];
                 if (!data.response.backUrl) {
                     // check product data from swatch widget
-                    var swatchData = $('[data-role=swatch-options]').data('mage-SwatchRenderer');
-                    if (swatchData) {
-                        var simpleProductId = swatchData.getProductId();
+                    const swatchData = $('[data-role=swatch-options]').data('mage-SwatchRenderer');
+                    if (swatchData && swatchData.getProductId()) {
+                        simpleProductId = swatchData.getProductId();
                     } else {
                         // In case product is added from category page get options using added product's id
-                        // Get id of last added product
-                        var productId = data.productIds[data.productIds.length - 1];
-                        var categorySwatchData = $('[data-role=swatch-option-' + productId + ']')
+                        const categorySwatchData = $('[data-role=swatch-option-' + productId + ']')
                             .data('mage-SwatchRenderer');
-                        if (categorySwatchData) {
-                            var simpleProductId = categorySwatchData.getProductId();
+                        if (categorySwatchData && categorySwatchData.getProductId()) {
+                            simpleProductId = categorySwatchData.getProductId();
                         } else {
                             // else check product data from configurable options
-                            var configurableProduct = data.form.data().mageConfigurable;
+                            const configurableProduct = data.form.data().mageConfigurable;
                             if (configurableProduct) {
-                                var simpleProductId = configurableProduct.simpleProduct;
+                                simpleProductId = configurableProduct.simpleProduct;
                             }
                         }
                     }
                     // otherwise use the product sku
-                    var product_sku = data.sku;
-                    var form_key = jQuery("[name='form_key']").val();
+                    const product_sku = data.sku;
+                    // use last added product id if swatch data is not available
+                    if (!simpleProductId) {
+                        simpleProductId = productId;
+                    }
+                    const form_key = jQuery("[name='form_key']").val();
                     $.ajax({
                         url: product_info_url,
                         data: {
@@ -64,7 +73,7 @@ $trackerUrl = $block->getTrackerUrl();
                         type: 'get',
                         dataType: 'json',
                         success: function (res) {
-                            var addToCartConfigPixel = {
+                            const addToCartConfigPixel = {
                                 "url": window.addToCartData.url,
                                 "payload": {
                                     "eventName": window.addToCartData.eventName,