Address product API errors (#271)

* Address product API errors

* Fixed unit tests

Author: zlik

app/code/Meta/Catalog/Block/Adminhtml/Product/Form/Diagnostics.php

@@ -111,11 +111,16 @@ public function setProduct(ProductInterface $product)
      * @return array
      * @throws GuzzleException
      */
-    private function getFacebookProductDiagnostics()
+    private function getFacebookProductDiagnostics(): array
     {
+        // @todo #269 Missing catalog ID for product diagnostics
+        $catalogId = $this->systemConfig->getCatalogId($this->storeId);
+        if (!$catalogId) {
+            return [];
+        }
+
         try {
             $retailerId = $this->productIdentifier->getMagentoProductRetailerId($this->product);
-            $catalogId = $this->systemConfig->getCatalogId($this->storeId);
             $product = $this->graphApiAdapter->getProductByRetailerId($catalogId, $retailerId);
             $fbProductId = $product['data'][0]['id'] ?? false;
             if ($fbProductId) {

app/code/Meta/Catalog/Observer/Product/DeleteAfter.php

@@ -110,8 +110,9 @@ private function deleteProduct($storeId, $product): void
     {
         $isActive = $this->systemConfig->isActiveExtension($storeId);
         $shouldIncrement = $this->systemConfig->isActiveIncrementalProductUpdates($storeId);
+        $catalogId = $this->systemConfig->getCatalogId($storeId);
 
-        if (!($isActive && $shouldIncrement)) {
+        if (!($isActive && $shouldIncrement && $catalogId)) {
             return;
         }
 
@@ -123,7 +124,6 @@ private function deleteProduct($storeId, $product): void
             ];
             $this->graphApiAdapter->setDebugMode($this->systemConfig->isDebugMode($storeId))
                 ->setAccessToken($this->systemConfig->getAccessToken($storeId));
-            $catalogId = $this->systemConfig->getCatalogId($storeId);
             $this->graphApiAdapter->catalogBatchRequest($catalogId, [$requestData]);
         } catch (GuzzleException $e) {
             $this->messageManager->addErrorMessage(

app/code/Meta/Catalog/Observer/Product/SaveAfter.php

@@ -121,8 +121,9 @@ private function updateProduct($storeId, $productId): void
     {
         $isActive = $this->systemConfig->isActiveExtension($storeId);
         $shouldIncrement = $this->systemConfig->isActiveIncrementalProductUpdates($storeId);
+        $catalogId = $this->systemConfig->getCatalogId($storeId);
 
-        if (!($isActive && $shouldIncrement)) {
+        if (!($isActive && $shouldIncrement && $catalogId)) {
             return;
         }
 
@@ -137,7 +138,6 @@ private function updateProduct($storeId, $productId): void
             // @todo implement async call
             $this->graphApiAdapter->setDebugMode($this->systemConfig->isDebugMode($storeId))
                 ->setAccessToken($this->systemConfig->getAccessToken($storeId));
-            $catalogId = $this->systemConfig->getCatalogId($storeId);
             $requestData = $this->batchApi->buildRequestForIndividualProduct($product);
             $this->graphApiAdapter->catalogBatchRequest($catalogId, [$requestData]);
         } catch (NoSuchEntityException $e) {

app/code/Meta/Catalog/Test/Unit/Observer/ProcessProductAfterDeleteEventObserverTest.php

@@ -112,6 +112,8 @@ public function testExecution()
     {
         $this->systemConfig->method('isActiveExtension')->willReturn(true);
         $this->systemConfig->method('isActiveIncrementalProductUpdates')->willReturn(true);
+        $this->systemConfig->method('getCatalogId')->willReturn("12345");
+        $this->_graphApi->method('setDebugMode')->willReturn($this->_graphApi);
         $this->_graphApi->expects($this->atLeastOnce())->method('catalogBatchRequest');
         $this->systemConfig->method('isActiveExtension')->willReturn(true);
         $this->processProductAfterDeleteEventObserver->execute($this->_eventObserverMock);

app/code/Meta/Catalog/Test/Unit/Observer/ProcessProductAfterSaveEventObserverTest.php

@@ -121,6 +121,8 @@ public function testExecute(): void
 
         $productMock->method('getSendToFacebook')->willReturn(1);
 
+        $this->graphApiAdapterMock->method('setDebugMode')->willReturn($this->graphApiAdapterMock);
+
         $this->systemConfigMock->method('getCatalogId')->willReturn("12345");
 
         $this->batchApiMock->expects($this->once())