fix broken error in read api by mixed class not not (#586)

yang17 · Yang Ming · web-flow · commit 7bf905e07a53 · 2023-12-11T12:02:31.000-08:00
* fix broken error in read api by mixed class not not

---------

Co-authored-by: Yang Ming &lt;yangssr@fb.com&gt;
diff --git a/app/code/Meta/BusinessExtension/Api/SettingsWebhookListenerInterface.php b/app/code/Meta/BusinessExtension/Api/SettingsWebhookListenerInterface.php
@@ -18,7 +18,7 @@ public function processSettingsWebhookRequest(array $settingsWebhookRequest);
      * Process settings GET request
      *
      * @param string $externalBusinessId
-     * @return mixed
+     * @return \Meta\BusinessExtension\Api\CoreConfigInterface
      */
-    public function getCoreConfig(string $externalBusinessId);
+    public function getCoreConfig(string $externalBusinessId):CoreConfigInterface;
 }
diff --git a/app/code/Meta/BusinessExtension/Model/Api/SettingsWebhookListenerImpl.php b/app/code/Meta/BusinessExtension/Model/Api/SettingsWebhookListenerImpl.php
@@ -240,7 +240,7 @@ private function getMBEInstalledConfigsByExternalBusinessId(string $externalBusi
      * Process webhook GET request to pull core config from Magento to Meta
      *
      * @param string $externalBusinessId
-     * @return CoreConfigInterface
+     * @return \Meta\BusinessExtension\Api\CoreConfigInterface
      * @throws LocalizedException
      */
     public function getCoreConfig(string $externalBusinessId): CoreConfigInterface

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ public function processSettingsWebhookRequest(array $settingsWebhookRequest);`
`18`	`18`	`* Process settings GET request`
`19`	`19`	`*`
`20`	`20`	`* @param string $externalBusinessId`
`21`		`- * @return mixed`
	`21`	`+ * @return \Meta\BusinessExtension\Api\CoreConfigInterface`
`22`	`22`	`*/`
`23`		`- public function getCoreConfig(string $externalBusinessId);`
	`23`	`+ public function getCoreConfig(string $externalBusinessId):CoreConfigInterface;`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -240,7 +240,7 @@ private function getMBEInstalledConfigsByExternalBusinessId(string $externalBusi`
`240`	`240`	`* Process webhook GET request to pull core config from Magento to Meta`
`241`	`241`	`*`
`242`	`242`	`* @param string $externalBusinessId`
`243`		`- * @return CoreConfigInterface`
	`243`	`+ * @return \Meta\BusinessExtension\Api\CoreConfigInterface`
`244`	`244`	`* @throws LocalizedException`
`245`	`245`	`*/`
`246`	`246`	`public function getCoreConfig(string $externalBusinessId): CoreConfigInterface`