Skip to content

Commit a34d5df

Browse files
[Bug fixed] Toggling active integration flag is hiding Setup section (#555)
* Visibility of components handled based on visiblity flag * pending fields dependency added * Delete connection button is also guarded by active integration flag
1 parent 82c0f7a commit a34d5df

File tree

4 files changed

+14
-3
lines changed

4 files changed

+14
-3
lines changed

app/code/Meta/BusinessExtension/etc/adminhtml/system.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@
7474

7575
<field id="delete_connection" translate="label comment" type="select" sortOrder="20" showInDefault="0"
7676
showInWebsite="0" showInStore="1">
77+
<depends>
78+
<field id="facebook_business_extension/business_extension/active">1</field>
79+
</depends>
7780
<label>Delete Meta Connection</label>
7881
<frontend_model>Meta\BusinessExtension\Block\Adminhtml\System\Config\DeleteConnection</frontend_model>
7982
</field>
@@ -105,6 +108,9 @@
105108
<group id="testing" translate="label" type="text" sortOrder="200" showInDefault="1"
106109
showInWebsite="0" showInStore="1">
107110
<label>Developer Testing Mode</label>
111+
<depends>
112+
<field id="facebook_business_extension/business_extension/active">1</field>
113+
</depends>
108114
<field id="debug_mode" translate="label comment" type="select" sortOrder="10" showInDefault="1"
109115
showInWebsite="0" showInStore="1">
110116
<label>Extension Debug Mode</label>

app/code/Meta/Catalog/etc/adminhtml/system.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,14 @@
2525
</group>
2626
<group id="business_extension" translate="label" type="text" showInDefault="0"
2727
showInWebsite="0" showInStore="0">
28-
<depends>
29-
<field id="facebook_business_extension/business_extension/active">1</field>
30-
</depends>
3128
<field id="enable_catalog_sync" translate="label comment" type="select" sortOrder="10" showInDefault="1"
3229
showInWebsite="0" showInStore="1">
3330
<label>Enable Catalog Sync</label>
3431
<config_path>facebook/catalog_management/enable_catalog_sync</config_path>
3532
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
3633
<comment>Enable catalog syncing with Meta</comment>
3734
<depends>
35+
<field id="facebook_business_extension/business_extension/active">1</field>
3836
<field id="facebook_business_extension/testing/debug_mode">1</field>
3937
</depends>
4038
</field>
@@ -69,6 +67,9 @@
6967
</group>
7068
<group id="attribute_mapping" translate="label" type="text" sortOrder="30" showInDefault="1"
7169
showInWebsite="0" showInStore="1">
70+
<depends>
71+
<field id="facebook_business_extension/business_extension/active">1</field>
72+
</depends>
7273
<label>Catalog Configuration</label>
7374
<field id="custom_attribute_mapping" translate="label" sortOrder="10" showInDefault="1"
7475
showInWebsite="0" showInStore="1">

app/code/Meta/Promotions/etc/adminhtml/system.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
</comment>
1616
<depends>
1717
<field id="facebook_business_extension/testing/debug_mode">1</field>
18+
<field id="facebook_business_extension/business_extension/active">1</field>
1819
</depends>
1920
</field>
2021
</group>

app/code/Meta/Sales/etc/adminhtml/system.xml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
</comment>
3030
<depends>
3131
<field id="facebook_business_extension/testing/debug_mode">1</field>
32+
<field id="facebook_business_extension/business_extension/active">1</field>
3233
</depends>
3334
</field>
3435
<field id="default_fulfillment_location" translate="label comment" type="select" sortOrder="50"
@@ -38,6 +39,7 @@
3839
<source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
3940
<depends>
4041
<field id="facebook_business_extension/orders_sync/active">1</field>
42+
<field id="facebook_business_extension/business_extension/active">1</field>
4143
</depends>
4244
<comment>Store address is the default fulfillment location</comment>
4345
</field>
@@ -46,6 +48,7 @@
4648
<label>Fulfillment Address</label>
4749
<depends>
4850
<field id="facebook_business_extension/orders_sync/default_fulfillment_location">0</field>
51+
<field id="facebook_business_extension/business_extension/active">1</field>
4952
</depends>
5053
<field id="street_line1" translate="label" type="text" sortOrder="55" showInDefault="0"
5154
showInWebsite="0" showInStore="0">

0 commit comments

Comments
 (0)