[Regression fix]Verify existing feed function in feed API null string issue fixed (#419)

singhramanpreett · web-flow · commit b4cc45785273 · 2023-09-06T03:20:40.000+05:30
* Verify existing feed null string issue fixed

* php doc fixed
diff --git a/app/code/Meta/Catalog/Model/Product/Feed/Method/FeedApi.php b/app/code/Meta/Catalog/Model/Product/Feed/Method/FeedApi.php
@@ -173,11 +173,11 @@ private function createNewFeedAndSave(string $catalogId, string $feedName)
     /**
      * Verify is feed exists in Meta Catalog, if not returns null
      *
-     * @param string $feedId
+     * @param string|null $feedId
      * @param array $catalogFeeds
      * @return string|null
      */
-    private function verifyFeedExistsInMetaCatalog(string $feedId, array $catalogFeeds): ?string
+    private function verifyFeedExistsInMetaCatalog(?string $feedId, array $catalogFeeds): ?string
     {
         // make sure feed exists on meta side, not deleted
         if ($feedId) {

Original file line number	Diff line number	Diff line change
`@@ -173,11 +173,11 @@ private function createNewFeedAndSave(string $catalogId, string $feedName)`
`173`	`173`	`/**`
`174`	`174`	`* Verify is feed exists in Meta Catalog, if not returns null`
`175`	`175`	`*`
`176`		`- * @param string $feedId`
	`176`	`+ * @param string\|null $feedId`
`177`	`177`	`* @param array $catalogFeeds`
`178`	`178`	`* @return string\|null`
`179`	`179`	`*/`
`180`		`- private function verifyFeedExistsInMetaCatalog(string $feedId, array $catalogFeeds): ?string`
	`180`	`+ private function verifyFeedExistsInMetaCatalog(?string $feedId, array $catalogFeeds): ?string`
`181`	`181`	`{`
`182`	`182`	`// make sure feed exists on meta side, not deleted`
`183`	`183`	`if ($feedId) {`