Fix array to string conversion issue (#794)

* Fix array to string conversion issue

* Fix: Kodiak Security Findings

* Fix Console Error

---------

Co-authored-by: Pradeep Kanaka <[email protected]>

Author: pradeepkanaka

app/code/Meta/Catalog/Plugin/FacebookCatalogUpdateFullReindexPlugin.php

@@ -85,14 +85,22 @@ public function beforeReindexAll(Indexer $subject)
 
         while ($currentVersionId < $nextVersionId) {
             $walker = $this->getChangelogBatchWalkerInstance();
-            $batches = $walker->walk($cl, $currentVersionId, $nextVersionId, $batchSize);
-
-            foreach ($batches as $ids) {
-                if (empty($ids)) {
+            $batchIds = $walker->walk($cl, $currentVersionId, $nextVersionId, $batchSize);
+            /** Magento v2.4.7 and above, the walk function returns "yield" instead of an array */
+            if (is_array($batchIds)) {
+                if (empty($batchIds)) {
                     break;
                 }
                 $currentVersionId += $batchSize;
-                $this->fbCatalogUpdateResourceModel->addProductsWithChildren($ids, 'update');
+                $this->addProductsWithChildren($batchIds, 'update');
+            } else {
+                foreach ($batchIds as $ids) {
+                    if (empty($ids)) {
+                        break;
+                    }
+                    $this->addProductsWithChildren($ids, 'update');
+                }
+                $currentVersionId += $batchSize;
             }
         }
     }
@@ -118,6 +126,18 @@ public function getChangelogBatchWalkerInstance()
         );
     }
 
+    /**
+     * Add products with children
+     *
+     * @param array $batchesIds
+     * @param string $method
+     * @return int
+     */
+    private function addProductsWithChildren($batchesIds, $method)
+    {
+        return $this->fbCatalogUpdateResourceModel->addProductsWithChildren($batchesIds, $method);
+    }
+
     /**
      * Checks to run the catalog update plugin
      *