Modifying manual order sync logic to not display orders cancelled on Meta before they were created on Magento (#678)

Co-authored-by: Noah Ostrowski <[email protected]>

Author: nrostrow-meta

app/code/Meta/Sales/Helper/CommerceHelper.php

@@ -373,8 +373,10 @@ public function pullCancelledOrders(int $storeId): array
                     // Get cancellation details for each order (assuming a method exists in GraphAPIAdapter)
                     $cancellationDetails = $this->graphAPIAdapter->getCancellations($facebookOrderId)[0];
                     // Process cancellations (you would need to create a method to handle this)
-                    $this->createCancellation->execute($orderData, $cancellationDetails, $storeId);
-                    $cancelledOrdersDetails[$facebookOrderId] = $cancellationDetails;
+                    $wasOrderCancelled = $this->createCancellation->execute($orderData, $cancellationDetails, $storeId);
+                    if ($wasOrderCancelled) {
+                        $cancelledOrdersDetails[$facebookOrderId] = $cancellationDetails;
+                    }
                 } catch (Exception $e) {
                     $this->exceptions[] = $e->getMessage();
                     $this->fbeHelper->logExceptionImmediatelyToMeta(

app/code/Meta/Sales/Model/Order/CreateCancellation.php

@@ -94,16 +94,17 @@ public function __construct(
      *
      * @param array $facebookOrderData
      * @param array $facebookCancellationData
+     * @return bool
      * @throws LocalizedException
      */
-    public function execute(array $facebookOrderData, array $facebookCancellationData): void
+    public function execute(array $facebookOrderData, array $facebookCancellationData): bool
     {
         $magentoOrder = $this->getOrder($facebookOrderData);
         if (!$magentoOrder) {
-            return;
+            return false;
         }
         if ($this->isOrderPartiallyCanceled($magentoOrder)) {
-            return;
+            return false;
         }
         $cancelItems = $facebookCancellationData['items']['data'] ?? [];
         $shouldCancelOrder = $this->shouldCancelEntireOrder($magentoOrder, $cancelItems);
@@ -124,6 +125,7 @@ public function execute(array $facebookOrderData, array $facebookCancellationDat
             $magentoOrder->addCommentToStatusHistory(self::CANCELLATION_NOTE . $concatenatedString);
         }
         $this->orderRepository->save($magentoOrder);
+        return true;
     }
 
     /**