remove product identifier from ui (#241)

Author: zlik

app/code/Meta/BusinessExtension/etc/config.xml

@@ -6,6 +6,9 @@
                 <active>1</active>
                 <onsite>0</onsite>
             </business_extension>
+            <catalog_management>
+                <product_identifier>sku</product_identifier>
+            </catalog_management>
             <debug>
                 <debug_mode>1</debug_mode>
             </debug>

app/code/Meta/Catalog/etc/adminhtml/system.xml

@@ -29,12 +29,6 @@
                     <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
                     <comment>Synchronize changes with Meta every time a product is saved or deleted</comment>
                 </field>
-                <field id="product_identifier" translate="label comment" type="select" sortOrder="50" showInDefault="1" showInWebsite="0" showInStore="1">
-                    <label>Product Identifier</label>
-                    <config_path>facebook/catalog_management/product_identifier</config_path>
-                    <source_model>Meta\Catalog\Model\Config\Source\Product\Identifier</source_model>
-                    <comment>Adobe Commerce product attribute mapped to Retailer ID / Content ID on Meta. Warning: use with caution, as changing this option after uploading products to Meta might result in having duplicate products in your Meta catalog</comment>
-                </field>
                 <field id="price_incl_tax" translate="label comment" type="select" sortOrder="60" showInDefault="0" showInWebsite="0" showInStore="0">
                     <label>Price Including Tax</label>
                     <config_path>facebook/catalog_management/price_incl_tax</config_path>

app/code/Meta/Catalog/etc/config.xml

@@ -6,7 +6,6 @@
                 <daily_product_feed>0</daily_product_feed>
                 <feed_upload_method>feed_api</feed_upload_method>
                 <incremental_product_updates>0</incremental_product_updates>
-                <product_identifier>sku</product_identifier>
                 <price_incl_tax>0</price_incl_tax>
                 <collections_sync>0</collections_sync>
             </catalog_management>

app/code/Meta/Conversion/Helper/MagentoDataHelper.php

@@ -22,7 +22,6 @@
 use Magento\Framework\Exception\LocalizedException;
 use Magento\Quote\Api\Data\CartInterface;
 use Magento\Store\Model\StoreManagerInterface;
-use Meta\Catalog\Helper\Product\Identifier as ProductIdentifier;
 use Magento\Catalog\Model\Product;
 use Magento\ConfigurableProduct\Model\Product\Type\Configurable;
 use Magento\Framework\Exception\NoSuchEntityException;
@@ -49,11 +48,6 @@ class MagentoDataHelper
      */
     private ProductRepositoryInterface $productRepository;
 
-    /**
-     * @var ProductIdentifier
-     */
-    private ProductIdentifier $productIdentifier;
-
     /**
      * @var CategoryRepositoryInterface
      */
@@ -74,22 +68,19 @@ class MagentoDataHelper
      *
      * @param StoreManagerInterface $storeManager
      * @param ProductRepositoryInterface $productRepository
-     * @param ProductIdentifier $productIdentifier
      * @param CategoryRepositoryInterface $categoryRepository
      * @param PricingHelper $pricingHelper
      * @param SystemConfig $systemConfig
      */
     public function __construct(
         StoreManagerInterface $storeManager,
         ProductRepositoryInterface $productRepository,
-        ProductIdentifier $productIdentifier,
         CategoryRepositoryInterface $categoryRepository,
         PricingHelper $pricingHelper,
         SystemConfig $systemConfig
     ) {
         $this->storeManager = $storeManager;
         $this->productRepository = $productRepository;
-        $this->productIdentifier = $productIdentifier;
         $this->categoryRepository = $categoryRepository;
         $this->pricingHelper = $pricingHelper;
         $this->identifierAttr = $systemConfig->getProductIdentifierAttr();

app/code/Meta/Conversion/composer.json

@@ -12,8 +12,7 @@
         "magento/module-sales": "*",
         "magento/module-store": "*",
         "magento/module-quote": "*",
-        "meta/module-business-extension": "*",
-        "meta/module-catalog": "*"
+        "meta/module-business-extension": "*"
     },
     "license": "Apache-2.0",
     "autoload": {

app/code/Meta/Conversion/etc/module.xml

@@ -11,7 +11,6 @@
             <module name="Magento_Store"/>
             <module name="Magento_Quote"/>
             <module name="Meta_BusinessExtension"/>
-            <module name="Meta_Catalog"/>
         </sequence>
     </module>
 </config>