Merge pull request #872 from pradeepkanaka/app-assurance

asarrosd · web-flow · commit d8af74ace8f9 · 2025-04-03T09:54:22.000-04:00
[ADO-333] App assurance
diff --git a/app/code/Meta/BusinessExtension/Block/Adminhtml/System/Config/DeleteConnection.php b/app/code/Meta/BusinessExtension/Block/Adminhtml/System/Config/DeleteConnection.php
@@ -120,7 +120,7 @@ public function getButtonHtml()
      *
      * @return mixed
      */
-    protected function getStoreId()
+    public function getStoreId()
     {
         $storeId = $this->getRequest()->getParam('store');
         if ($storeId === null && $this->systemConfig->isSingleStoreMode()) {
diff --git a/app/code/Meta/BusinessExtension/Controller/Adminhtml/ApiKey/Index.php b/app/code/Meta/BusinessExtension/Controller/Adminhtml/ApiKey/Index.php
@@ -29,17 +29,17 @@ class Index extends Action
     /**
      * @var KeyGenerator
      */
-    protected $apiKeyGenerator;
+    public $apiKeyGenerator;
 
     /**
      * @var WriterInterface
      */
-    protected $configWriter;
+    public $configWriter;
 
     /**
      * @var LoggerInterface
      */
-    protected $logger;
+    public $logger;
 
     /**
      * Index constructor
diff --git a/app/code/Meta/BusinessExtension/Model/Api/CoreConfigFactory.php b/app/code/Meta/BusinessExtension/Model/Api/CoreConfigFactory.php
@@ -29,7 +29,7 @@ class CoreConfigFactory
      *
      * @var ObjectManagerInterface
      */
-    protected ObjectManagerInterface $objectManager;
+    public ObjectManagerInterface $objectManager;
 
     /**
      * @param ObjectManagerInterface $objectManager
diff --git a/app/code/Meta/BusinessExtension/Model/Api/CustomApiKey/ApiKeyService.php b/app/code/Meta/BusinessExtension/Model/Api/CustomApiKey/ApiKeyService.php
@@ -33,22 +33,22 @@ class ApiKeyService
     /**
      * @var KeyGenerator
      */
-    protected $apiKeyGenerator;
+    public $apiKeyGenerator;
 
     /**
      * @var WriterInterface
      */
-    protected $configWriter;
+    public $configWriter;
 
     /**
      * @var ScopeConfigInterface
      */
-    protected $scopeConfig;
+    public $scopeConfig;
 
     /**
      * @var LoggerInterface
      */
-    protected $logger;
+    public $logger;
 
     /**
      * @param KeyGenerator         $apiKeyGenerator
diff --git a/app/code/Meta/BusinessExtension/Model/Api/CustomApiKey/Authenticator.php b/app/code/Meta/BusinessExtension/Model/Api/CustomApiKey/Authenticator.php
@@ -31,7 +31,7 @@ class Authenticator
     /**
      * @var ScopeConfigInterface
      */
-    protected $scopeConfig;
+    public $scopeConfig;
 
     /**
      * @var Http
diff --git a/app/code/Meta/BusinessExtension/Test/Unit/Controller/Adminhtml/Ajax/PersistConfigurationTest.php b/app/code/Meta/BusinessExtension/Test/Unit/Controller/Adminhtml/Ajax/PersistConfigurationTest.php
@@ -28,37 +28,37 @@ class PersistConfigurationTest extends \PHPUnit\Framework\TestCase
     /**
      * @var MockObject
      */
-    protected $fbeHelper;
+    public $fbeHelper;
 
     /**
      * @var MockObject
      */
-    protected $systemConfig;
+    public $systemConfig;
 
     /**
      * @var MockObject
      */
-    protected $context;
+    public $context;
 
     /**
      * @var MockObject
      */
-    protected $resultJsonFactory;
+    public $resultJsonFactory;
 
     /**
      * @var \Meta\BusinessExtension\Controller\Adminhtml\Ajax\PersistConfiguration
      */
-    protected $fbFeedPush;
+    public $fbFeedPush;
 
     /**
      * @var MockObject
      */
-    protected $request;
+    public $request;
 
     /**
      * @var MockObject
      */
-    protected $graphApiAdapter;
+    public $graphApiAdapter;
 
     /**
      * Used to reset or change values after running a test
diff --git a/app/code/Meta/Catalog/Block/Adminhtml/Config/Backend/ArraySerialized.php b/app/code/Meta/Catalog/Block/Adminhtml/Config/Backend/ArraySerialized.php
@@ -19,7 +19,7 @@ class ArraySerialized extends ConfigValue
     /**
      * @var SerializerInterface
      */
-    protected $serializer;
+    public $serializer;
 
     /**
      * @var Logger
diff --git a/app/code/Meta/Catalog/Model/Product/Feed/Method/NavigationFeedApi.php b/app/code/Meta/Catalog/Model/Product/Feed/Method/NavigationFeedApi.php
@@ -37,7 +37,7 @@ class NavigationFeedApi
     /**
      * @var int
      */
-    protected int $storeId;
+    public int $storeId;
 
     /**
      * @var FBEHelper
@@ -46,12 +46,12 @@ class NavigationFeedApi
     /**
      * @var SystemConfig
      */
-    protected SystemConfig $systemConfig;
+    public SystemConfig $systemConfig;
 
     /**
      * @var Filesystem
      */
-    protected Filesystem $fileSystem;
+    public Filesystem $fileSystem;
     /**
      * @var CategoryUtilities
      */
@@ -88,7 +88,7 @@ public function __construct(
      * @return string
      * @throws NoSuchEntityException
      */
-    protected function getFeedFileName(): string
+    public function getFeedFileName(): string
     {
         $defaultStoreId = $this->systemConfig->getStoreManager()->getDefaultStoreView()->getId();
         $storeCode = $this->systemConfig->getStoreManager()->getStore($this->storeId)->getCode();
@@ -106,7 +106,7 @@ protected function getFeedFileName(): string
      * @throws FileSystemException
      * @throws NoSuchEntityException
      */
-    protected function generateNavigationFeed($jsTreeData): string
+    public function generateNavigationFeed($jsTreeData): string
     {
         $filePath = 'export/' . $this->getFeedFileName();
         $directory = $this->fileSystem->getDirectoryWrite(self::VAR_DIR);
diff --git a/app/code/Meta/Catalog/Model/Product/Feed/Method/RatingsAndReviewsFeedApi.php b/app/code/Meta/Catalog/Model/Product/Feed/Method/RatingsAndReviewsFeedApi.php
@@ -40,7 +40,7 @@ class RatingsAndReviewsFeedApi
     /**
      * @var int
      */
-    protected int $storeId;
+    public int $storeId;
 
     /**
      * @var FBEHelper
@@ -50,7 +50,7 @@ class RatingsAndReviewsFeedApi
     /**
      * @var SystemConfig
      */
-    protected SystemConfig $systemConfig;
+    public SystemConfig $systemConfig;
 
     /**
      * @var BuilderTools
@@ -65,7 +65,7 @@ class RatingsAndReviewsFeedApi
     /**
      * @var Filesystem
      */
-    protected Filesystem $fileSystem;
+    public Filesystem $fileSystem;
 
     /**
      * @var ReviewCollectionFactory
diff --git a/app/code/Meta/Catalog/Test/Unit/Observer/ProcessCategoryAfterSaveEventObserverTest.php b/app/code/Meta/Catalog/Test/Unit/Observer/ProcessCategoryAfterSaveEventObserverTest.php
@@ -33,7 +33,7 @@ class ProcessCategoryAfterSaveEventObserverTest extends TestCase
     /**
      * @var ProcessCategoryAfterSaveEventObserver
      */
-    protected $processCategoryAfterSaveEventObserver;
+    public $processCategoryAfterSaveEventObserver;
 
     /**
      * @var MockObject
diff --git a/app/code/Meta/Conversion/Test/Unit/Observer/CommonTest.php b/app/code/Meta/Conversion/Test/Unit/Observer/CommonTest.php
@@ -32,22 +32,22 @@ abstract class CommonTest extends TestCase
     /**
      * @var MockObject
      */
-    protected $magentoDataHelper;
+    public $magentoDataHelper;
 
     /**
      * @var MockObject
      */
-    protected $fbeHelper;
+    public $fbeHelper;
 
     /**
      * @var MockObject
      */
-    protected $systemConfig;
+    public $systemConfig;
 
     /**
      * @var ObjectManager
      */
-    protected $objectManager;
+    public $objectManager;
 
     /**
      * Used to reset or change values after running a test
diff --git a/app/code/Meta/Promotions/Block/Adminhtml/System/Config/PushPromotions.php b/app/code/Meta/Promotions/Block/Adminhtml/System/Config/PushPromotions.php
@@ -106,7 +106,7 @@ public function getButtonHtml()
      *
      * @return mixed
      */
-    protected function getStoreId()
+    public function getStoreId()
     {
         return $this->getRequest()->getParam('store');
     }
diff --git a/app/code/Meta/Promotions/Model/Promotion/Feed/Builder.php b/app/code/Meta/Promotions/Model/Promotion/Feed/Builder.php
@@ -70,7 +70,7 @@ class Builder
     /**
      * @var SystemConfig
      */
-    protected $systemConfig;
+    public $systemConfig;
 
     /**
      * @var int
@@ -90,7 +90,7 @@ class Builder
     /**
      * @var CollectionFactory
      */
-    protected $couponFactory;
+    public $couponFactory;
 
     /**
      * Constructor
diff --git a/app/code/Meta/Promotions/Model/Promotion/Feed/Method/FeedApi.php b/app/code/Meta/Promotions/Model/Promotion/Feed/Method/FeedApi.php
@@ -40,22 +40,22 @@ class FeedApi
     /**
      * @var int
      */
-    protected $storeId;
+    public $storeId;
 
     /**
      * @var SystemConfig
      */
-    protected $systemConfig;
+    public $systemConfig;
 
     /**
      * @var GraphAPIAdapter
      */
-    protected $graphApiAdapter;
+    public $graphApiAdapter;
 
     /**
      * @var Filesystem
      */
-    protected $fileSystem;
+    public $fileSystem;
 
     /**
      * @var LoggerInterface
@@ -65,12 +65,12 @@ class FeedApi
     /**
      * @var Builder
      */
-    protected $builder;
+    public $builder;
 
     /**
      * @var PromotionRetriever
      */
-    protected $promotionRetriever;
+    public $promotionRetriever;
 
     /**
      * @param SystemConfig $systemConfig
@@ -103,7 +103,7 @@ public function __construct(
      * @throws FileSystemException
      * @throws Exception
      */
-    protected function writeFile(WriteInterface $fileStream)
+    public function writeFile(WriteInterface $fileStream)
     {
         $fileStream->writeCsv($this->builder->getHeaderFields(), "\t");
 
@@ -130,7 +130,7 @@ protected function writeFile(WriteInterface $fileStream)
      * @return string
      * @throws NoSuchEntityException
      */
-    protected function getFeedFileName()
+    public function getFeedFileName()
     {
         $defaultStoreId = $this->systemConfig->getStoreManager()->getDefaultStoreView()->getId();
         $storeCode = $this->systemConfig->getStoreManager()->getStore($this->storeId)->getCode();
@@ -147,7 +147,7 @@ protected function getFeedFileName()
      * @throws FileSystemException
      * @throws NoSuchEntityException
      */
-    protected function generatePromoFeed()
+    public function generatePromoFeed()
     {
         $file = 'export/' . $this->getFeedFileName();
         $directory = $this->fileSystem->getDirectoryWrite(self::VAR_DIR);
diff --git a/app/code/Meta/Promotions/Model/Promotion/Feed/PromotionRetriever/PromotionRetriever.php b/app/code/Meta/Promotions/Model/Promotion/Feed/PromotionRetriever/PromotionRetriever.php
@@ -30,12 +30,12 @@ class PromotionRetriever
     /**
      * @var FBEHelper
      */
-    protected $fbeHelper;
+    public $fbeHelper;
 
     /**
      * @var RuleCollection
      */
-    protected $ruleCollection;
+    public $ruleCollection;
 
     /**
      * @param FBEHelper $fbeHelper
diff --git a/app/code/Meta/Promotions/Model/Promotion/Feed/Uploader.php b/app/code/Meta/Promotions/Model/Promotion/Feed/Uploader.php
@@ -29,12 +29,12 @@ class Uploader
     /**
      * @var SystemConfig
      */
-    protected $systemConfig;
+    public $systemConfig;
 
     /**
      * @var MethodFeedApi
      */
-    protected $methodFeedApi;
+    public $methodFeedApi;
 
     /**
      * @param SystemConfig $systemConfig
diff --git a/app/code/Meta/Sales/Block/Adminhtml/Order/View/Tab/Facebook.php b/app/code/Meta/Sales/Block/Adminhtml/Order/View/Tab/Facebook.php
@@ -38,7 +38,7 @@ class Facebook extends Template implements TabInterface
     /**
      * @var SystemConfig
      */
-    protected $systemConfig;
+    public $systemConfig;
 
     /**
      * @var Admin
diff --git a/app/code/Meta/Sales/Model/Api/CreateOrderApi.php b/app/code/Meta/Sales/Model/Api/CreateOrderApi.php
@@ -103,7 +103,7 @@ class CreateOrderApi implements CreateOrderApiInterface
     /**
      * @var CheckoutSession
      */
-    protected CheckoutSession $checkoutSession;
+    public CheckoutSession $checkoutSession;
 
     /**
      * @var RemoteAddress|mixed
diff --git a/app/code/Meta/Sales/Model/Order/CreateCancellation.php b/app/code/Meta/Sales/Model/Order/CreateCancellation.php
@@ -53,13 +53,13 @@ class CreateCancellation
     /**
      * @var TransactionFactory
      */
-    protected $transactionFactory;
+    public $transactionFactory;
 
     /**
      * @var FBEHelper
      */
 
-    protected $fbeHelper;
+    public $fbeHelper;
 
     /**
      * @var LoggerInterface
diff --git a/app/code/Meta/Sales/Model/Order/CreateRefund.php b/app/code/Meta/Sales/Model/Order/CreateRefund.php
diff --git a/app/code/Meta/Sales/Observer/MetaObserverTrait.php b/app/code/Meta/Sales/Observer/MetaObserverTrait.php
diff --git a/app/code/Meta/Sales/Observer/Order/Cancel.php b/app/code/Meta/Sales/Observer/Order/Cancel.php
diff --git a/app/code/Meta/Sales/Observer/Order/Refund.php b/app/code/Meta/Sales/Observer/Order/Refund.php
diff --git a/app/code/Meta/Sales/Observer/Order/ShipmentObserver.php b/app/code/Meta/Sales/Observer/Order/ShipmentObserver.php
diff --git a/app/code/Meta/Sales/Plugin/ShippingData.php b/app/code/Meta/Sales/Plugin/ShippingData.php

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public function getButtonHtml()`
`120`	`120`	`*`
`121`	`121`	`* @return mixed`
`122`	`122`	`*/`
`123`		`- protected function getStoreId()`
	`123`	`+ public function getStoreId()`
`124`	`124`	`{`
`125`	`125`	`$storeId = $this->getRequest()->getParam('store');`
`126`	`126`	`if ($storeId === null && $this->systemConfig->isSingleStoreMode()) {`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class CoreConfigFactory`
`29`	`29`	`*`
`30`	`30`	`* @var ObjectManagerInterface`
`31`	`31`	`*/`
`32`		`- protected ObjectManagerInterface $objectManager;`
	`32`	`+ public ObjectManagerInterface $objectManager;`
`33`	`33`
`34`	`34`	`/**`
`35`	`35`	`* @param ObjectManagerInterface $objectManager`