Skip to content

Commit db76b2c

Browse files
committed
ADO-313: uses different event for checkout success observer
1 parent eef709e commit db76b2c

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

app/code/Meta/Conversion/Observer/Tracker/Purchase.php

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66
use Magento\Framework\Event\Observer;
77
use Magento\Framework\Event\ObserverInterface;
88
use Meta\Conversion\Model\Tracker\Purchase as PurchaseTracker;
9-
use Magento\Checkout\Model\Session as CheckoutSession;
109
use Meta\Conversion\Model\CapiTracker;
11-
use Meta\Conversion\Model\CapiEventIdHandler;
1210

1311
class Purchase implements ObserverInterface
1412
{
@@ -17,17 +15,14 @@ class Purchase implements ObserverInterface
1715

1816
public function __construct(
1917
private readonly PurchaseTracker $purchaseTracker,
20-
private readonly CheckoutSession $checkoutSession,
21-
private readonly CapiTracker $capiTracker,
22-
private readonly CapiEventIdHandler $capiEventIdHandler
18+
private readonly CapiTracker $capiTracker
2319
) { }
2420

2521
public function execute(Observer $observer): void
2622
{
27-
// Purchase event is triggered twice sometimes, to prevent that check if event id is already stored for current request
28-
// if it does prevent the message form being added to the message queue.
29-
if (!$this->capiEventIdHandler->getMetaEventId(self::EVENT_NAME)) {
30-
$lastOrderId = $this->checkoutSession->getLastRealOrder()->getEntityId();
23+
$orderIds = $observer->getEvent()->getOrderIds();
24+
$lastOrderId = !empty($orderIds) ? $orderIds[0] : null;
25+
if ($lastOrderId) {
3126
$payload = $this->purchaseTracker->getPayload(['lastOrder' => $lastOrderId]);
3227
$this->capiTracker->execute($payload, self::EVENT_NAME, $this->purchaseTracker->getEventType());
3328
}

app/code/Meta/Conversion/etc/frontend/events.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<observer name="trigger_initiate_checkout_capi_event" instance="Meta\Conversion\Observer\Tracker\InitiateCheckout" />
1818
</event>
1919

20-
<event name="controller_action_postdispatch_checkout_onepage_success">
20+
<event name="checkout_onepage_controller_success_action">
2121
<observer name="trigger_purchase_capi_event" instance="Meta\Conversion\Observer\Tracker\Purchase" />
2222
</event>
2323

0 commit comments

Comments
 (0)