Static Tests

Author: bgiamarino

app/code/Meta/BusinessExtension/Helper/MagentoDataHelper.php

@@ -400,6 +400,7 @@ public function getOrderTotal(): ?float
 
     /**
      * Return information about the last order items
+     *
      * @link https://developers.facebook.com/docs/marketing-api/conversions-api/parameters/custom-data/#contents
      *
      * @return array
@@ -555,7 +556,7 @@ public function getUserDataFromSession(): array
     /**
      * Get Hash value
      *
-     * @param $string
+     * @param string $string
      * @return string
      */
     private function hashValue($string): string

app/code/Meta/Conversion/Controller/Pixel/ProductInfoForAddToCart.php

@@ -25,6 +25,7 @@
 use Magento\Framework\Controller\ResultInterface;
 use Magento\Framework\Data\Form\FormKey\Validator;
 use Magento\Framework\Pricing\Helper\Data;
+use Magento\Framework\View\Asset\File\NotFoundException;
 use Meta\BusinessExtension\Helper\MagentoDataHelper;
 use Meta\Conversion\Helper\EventIdGenerator;
 use Meta\BusinessExtension\Helper\FBEHelper;
@@ -108,7 +109,7 @@ private function getCategory(Product $product): ?string
                 $category = $categoryModel->load($categoryId);
                 $categoryNames[] = $category->getName();
             }
-            return addslashes(implode(',', $categoryNames));
+            return addslashes(implode(',', $categoryNames)); // phpcs: ignore
         } else {
             return null;
         }
@@ -117,7 +118,7 @@ private function getCategory(Product $product): ?string
     /**
      * Get formatted price
      *
-     * @param $product
+     * @param Product $product
      * @return float|string
      */
     private function getPriceValue($product)
@@ -128,8 +129,8 @@ private function getPriceValue($product)
     /**
      * Get Product Info
      *
-     * @param $productSku
-     * @param null $productId
+     * @param mixed $productSku
+     * @param mixed $productId
      * @return array
      */
     private function getProductInfo($productSku, $productId = null): array
@@ -153,7 +154,10 @@ private function getProductInfo($productSku, $productId = null): array
     }
 
     /**
-     * @ingeritdoc
+     * Execute function
+     *
+     * @returns ResultInterface
+     * @throws NotFoundException
      */
     public function execute()
     {
@@ -178,7 +182,7 @@ public function execute()
     /**
      * Track the server event
      *
-     * @param $eventId
+     * @param string $eventId
      * @return void
      */
     public function trackServerEvent($eventId): void

app/code/Meta/Conversion/view/frontend/templates/pixel/add_to_cart.phtml

@@ -6,12 +6,12 @@
         ], function ($) {
 
             function trackAddToCart(content_ids, content_name, content_category, value, eventId) {
-                fbq('set', 'agent', '<?= /* @escapeNotVerified */ $block->getFacebookAgentVersion() ?>', '<?= /* @escapeNotVerified */ $block->getFacebookPixelID() ?>');
+                fbq('set', 'agent', '<?= /* @noEscape */ $ $block->getFacebookAgentVersion() ?>', '<?= /* @noEscape */ $block->getFacebookPixelID() ?>');
                 fbq('track', 'AddToCart', {
-                        source: "<?= /* @escapeNotVerified */ $block->getSource() ?>",
-                        pluginVersion: "<?= /* @escapeNotVerified */ $block->getPluginVersion() ?>",
-                        content_type: "<?= /* @escapeNotVerified */ $block->getContentType() ?>",
-                        currency: "<?= /* @escapeNotVerified */ $block->getCurrency() ?>",
+                        source: "<?= /* @noEscape */ $block->getSource() ?>",
+                        pluginVersion: "<?= /* @noEscape */ $block->getPluginVersion() ?>",
+                        content_type: "<?= /* @noEscape */ $block->getContentType() ?>",
+                        currency: "<?= /* @noEscape */ $block->getCurrency() ?>",
                         content_ids: content_ids,
                         content_name: content_name,
                         content_category: content_category,
@@ -23,7 +23,7 @@
                 );
             }
 
-            var product_info_url = '<?= /* @escapeNotVerified */ $block->getProductInfoUrl() ?>';
+            var product_info_url = '<?= /* @noEscape */ $block->getProductInfoUrl() ?>';
 
             $(document).on('ajax:addToCart', function (event, data) {
                 var configurableProduct = data.form.data().mageConfigurable;