fixed error message for refund, shipped and cancel order (#247)

* fixed error message for refund, shipped and cancel order

* updated code as per code review comments

* fixed error message for refund, shipped and cancel order

* updated code as per code review comments

* fixed static code warnings

* fixed static code warnings

---------

Co-authored-by: Atul Dusane <[email protected]>

Author: atuld123

app/code/Meta/Sales/Observer/Order/Cancel.php

@@ -17,6 +17,7 @@
 
 namespace Meta\Sales\Observer\Order;
 
+use Exception;
 use GuzzleHttp\Exception\GuzzleException;
 use Magento\Framework\Event\Observer;
 use Magento\Framework\Event\ObserverInterface;
@@ -86,13 +87,22 @@ public function execute(Observer $observer)
      * @param string $fbOrderId
      * @return void
      * @throws GuzzleException
+     * @throws Exception
      */
     private function cancelOrder(int $storeId, string $fbOrderId)
     {
         $this->graphAPIAdapter
             ->setDebugMode($this->systemConfig->isDebugMode($storeId))
             ->setAccessToken($this->systemConfig->getAccessToken($storeId));
-
-        $this->graphAPIAdapter->cancelOrder($fbOrderId);
+        try {
+            $this->graphAPIAdapter->cancelOrder($fbOrderId);
+        } catch (GuzzleException $e) {
+            $response = $e->getResponse();
+            $body = json_decode($response->getBody());
+            throw new Exception('Error Code: '
+                .(string) $body->error->code
+                .'; '
+                . (string) $body->error->error_user_msg);
+        }
     }
 }

app/code/Meta/Sales/Observer/Order/MarkAsShipped.php

@@ -17,6 +17,7 @@
 
 namespace Meta\Sales\Observer\Order;
 
+use Exception;
 use Meta\Sales\Model\Order\Shipper;
 use Meta\BusinessExtension\Model\System\Config as SystemConfig;
 use GuzzleHttp\Exception\GuzzleException;
@@ -64,6 +65,7 @@ public function __construct(
      * @param Observer $observer
      * @throws LocalizedException
      * @throws GuzzleException
+     * @throws Exception
      */
     public function execute(Observer $observer)
     {
@@ -88,7 +90,15 @@ public function execute(Observer $observer)
             && $this->systemConfig->isOnsiteCheckoutEnabled($storeId))) {
             return;
         }
-
-        $this->shipper->markAsShipped($shipment);
+        try {
+            $this->shipper->markAsShipped($shipment);
+        } catch (GuzzleException $e) {
+            $response = $e->getResponse();
+            $body = json_decode($response->getBody());
+            throw new Exception('Error Code: '
+                .(string) $body->error->code
+                .'; '
+                . (string) $body->error->error_user_msg);
+        }
     }
 }

app/code/Meta/Sales/Observer/Order/Refund.php

@@ -146,6 +146,7 @@ public function execute(Observer $observer)
      * @param string|null $currencyCode
      * @param string|null $reasonText
      * @throws GuzzleException
+     * @throws Exception
      */
     private function refundOrder(
         int $storeId,
@@ -159,13 +160,22 @@ private function refundOrder(
             ->setDebugMode($this->systemConfig->isDebugMode($storeId))
             ->setAccessToken($this->systemConfig->getAccessToken($storeId));
 
-        $this->graphAPIAdapter->refundOrder(
-            $fbOrderId,
-            $items,
-            $shippingRefundAmount,
-            $currencyCode,
-            $reasonText
-        );
+        try {
+            $this->graphAPIAdapter->refundOrder(
+                $fbOrderId,
+                $items,
+                $shippingRefundAmount,
+                $currencyCode,
+                $reasonText
+            );
+        } catch (GuzzleException $e) {
+            $response = $e->getResponse();
+            $body = json_decode($response->getBody());
+            throw new Exception('Error Code: '
+                .(string) $body->error->code
+                .'; '
+                . (string) $body->error->error_user_msg);
+        }
     }
 
     /**