110: Extension has no version (#133)

Author: omiroshnichenko

app/code/Meta/BusinessExtension/Model/System/Config.php

@@ -19,9 +19,11 @@
 
 use Magento\Config\Model\ResourceModel\Config as ResourceConfig;
 use Magento\Framework\App\Cache\TypeListInterface;
+use Magento\Framework\App\CacheInterface;
+use Magento\Framework\App\Config as AppConfig;
 use Magento\Framework\App\Config\ScopeConfigInterface;
+use Magento\Framework\Composer\ComposerInformation;
 use Magento\Framework\Exception\NoSuchEntityException;
-use Magento\Framework\Module\ModuleListInterface;
 use Magento\Store\Model\ScopeInterface;
 use Magento\Store\Model\StoreManagerInterface;
 
@@ -30,7 +32,8 @@
  */
 class Config
 {
-    private const MODULE_NAME = 'Meta_BusinessExtension';
+    private const VERSION_CACHE_KEY = 'meta-business-extension-version';
+    private const EXTENSION_PACKAGE_NAME = 'meta/meta-for-magento2';
 
     private const XML_PATH_FACEBOOK_BUSINESS_EXTENSION_ACTIVE = 'facebook/business_extension/active';
     public const XML_PATH_FACEBOOK_BUSINESS_EXTENSION_INSTALLED = 'facebook/business_extension/installed';
@@ -111,36 +114,51 @@ class Config
     private $resourceConfig;
 
     /**
-     * @var ModuleListInterface
+     * @var TypeListInterface
      */
-    private $moduleList;
+    private $cacheTypeList;
 
     /**
-     * @var TypeListInterface
+     * @var CacheInterface
      */
-    private $cacheTypeList;
+    private $cache;
+
+    /**
+     * @var ComposerInformation
+     */
+    private $composerInformation;
+
+    /**
+     * Extension version
+     *
+     * @var string
+     */
+    private $version;
 
     /**
      * @method __construct
      * @param StoreManagerInterface $storeManager
      * @param ScopeConfigInterface $scopeConfig
      * @param ResourceConfig $resourceConfig
-     * @param ModuleListInterface $moduleList
      * @param TypeListInterface $cacheTypeList
+     * @param CacheInterface $cache
+     * @param ComposerInformation $composerInformation
      * @SuppressWarnings(PHPMD.ExcessivePublicCount)
      */
     public function __construct(
         StoreManagerInterface $storeManager,
         ScopeConfigInterface  $scopeConfig,
         ResourceConfig        $resourceConfig,
-        ModuleListInterface   $moduleList,
-        TypeListInterface     $cacheTypeList
+        TypeListInterface     $cacheTypeList,
+        CacheInterface $cache,
+        ComposerInformation $composerInformation
     ) {
         $this->storeManager = $storeManager;
         $this->scopeConfig = $scopeConfig;
         $this->resourceConfig = $resourceConfig;
-        $this->moduleList = $moduleList;
         $this->cacheTypeList = $cacheTypeList;
+        $this->cache = $cache;
+        $this->composerInformation = $composerInformation;
     }
 
     /**
@@ -154,13 +172,24 @@ public function getAppId()
     }
 
     /**
-     * Get module version
+     * Get extension version
      *
-     * @return mixed
+     * @return string
      */
-    public function getModuleVersion()
+    public function getModuleVersion(): string
     {
-        return $this->moduleList->getOne(self::MODULE_NAME)['setup_version'];
+        $this->version = $this->version ?: $this->cache->load(self::VERSION_CACHE_KEY);
+        if (!$this->version) {
+            $installedPackages = $this->composerInformation->getInstalledMagentoPackages();
+            $extensionVersion = $installedPackages[self::EXTENSION_PACKAGE_NAME]['version'] ?? null;
+            if (!empty($extensionVersion)) {
+                $this->version = $extensionVersion;
+            } else {
+                $this->version = 'dev';
+            }
+            $this->cache->save($this->version, self::VERSION_CACHE_KEY, [AppConfig::CACHE_TAG]);
+        }
+        return $this->version;
     }
 
     /**