Order Tab Enhancements (#561)

* Order Tab Enhancements

* Hide tab for non-Meta orders
* Remove unneeded logic
* Updated branding, content

* Further edits

* code review feedback

Author: strygo

app/code/Meta/BusinessExtension/etc/adminhtml/system.xml

@@ -85,7 +85,7 @@
                    showInWebsite="0" showInStore="1">
                 <fieldset_css>meta-section-config</fieldset_css>
                 <label>Business Settings</label>
-                <comment>Set your preferred business settings for Meta Commerce.
+                <comment>Set your preferred business settings for Facebook &amp; Instagram.
                 </comment>
                 <depends>
                     <field id="facebook_business_extension/business_extension/active">1</field>

app/code/Meta/Sales/Block/Adminhtml/Order/View/Tab/Facebook.php

@@ -76,7 +76,7 @@ public function getOrder()
      */
     public function canShowTab()
     {
-        return $this->systemConfig->isOnsiteCheckoutEnabled();
+        return $this->getFacebookOrderId() !== null;
     }
 
     /**
@@ -92,15 +92,15 @@ public function isHidden()
      */
     public function getTabLabel()
     {
-        return __('Meta');
+        return __('Facebook & Instagram');
     }
 
     /**
      * @inheritdoc
      */
     public function getTabTitle()
     {
-        return __('Meta');
+        return __('Facebook & Instagram');
     }
 
     /**
@@ -113,16 +113,6 @@ public function getFacebookOrderId()
         return $this->getOrder()->getExtensionAttributes()->getFacebookOrderId();
     }
 
-    /**
-     * Check if order is Facebook order
-     *
-     * @return bool
-     */
-    public function isFacebookOrder()
-    {
-        return $this->getFacebookOrderId() !== null;
-    }
-
     /**
      * Get order's facebook url
      *

app/code/Meta/Sales/view/adminhtml/templates/order/view/tab/facebook.phtml

@@ -9,26 +9,17 @@ $optInFlag = $block->isEmailRemarketingAllowedForOrder() ? 'Yes' : 'No';
 
 <section class="admin__page-section order-facebook">
     <div class="admin__page-section-title">
-        <span class="title"><?= $block->escapeHtml(__('Meta')) ?></span>
+        <span class="title"><?= $block->escapeHtml(__('Facebook & Instagram Details')) ?></span>
     </div>
     <div class="admin__page-section-content">
-        <?php if ($block->isFacebookOrder()): ?>
-            <div class="admin__page-section-item order-facebook-details">
-                <div class="admin__page-section-item-title">
-                    <span class="title"><?= $block->escapeHtml(__('Details')) ?></span>
-                </div>
-                <address class="admin__page-section-item-content">
-                    <p><b>Magento order #</b>: <?= $block->getOrder()->getIncrementId() ?></p>
-                    <p><b>Meta order #</b>: <?= $block->getOrder()->getExtensionAttributes()->getFacebookOrderId() ?></p>
-                    <p><b>Channel</b>: <?= $block->getOrder()->getExtensionAttributes()->getChannel() ?></p>
-                    <p><b>Customer marketing opt-in</b>: <?= $optInFlag ?></p>
-                    <p><b><a href="<?= $block->escapeUrl($block->getOrderFacebookUrl()) ?>" target="_blank">Manage in Commerce Manager</a></b></p>
-                </address>
-            </div>
-        <?php else: ?>
-            <div class="admin__page-section-item order-not-a-facebook-order">
-                <?= __('Not a Meta order') ?>
-            </div>
-        <?php endif; ?>
+        <div class="admin__page-section-item order-facebook-details">
+            <address class="admin__page-section-item-content">
+                <p><b>Magento Order ID</b>: <?= $block->getOrder()->getIncrementId() ?></p>
+                <p><b>Meta Order ID</b>: <?= $block->getOrder()->getExtensionAttributes()->getFacebookOrderId() ?></p>
+                <p><b>Channel</b>: <?= $block->getOrder()->getExtensionAttributes()->getChannel() ?></p>
+                <p><b>Email Marketing Allowed</b>: <?= $optInFlag ?></p>
+                <p><b><a href="<?= $block->escapeUrl($block->getOrderFacebookUrl()) ?>" target="_blank">View in Commerce Manager</a></b></p>
+            </address>
+        </div>
     </div>
 </section>