Skip to content

Commit 00d6d7d

Browse files
authored
Merge pull request #211 from magento/lenaorobei-patch-2
Fixes for failed builds
2 parents 496055e + 5e89d8d commit 00d6d7d

File tree

3 files changed

+22
-25
lines changed

3 files changed

+22
-25
lines changed

ReCaptchaFrontendUi/view/frontend/web/js/reCaptcha.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ define(
3434
* @private
3535
*/
3636
_loadApi: function () {
37-
var element, scriptTag;
38-
3937
if (this._isApiRegistered !== undefined) {
4038
if (this._isApiRegistered === true) {
4139
$(window).trigger('recaptchaapiready');
@@ -81,7 +79,8 @@ define(
8179
$parentForm,
8280
$wrapper,
8381
$reCaptcha,
84-
widgetId;
82+
widgetId,
83+
parameters;
8584

8685
if (this.captchaInitialized) {
8786
return;
@@ -105,7 +104,7 @@ define(
105104
$parentForm = $wrapper.parents('form');
106105
me = this;
107106

108-
let parameters = _.extend(
107+
parameters = _.extend(
109108
{
110109
'callback': function (token) { // jscs:ignore jsDoc
111110
me.reCaptchaCallback(token);

ReCaptchaFrontendUi/view/frontend/web/js/reCaptchaScriptLoader.js

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -4,30 +4,28 @@
44
*/
55

66
define([], function () {
7-
'use strict';
7+
'use strict';
88

9-
var scriptTagAdded = false;
9+
var scriptTagAdded = false;
1010

11-
return {
12-
/**
13-
* Add script tag. Script tag should be added once
14-
*/
15-
addReCaptchaScriptTag: function () {
16-
var element,
17-
scriptTag;
11+
return {
12+
/**
13+
* Add script tag. Script tag should be added once
14+
*/
15+
addReCaptchaScriptTag: function () {
16+
var element, scriptTag;
1817

19-
if (!scriptTagAdded) {
20-
element = document.createElement('script');
21-
scriptTag = document.getElementsByTagName('script')[0];
18+
if (!scriptTagAdded) {
19+
element = document.createElement('script');
20+
scriptTag = document.getElementsByTagName('script')[0];
2221

23-
element.async = true;
24-
element.src = 'https://www.google.com/recaptcha/api.js' +
25-
'?onload=globalOnRecaptchaOnLoadCallback&render=explicit';
22+
element.async = true;
23+
element.src = 'https://www.google.com/recaptcha/api.js' +
24+
'?onload=globalOnRecaptchaOnLoadCallback&render=explicit';
2625

27-
scriptTag.parentNode.insertBefore(element, scriptTag);
28-
scriptTagAdded = true;
29-
}
26+
scriptTag.parentNode.insertBefore(element, scriptTag);
27+
scriptTagAdded = true;
3028
}
3129
}
32-
}
33-
);
30+
};
31+
});

Securitytxt/Test/Mftf/Test/SecurityTxtWithCorrectConfiguration.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<magentoCLI command="config:set {{DisableSecurityTxt.path}} {{DisableSecurityTxt.value}}" stepKey="disableSecurityTxt"/>
2222
</after>
2323

24-
<actionGroup ref="LoginAsAdmin" stepKey="LoginAsAdmin"/>
24+
<actionGroup ref="AdminLoginActionGroup" stepKey="LoginAsAdmin"/>
2525
<actionGroup ref="FillSecurityTxtConfigurationActionGroup" stepKey="fillSecurityTxtConfiguration"/>
2626
<actionGroup ref="AssertFullSecurityTxtConfiguration" stepKey="assertSecurityTxtContent"/>
2727
<actionGroup ref="OpenSecurityTxtSignaturePage" stepKey="openSecurityTxtSignature"/>

0 commit comments

Comments
 (0)