AC-12092:: Remove Deprecations- PhpUnit10 Unit Tests

Shradddha · Shradddha · commit 255466403ae9 · 2024-08-02T18:28:44.000+05:30
diff --git a/ReCaptchaPaypal/Test/Unit/Plugin/ReplayPayflowReCaptchaForPlaceOrderTest.php b/ReCaptchaPaypal/Test/Unit/Plugin/ReplayPayflowReCaptchaForPlaceOrderTest.php
@@ -96,13 +96,13 @@ public function testAfterGetConfigFor(array $mocks, bool $isResultNull, bool $is
     /**
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
      */
-    public function afterGetConfigForDataProvider(): array
+    public static function afterGetConfigForDataProvider(): array
     {
         return [
             [
                 [
                     'reCaptchaSession' => [
-                        ['method' => 'isValid', 'expects' => $this->never()]
+                        ['method' => 'isValid', 'expects' => self::never()]
                     ]
                 ],
                 true,
@@ -114,7 +114,7 @@ public function afterGetConfigForDataProvider(): array
                         ['method' => 'isCaptchaEnabledFor', 'with' => 'paypal_payflowpro', 'willReturn' => false]
                     ],
                     'reCaptchaSession' => [
-                        ['method' => 'isValid', 'expects' => $this->never(),]
+                        ['method' => 'isValid', 'expects' => self::never(),]
                     ]
                 ],
                 false,
@@ -126,10 +126,10 @@ public function afterGetConfigForDataProvider(): array
                         ['method' => 'isCaptchaEnabledFor', 'with' => 'paypal_payflowpro', 'willReturn' => true]
                     ],
                     'request' => [
-                        ['method' => 'getBodyParams', 'expects' => $this->once(), 'willReturn' => []]
+                        ['method' => 'getBodyParams', 'expects' => self::once(), 'willReturn' => []]
                     ],
                     'reCaptchaSession' => [
-                        ['method' => 'isValid', 'expects' => $this->never(),]
+                        ['method' => 'isValid', 'expects' => self::never(),]
                     ]
                 ],
                 false,
@@ -143,12 +143,12 @@ public function afterGetConfigForDataProvider(): array
                     'request' => [
                         [
                             'method' => 'getBodyParams',
-                            'expects' => $this->once(),
+                            'expects' => self::once(),
                             'willReturn' => ['cartId' => 1, 'paymentMethod' => ['method' => 'checkmo']]
                         ]
                     ],
                     'reCaptchaSession' => [
-                        ['method' => 'isValid', 'expects' => $this->never(), 'willReturn' => false]
+                        ['method' => 'isValid', 'expects' => self::never(), 'willReturn' => false]
                     ]
                 ],
                 false,
@@ -162,12 +162,12 @@ public function afterGetConfigForDataProvider(): array
                     'request' => [
                         [
                             'method' => 'getBodyParams',
-                            'expects' => $this->once(),
+                            'expects' => self::once(),
                             'willReturn' => ['cartId' => 1, 'paymentMethod' => ['method' => Config::METHOD_PAYFLOWPRO]]
                         ]
                     ],
                     'reCaptchaSession' => [
-                        ['method' => 'isValid', 'expects' => $this->once(), 'with' => 1, 'willReturn' => false]
+                        ['method' => 'isValid', 'expects' => self::once(), 'with' => 1, 'willReturn' => false]
                     ]
                 ],
                 false,
@@ -181,12 +181,12 @@ public function afterGetConfigForDataProvider(): array
                     'request' => [
                         [
                             'method' => 'getBodyParams',
-                            'expects' => $this->once(),
+                            'expects' => self::once(),
                             'willReturn' => ['cartId' => 1, 'paymentMethod' => ['method' => Config::METHOD_PAYFLOWPRO]]
                         ]
                     ],
                     'reCaptchaSession' => [
-                        ['method' => 'isValid', 'expects' => $this->once(), 'with' => 1, 'willReturn' => true]
+                        ['method' => 'isValid', 'expects' => self::once(), 'with' => 1, 'willReturn' => true]
                     ]
                 ],
                 false,
@@ -200,15 +200,15 @@ public function afterGetConfigForDataProvider(): array
                     'request' => [
                         [
                             'method' => 'getBodyParams',
-                            'expects' => $this->once(),
+                            'expects' => self::once(),
                             'willReturn' => [
                                 'cart_id' => 1,
                                 'payment_method' => ['method' => Config::METHOD_PAYFLOWPRO]
                             ]
                         ]
                     ],
                     'reCaptchaSession' => [
-                        ['method' => 'isValid', 'expects' => $this->once(), 'with' => 1, 'willReturn' => true]
+                        ['method' => 'isValid', 'expects' => self::once(), 'with' => 1, 'willReturn' => true]
                     ]
                 ],
                 false,
@@ -222,7 +222,7 @@ public function afterGetConfigForDataProvider(): array
                     'request' => [
                         [
                             'method' => 'getBodyParams',
-                            'expects' => $this->once(),
+                            'expects' => self::once(),
                             'willReturn' => [
                                 'cartId' => '17uc43rge98nc92',
                                 'paymentMethod' => ['method' => Config::METHOD_PAYFLOWPRO]
@@ -232,24 +232,24 @@ public function afterGetConfigForDataProvider(): array
                     'quoteIdMaskFactory' => [
                         [
                             'method' => 'create',
-                            'expects' => $this->once(),
+                            'expects' => self::once(),
                             'willReturnProperty' => 'quoteIdMask'
                         ]
                     ],
                     'quoteIdMask' => [
                         [
                             'method' => 'load',
-                            'expects' => $this->once(),
+                            'expects' => self::once(),
                             'willReturnSelf' => null
                         ],
                         [
                             'method' => 'getQuoteId',
-                            'expects' => $this->once(),
+                            'expects' => self::once(),
                             'willReturn' => 2
                         ]
                     ],
                     'reCaptchaSession' => [
-                        ['method' => 'isValid', 'expects' => $this->once(), 'with' => 2, 'willReturn' => true]
+                        ['method' => 'isValid', 'expects' => self::once(), 'with' => 2, 'willReturn' => true]
                     ]
                 ],
                 false,
diff --git a/ReCaptchaWebapiGraphQl/Test/Unit/Plugin/GraphQlValidatorTest.php b/ReCaptchaWebapiGraphQl/Test/Unit/Plugin/GraphQlValidatorTest.php
@@ -60,7 +60,7 @@ protected function setUp(): void
         );
     }
 
-    public function getPluginCases(): array
+    public static function getPluginCases(): array
     {
         return [
             'not-mutation' => [false, true, false, false],
diff --git a/ReCaptchaWebapiGraphQl/Test/Unit/Plugin/ValidationOverriderTest.php b/ReCaptchaWebapiGraphQl/Test/Unit/Plugin/ValidationOverriderTest.php
@@ -35,7 +35,7 @@ protected function setUp(): void
         $this->model = new ValidationOverrider($this->userContextMock);
     }
 
-    public function getUserContextData(): array
+    public static function getUserContextData(): array
     {
         return [
             'customer' => [UserContextInterface::USER_TYPE_CUSTOMER, 1, true],
diff --git a/ReCaptchaWebapiRest/Test/Unit/Plugin/RestValidationPluginTest.php b/ReCaptchaWebapiRest/Test/Unit/Plugin/RestValidationPluginTest.php
@@ -71,7 +71,7 @@ protected function setUp(): void
         );
     }
 
-    public function getPluginCases(): array
+    public static function getPluginCases(): array
     {
         return [
             'unprotected-endpoint' => [false, false, false],
diff --git a/ReCaptchaWebapiRest/Test/Unit/Plugin/SoapValidationPluginTest.php b/ReCaptchaWebapiRest/Test/Unit/Plugin/SoapValidationPluginTest.php
@@ -64,7 +64,7 @@ protected function setUp(): void
         );
     }
 
-    public function getPluginCases(): array
+    public static function getPluginCases(): array
     {
         return [
             'not-protected' => [false, UserContextInterface::USER_TYPE_GUEST, null, false],
diff --git a/ReCaptchaWebapiRest/Test/Unit/Plugin/ValidationOverriderTest.php b/ReCaptchaWebapiRest/Test/Unit/Plugin/ValidationOverriderTest.php
@@ -35,7 +35,7 @@ protected function setUp(): void
         $this->model = new ValidationOverrider($this->userContextMock);
     }
 
-    public function getUserContextData(): array
+    public static function getUserContextData(): array
     {
         return [
             'customer' => [UserContextInterface::USER_TYPE_CUSTOMER, 1, true],

Original file line number	Diff line number	Diff line change
`@@ -96,13 +96,13 @@ public function testAfterGetConfigFor(array $mocks, bool $isResultNull, bool $is`
`96`	`96`	`/**`
`97`	`97`	`* @SuppressWarnings(PHPMD.ExcessiveMethodLength)`
`98`	`98`	`*/`
`99`		`- public function afterGetConfigForDataProvider(): array`
	`99`	`+ public static function afterGetConfigForDataProvider(): array`
`100`	`100`	`{`
`101`	`101`	`return [`
`102`	`102`	`[`
`103`	`103`	`[`
`104`	`104`	`'reCaptchaSession' => [`
`105`		`- ['method' => 'isValid', 'expects' => $this->never()]`
	`105`	`+ ['method' => 'isValid', 'expects' => self::never()]`
`106`	`106`	`]`
`107`	`107`	`],`
`108`	`108`	`true,`
`@@ -114,7 +114,7 @@ public function afterGetConfigForDataProvider(): array`
`114`	`114`	`['method' => 'isCaptchaEnabledFor', 'with' => 'paypal_payflowpro', 'willReturn' => false]`
`115`	`115`	`],`
`116`	`116`	`'reCaptchaSession' => [`
`117`		`- ['method' => 'isValid', 'expects' => $this->never(),]`
	`117`	`+ ['method' => 'isValid', 'expects' => self::never(),]`
`118`	`118`	`]`
`119`	`119`	`],`
`120`	`120`	`false,`
`@@ -126,10 +126,10 @@ public function afterGetConfigForDataProvider(): array`
`126`	`126`	`['method' => 'isCaptchaEnabledFor', 'with' => 'paypal_payflowpro', 'willReturn' => true]`
`127`	`127`	`],`
`128`	`128`	`'request' => [`
`129`		`- ['method' => 'getBodyParams', 'expects' => $this->once(), 'willReturn' => []]`
	`129`	`+ ['method' => 'getBodyParams', 'expects' => self::once(), 'willReturn' => []]`
`130`	`130`	`],`
`131`	`131`	`'reCaptchaSession' => [`
`132`		`- ['method' => 'isValid', 'expects' => $this->never(),]`
	`132`	`+ ['method' => 'isValid', 'expects' => self::never(),]`
`133`	`133`	`]`
`134`	`134`	`],`
`135`	`135`	`false,`
`@@ -143,12 +143,12 @@ public function afterGetConfigForDataProvider(): array`
`143`	`143`	`'request' => [`
`144`	`144`	`[`
`145`	`145`	`'method' => 'getBodyParams',`
`146`		`- 'expects' => $this->once(),`
	`146`	`+ 'expects' => self::once(),`
`147`	`147`	`'willReturn' => ['cartId' => 1, 'paymentMethod' => ['method' => 'checkmo']]`
`148`	`148`	`]`
`149`	`149`	`],`
`150`	`150`	`'reCaptchaSession' => [`
`151`		`- ['method' => 'isValid', 'expects' => $this->never(), 'willReturn' => false]`
	`151`	`+ ['method' => 'isValid', 'expects' => self::never(), 'willReturn' => false]`
`152`	`152`	`]`
`153`	`153`	`],`
`154`	`154`	`false,`
`@@ -162,12 +162,12 @@ public function afterGetConfigForDataProvider(): array`
`162`	`162`	`'request' => [`
`163`	`163`	`[`
`164`	`164`	`'method' => 'getBodyParams',`
`165`		`- 'expects' => $this->once(),`
	`165`	`+ 'expects' => self::once(),`
`166`	`166`	`'willReturn' => ['cartId' => 1, 'paymentMethod' => ['method' => Config::METHOD_PAYFLOWPRO]]`
`167`	`167`	`]`
`168`	`168`	`],`
`169`	`169`	`'reCaptchaSession' => [`
`170`		`- ['method' => 'isValid', 'expects' => $this->once(), 'with' => 1, 'willReturn' => false]`
	`170`	`+ ['method' => 'isValid', 'expects' => self::once(), 'with' => 1, 'willReturn' => false]`
`171`	`171`	`]`
`172`	`172`	`],`
`173`	`173`	`false,`
`@@ -181,12 +181,12 @@ public function afterGetConfigForDataProvider(): array`
`181`	`181`	`'request' => [`
`182`	`182`	`[`
`183`	`183`	`'method' => 'getBodyParams',`
`184`		`- 'expects' => $this->once(),`
	`184`	`+ 'expects' => self::once(),`
`185`	`185`	`'willReturn' => ['cartId' => 1, 'paymentMethod' => ['method' => Config::METHOD_PAYFLOWPRO]]`
`186`	`186`	`]`
`187`	`187`	`],`
`188`	`188`	`'reCaptchaSession' => [`
`189`		`- ['method' => 'isValid', 'expects' => $this->once(), 'with' => 1, 'willReturn' => true]`
	`189`	`+ ['method' => 'isValid', 'expects' => self::once(), 'with' => 1, 'willReturn' => true]`
`190`	`190`	`]`
`191`	`191`	`],`
`192`	`192`	`false,`
`@@ -200,15 +200,15 @@ public function afterGetConfigForDataProvider(): array`
`200`	`200`	`'request' => [`
`201`	`201`	`[`
`202`	`202`	`'method' => 'getBodyParams',`
`203`		`- 'expects' => $this->once(),`
	`203`	`+ 'expects' => self::once(),`
`204`	`204`	`'willReturn' => [`
`205`	`205`	`'cart_id' => 1,`
`206`	`206`	`'payment_method' => ['method' => Config::METHOD_PAYFLOWPRO]`
`207`	`207`	`]`
`208`	`208`	`]`
`209`	`209`	`],`
`210`	`210`	`'reCaptchaSession' => [`
`211`		`- ['method' => 'isValid', 'expects' => $this->once(), 'with' => 1, 'willReturn' => true]`
	`211`	`+ ['method' => 'isValid', 'expects' => self::once(), 'with' => 1, 'willReturn' => true]`
`212`	`212`	`]`
`213`	`213`	`],`
`214`	`214`	`false,`
`@@ -222,7 +222,7 @@ public function afterGetConfigForDataProvider(): array`
`222`	`222`	`'request' => [`
`223`	`223`	`[`
`224`	`224`	`'method' => 'getBodyParams',`
`225`		`- 'expects' => $this->once(),`
	`225`	`+ 'expects' => self::once(),`
`226`	`226`	`'willReturn' => [`
`227`	`227`	`'cartId' => '17uc43rge98nc92',`
`228`	`228`	`'paymentMethod' => ['method' => Config::METHOD_PAYFLOWPRO]`
`@@ -232,24 +232,24 @@ public function afterGetConfigForDataProvider(): array`
`232`	`232`	`'quoteIdMaskFactory' => [`
`233`	`233`	`[`
`234`	`234`	`'method' => 'create',`
`235`		`- 'expects' => $this->once(),`
	`235`	`+ 'expects' => self::once(),`
`236`	`236`	`'willReturnProperty' => 'quoteIdMask'`
`237`	`237`	`]`
`238`	`238`	`],`
`239`	`239`	`'quoteIdMask' => [`
`240`	`240`	`[`
`241`	`241`	`'method' => 'load',`
`242`		`- 'expects' => $this->once(),`
	`242`	`+ 'expects' => self::once(),`
`243`	`243`	`'willReturnSelf' => null`
`244`	`244`	`],`
`245`	`245`	`[`
`246`	`246`	`'method' => 'getQuoteId',`
`247`		`- 'expects' => $this->once(),`
	`247`	`+ 'expects' => self::once(),`
`248`	`248`	`'willReturn' => 2`
`249`	`249`	`]`
`250`	`250`	`],`
`251`	`251`	`'reCaptchaSession' => [`
`252`		`- ['method' => 'isValid', 'expects' => $this->once(), 'with' => 2, 'willReturn' => true]`
	`252`	`+ ['method' => 'isValid', 'expects' => self::once(), 'with' => 2, 'willReturn' => true]`
`253`	`253`	`]`
`254`	`254`	`],`
`255`	`255`	`false,`
Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ protected function setUp(): void`
`60`	`60`	`);`
`61`	`61`	`}`
`62`	`62`
`63`		`- public function getPluginCases(): array`
	`63`	`+ public static function getPluginCases(): array`
`64`	`64`	`{`
`65`	`65`	`return [`
`66`	`66`	`'not-mutation' => [false, true, false, false],`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ protected function setUp(): void`
`35`	`35`	`$this->model = new ValidationOverrider($this->userContextMock);`
`36`	`36`	`}`
`37`	`37`
`38`		`- public function getUserContextData(): array`
	`38`	`+ public static function getUserContextData(): array`
`39`	`39`	`{`
`40`	`40`	`return [`
`41`	`41`	`'customer' => [UserContextInterface::USER_TYPE_CUSTOMER, 1, true],`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ protected function setUp(): void`
`71`	`71`	`);`
`72`	`72`	`}`
`73`	`73`
`74`		`- public function getPluginCases(): array`
	`74`	`+ public static function getPluginCases(): array`
`75`	`75`	`{`
`76`	`76`	`return [`
`77`	`77`	`'unprotected-endpoint' => [false, false, false],`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ protected function setUp(): void`
`64`	`64`	`);`
`65`	`65`	`}`
`66`	`66`
`67`		`- public function getPluginCases(): array`
	`67`	`+ public static function getPluginCases(): array`
`68`	`68`	`{`
`69`	`69`	`return [`
`70`	`70`	`'not-protected' => [false, UserContextInterface::USER_TYPE_GUEST, null, false],`