Merge pull request #81 from magento-atwix-pyrrans/AC-2751-upgrade-symfony-to-latest-lts

[Pyrrans] Upgrade Symfony to the latest LTS version

Author: andrewbess

ReCaptchaUser/Command/DisableReCaptchaForUserForgotPasswordCommand.php

@@ -7,6 +7,7 @@
 
 namespace Magento\ReCaptchaUser\Command;
 
+use Magento\Framework\Console\Cli;
 use Magento\ReCaptchaUser\Model\DisableReCaptchaForUserForgotPassword;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
@@ -47,5 +48,7 @@ protected function configure()
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $this->disableReCaptchaForUserForgotPassword->execute();
+
+        return Cli::RETURN_SUCCESS;
     }
 }

ReCaptchaUser/Command/DisableReCaptchaForUserLoginCommand.php

@@ -7,6 +7,7 @@
 
 namespace Magento\ReCaptchaUser\Command;
 
+use Magento\Framework\Console\Cli;
 use Magento\ReCaptchaUser\Model\DisableReCaptchaForUserLogin;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
@@ -47,5 +48,7 @@ protected function configure()
     protected function execute(InputInterface $input, OutputInterface $output)
     {
         $this->disableReCaptchaForUserLogin->execute();
+
+        return Cli::RETURN_SUCCESS;
     }
 }

TwoFactorAuth/Command/GoogleSecret.php

@@ -7,6 +7,7 @@
 
 namespace Magento\TwoFactorAuth\Command;
 
+use Magento\Framework\Console\Cli;
 use Magento\Framework\Exception\LocalizedException;
 use Magento\TwoFactorAuth\Api\UserConfigManagerInterface;
 use Magento\TwoFactorAuth\Model\Provider\Engine\Google;
@@ -68,8 +69,8 @@ protected function configure()
         $this->setName('security:tfa:google:set-secret');
         $this->setDescription('Set the secret used for Google OTP generation.');
 
-        $this->addArgument('user', InputArgument::REQUIRED, __('Username'));
-        $this->addArgument('secret', InputArgument::REQUIRED, __('Secret'));
+        $this->addArgument('user', InputArgument::REQUIRED, __('Username')->render());
+        $this->addArgument('secret', InputArgument::REQUIRED, __('Secret')->render());
 
         parent::configure();
     }
@@ -104,5 +105,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
         );
 
         $output->writeln((string)__('Google OTP secret has been set'));
+
+        return Cli::RETURN_SUCCESS;
     }
 }

TwoFactorAuth/Command/TfaReset.php

@@ -69,8 +69,8 @@ protected function configure()
         $this->setName('security:tfa:reset');
         $this->setDescription('Reset configuration for one user');
 
-        $this->addArgument('user', InputArgument::REQUIRED, __('Username'));
-        $this->addArgument('provider', InputArgument::REQUIRED, __('Provider code'));
+        $this->addArgument('user', InputArgument::REQUIRED, __('Username')->render());
+        $this->addArgument('provider', InputArgument::REQUIRED, __('Provider code')->render());
 
         parent::configure();
     }