#AC-11762::Update 2FA OTP window field with correct description and default value after BiC change-fixes for static tests failures

Author: glo05363

TwoFactorAuth/Model/Config/Backend/OtpWindow.php

@@ -15,6 +15,8 @@
 class OtpWindow extends Value implements ProcessorInterface
 {
     /**
+     * Fetch Totp default period value
+     *
      * @return int
      */
     private function getDefaultPeriod(): int
@@ -48,7 +50,13 @@ public function beforeSave()
         $value = $this->getValue();
         $period = $this->getDefaultPeriod();
         if (!is_numeric($value) || $value < 1 || $value >= $period) {
-            throw new ValidatorException(__('Invalid OTP window value. It must be less than the OTP period value '.$period));
+            throw new ValidatorException(
+                __(
+                    'Invalid OTP window value. It must be between 1 and %1 as default period is %2',
+                    $period-1,
+                    $period
+                )
+            );
         }
 
         return parent::beforeSave();

TwoFactorAuth/Setup/Patch/Data/UpdateOtpWindow.php

@@ -18,11 +18,19 @@ class UpdateOtpWindow implements DataPatchInterface
      */
     private $moduleDataSetup;
 
+    /**
+     * @param ModuleDataSetupInterface $moduleDataSetup
+     */
     public function __construct(ModuleDataSetupInterface $moduleDataSetup)
     {
         $this->moduleDataSetup = $moduleDataSetup;
     }
 
+    /**
+     * Fetch Totp default period
+     *
+     * @return int
+     */
     public function getDefaultPeriod()
     {
         return TOTPInterface::DEFAULT_PERIOD;
@@ -43,17 +51,15 @@ public function apply()
         $period = $this->getDefaultPeriod();
         if ($existingValue && $existingValue >= $period) {
             $newWindowValue = $period - 1;
-        }
-
-        if ($existingValue) {
             $setup->update(
                 'core_config_data',
                 ['value' => $newWindowValue],
                 'path = "twofactorauth/google/otp_window"'
             );
         }
-
         $setup->endSetup();
+
+        return $this;
     }
 
     /**
@@ -71,5 +77,4 @@ public function getAliases()
     {
         return [];
     }
-
 }