Skip to content

Commit d355209

Browse files
authored
Merge pull request #240 from davidalger/patch-1
Update default OTP Window for Google TOTP to 1 per recommendation in RFC 6238
2 parents 63756a1 + efef37f commit d355209

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

TwoFactorAuth/etc/adminhtml/system.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
<field id="otp_window" translate="label comment" type="text" sortOrder="10" showInDefault="1"
4343
showInWebsite="0" showInStore="0" canRestore="1">
4444
<label>OTP Window</label>
45-
<comment>This determines how long the one-time-passwords are valid for.</comment>
45+
<comment>This determines how long the one-time-passwords are valid for. An OTP Window of 1 will result in the current OTP value plus 1 code in the past and 1 code in the future to be valid at any given point in time.</comment>
4646
</field>
4747
</group>
4848
<group id="duo" translate="label" type="text" sortOrder="40" showInDefault="1" showInWebsite="0"

TwoFactorAuth/etc/config.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<application_key backend_model="Magento\Config\Model\Config\Backend\Encrypted"/>
2222
</duo>
2323
<google>
24-
<otp_window>30</otp_window>
24+
<otp_window>1</otp_window>
2525
</google>
2626
</twofactorauth>
2727
</default>

0 commit comments

Comments
 (0)