Merge pull request #118 from magfest/chore/tests-clean-up

Chore/tests clean up

Author: CarensirA-MF

tests/integration/test_admin_features.py

@@ -68,41 +68,6 @@ def _seed_admin(app):
 class TestQuickBooksClassFields:
     """Tests for qb_class field persistence on org models."""
 
-    def test_event_cycle_qb_class_persists(self, app, db_session):
-        """qb_class should be saved and loaded on EventCycle."""
-        _seed_admin(app)
-
-        cycle = EventCycle.query.filter_by(code="TST2026").one()
-        assert cycle.qb_class is None
-
-        cycle.qb_class = "Super_MAGFest"
-        db_session.commit()
-
-        reloaded = EventCycle.query.filter_by(code="TST2026").one()
-        assert reloaded.qb_class == "Super_MAGFest"
-
-    def test_division_qb_class_persists(self, app, db_session):
-        """qb_class should be saved and loaded on Division."""
-        _seed_admin(app)
-
-        div = Division.query.filter_by(code="TESTDIV").one()
-        div.qb_class = "Gaming"
-        db_session.commit()
-
-        reloaded = Division.query.filter_by(code="TESTDIV").one()
-        assert reloaded.qb_class == "Gaming"
-
-    def test_department_qb_class_persists(self, app, db_session):
-        """qb_class should be saved and loaded on Department."""
-        _seed_admin(app)
-
-        dept = Department.query.filter_by(code="TESTDEPT").one()
-        dept.qb_class = "Staff Services"
-        db_session.commit()
-
-        reloaded = Department.query.filter_by(code="TESTDEPT").one()
-        assert reloaded.qb_class == "Staff Services"
-
     def test_multiple_entities_share_qb_class(self, app, db_session):
         """Multiple entities should be able to share the same qb_class value."""
         _seed_admin(app)
@@ -131,17 +96,6 @@ def test_defaults_to_false(self, app, db_session):
         cycle = EventCycle.query.filter_by(code="TST2026").one()
         assert cycle.dates_are_public is False
 
-    def test_toggle_persists(self, app, db_session):
-        """dates_are_public should be toggleable and persist."""
-        _seed_admin(app)
-
-        cycle = EventCycle.query.filter_by(code="TST2026").one()
-        cycle.dates_are_public = True
-        db_session.commit()
-
-        reloaded = EventCycle.query.filter_by(code="TST2026").one()
-        assert reloaded.dates_are_public is True
-
     def test_dates_still_stored_when_not_public(self, app, db_session):
         """Event dates should be stored regardless of visibility setting."""
         _seed_admin(app)

tests/integration/test_admin_line_tools.py

@@ -530,31 +530,11 @@ def test_detail_page_shows_add_line_for_admin(self, app, client, seed_draft_work
         assert resp.status_code == 200
         assert b"add-line" in resp.data
 
-    def test_approvals_line_review_shows_edit_link_for_admin(self, app, client, seed_draft_work_item):
-        # Admins do their reviewing from the approvals-side line page
-        # (budget/line_review.html), so the edit link must appear there too.
-        data = seed_draft_work_item
-        _make_submitted(data)
-        _login(client, "test:admin")
-
-        resp = client.get(_url(app, "approvals.line_review", data, line_num=1))
-        assert resp.status_code == 200
-        assert b"change-account" in resp.data
-
-
 class TestPriceSnapshotColumn:
     def test_column_defaults_to_none(self, app, seed_draft_work_item):
         data = seed_draft_work_item
         assert data["detail"].account_default_unit_price_cents is None
 
-    def test_column_round_trips(self, app, seed_draft_work_item):
-        data = seed_draft_work_item
-        data["detail"].account_default_unit_price_cents = 15900
-        db.session.commit()
-        db.session.refresh(data["detail"])
-        assert data["detail"].account_default_unit_price_cents == 15900
-
-
 class TestAdminAccountList:
     def test_includes_fixed_hotel_and_badge_excludes_inactive(
         self, app, seed_draft_work_item

tests/integration/test_board_release_scope.py

@@ -8,16 +8,6 @@
 from app.models import WorkType, WorkTypeConfig
 
 
-def test_budget_opts_into_board_release(app, seed_workflow_data):
-    config = (
-        WorkTypeConfig.query
-        .filter_by(url_slug="budget")
-        .first()
-    )
-    assert config is not None
-    assert config.uses_board_release is True
-
-
 def test_non_budget_work_type_defaults_to_no_board_release(app, seed_workflow_data):
     """Guard the column default, not just BUDGET's seeded override.
 

tests/integration/test_route_migration.py

@@ -93,19 +93,6 @@ def test_legacy_budget_portfolio_url_resolves(self, app, client, seed_workflow_d
             f"the route may have been broken during migration."
         )
 
-    def test_new_slug_url_resolves_for_budget(self, app, client, seed_workflow_data):
-        """Same URL via the new <work_type_slug> rule reaches the same handler."""
-        cycle = seed_workflow_data["cycle"]
-        dept = seed_workflow_data["department"]
-        _login(client, "test:admin")
-
-        # The URL string is identical to the legacy one — Flask picks the
-        # literal "budget" rule due to specificity preference. This proves
-        # the legacy URL still maps cleanly even with both rules registered.
-        response = client.get(f"/{cycle.code}/{dept.code}/budget")
-        assert response.status_code == 200
-
-
 class TestNonBudgetSlugBehavior:
     """Non-budget slugs reach the right handlers with the right behavior."""
 

tests/unit/test_email_outbox_models.py

@@ -1,7 +1,7 @@
 """Model-level tests for the email outbox tables."""
 from datetime import datetime
 
-from app.models import EmailMessageBody, EmailOutbox, EmailSuppression, NotificationLog
+from app.models import EmailOutbox, EmailSuppression
 from app.models.constants import OUTBOX_CLAIMABLE_STATUSES, OUTBOX_STATUS_QUEUED
 from app import db
 
@@ -38,28 +38,6 @@ def test_dedup_key_is_unique(app):
             db.session.rollback()
 
 
-def test_message_body_links_to_its_log_row(app):
-    """Do NOT assert ON DELETE CASCADE here.
-
-    SQLite defaults PRAGMA foreign_keys to OFF and this app registers no
-    connect listener to turn it on, so no ondelete clause fires in dev or
-    test. The CASCADE is declared for Postgres; Task 13's prune deletes
-    bodies explicitly so retention does not depend on it.
-    """
-    with app.app_context():
-        log = NotificationLog(
-            template_key="submitted", recipient_email="c@example.org", status="SENT",
-        )
-        db.session.add(log)
-        db.session.commit()
-        db.session.add(EmailMessageBody(
-            notification_log_id=log.id, subject="s", body_text="t", body_html="<p>t</p>",
-        ))
-        db.session.commit()
-        body = db.session.query(EmailMessageBody).one()
-        assert body.notification_log_id == log.id
-
-
 def test_the_status_default_is_a_claimable_status():
     """A new row must land in a status the drainer will pick up.