|
| 1 | +"""Integration tests: per-line action link on a FINALIZED budget request. |
| 2 | +
|
| 3 | +A board-held budget is persisted as FINALIZED; "Pending FY Budget Approval" |
| 4 | +is a derived display string. Both cases must still expose the line detail |
| 5 | +page, which renders read-only because every decision form requires a |
| 6 | +checkout and FINALIZED items cannot be checked out. |
| 7 | +""" |
| 8 | +import re |
| 9 | +from datetime import datetime |
| 10 | + |
| 11 | +from app import db |
| 12 | +from app.models import ( |
| 13 | + WorkItem, WorkLine, BudgetLineDetail, |
| 14 | + REQUEST_KIND_PRIMARY, |
| 15 | + WORK_ITEM_STATUS_FINALIZED, WORK_ITEM_STATUS_SUBMITTED, |
| 16 | + WORK_LINE_STATUS_APPROVED, WORK_LINE_STATUS_PENDING, |
| 17 | + REVIEW_STAGE_ADMIN_FINAL, REVIEW_STAGE_APPROVAL_GROUP, |
| 18 | +) |
| 19 | + |
| 20 | +DETAIL_URL = "/TST2026/TESTDEPT/budget/item/TST2026-TESTDEPT-BUD-1" |
| 21 | + |
| 22 | +# The per-line action cell, captured with its label so the test can tell |
| 23 | +# "Review" (actionable) from "View" (finalized) apart. |
| 24 | +LINE_ACTION = re.compile( |
| 25 | + r'<a class="btn btn-muted" href="[^"]*/line/1/review"[^>]*>\s*(\w+)\s*</a>' |
| 26 | +) |
| 27 | + |
| 28 | + |
| 29 | +def _make_item(data, status, line_status, stage): |
| 30 | + work_item = WorkItem( |
| 31 | + portfolio_id=data["portfolio"].id, |
| 32 | + request_kind=REQUEST_KIND_PRIMARY, |
| 33 | + status=status, |
| 34 | + public_id="TST2026-TESTDEPT-BUD-1", |
| 35 | + created_by_user_id=data["admin"].id, |
| 36 | + ) |
| 37 | + if status == WORK_ITEM_STATUS_FINALIZED: |
| 38 | + work_item.finalized_at = datetime.utcnow() |
| 39 | + work_item.finalized_by_user_id = data["admin"].id |
| 40 | + db.session.add(work_item) |
| 41 | + db.session.flush() |
| 42 | + |
| 43 | + line = WorkLine( |
| 44 | + work_item_id=work_item.id, line_number=1, |
| 45 | + status=line_status, current_review_stage=stage, |
| 46 | + approved_amount_cents=450_000 if line_status == WORK_LINE_STATUS_APPROVED else None, |
| 47 | + ) |
| 48 | + db.session.add(line) |
| 49 | + db.session.flush() |
| 50 | + db.session.add(BudgetLineDetail( |
| 51 | + work_line_id=line.id, |
| 52 | + expense_account_id=data["expense_account"].id, |
| 53 | + spend_type_id=data["spend_type"].id, |
| 54 | + quantity=1, unit_price_cents=450_000, |
| 55 | + routed_approval_group_id=data["approval_group"].id, |
| 56 | + )) |
| 57 | + db.session.commit() |
| 58 | + return work_item |
| 59 | + |
| 60 | + |
| 61 | +def _finalized(data): |
| 62 | + return _make_item(data, WORK_ITEM_STATUS_FINALIZED, |
| 63 | + WORK_LINE_STATUS_APPROVED, REVIEW_STAGE_ADMIN_FINAL) |
| 64 | + |
| 65 | + |
| 66 | +def _submitted(data): |
| 67 | + return _make_item(data, WORK_ITEM_STATUS_SUBMITTED, |
| 68 | + WORK_LINE_STATUS_PENDING, REVIEW_STAGE_APPROVAL_GROUP) |
| 69 | + |
| 70 | + |
| 71 | +def _login(client, user_id): |
| 72 | + with client.session_transaction() as sess: |
| 73 | + sess["active_user_id"] = user_id |
| 74 | + |
| 75 | + |
| 76 | +def test_finalized_item_keeps_a_link_to_the_line(app, client, seed_workflow_data): |
| 77 | + _finalized(seed_workflow_data) |
| 78 | + _login(client, "test:admin") |
| 79 | + |
| 80 | + resp = client.get(DETAIL_URL) |
| 81 | + assert resp.status_code == 200 |
| 82 | + html = resp.get_data(as_text=True) |
| 83 | + |
| 84 | + # The board hold is what the team reported against. |
| 85 | + assert "Pending FY Budget Approval" in html |
| 86 | + assert LINE_ACTION.search(html), "no per-line link on a finalized request" |
| 87 | + |
| 88 | + |
| 89 | +def test_finalized_line_link_is_labelled_view(app, client, seed_workflow_data): |
| 90 | + _finalized(seed_workflow_data) |
| 91 | + _login(client, "test:admin") |
| 92 | + |
| 93 | + html = client.get(DETAIL_URL).get_data(as_text=True) |
| 94 | + assert LINE_ACTION.search(html).group(1) == "View" |
| 95 | + |
| 96 | + |
| 97 | +def test_finalized_item_hides_quick_review(app, client, seed_workflow_data): |
| 98 | + _finalized(seed_workflow_data) |
| 99 | + _login(client, "test:admin") |
| 100 | + |
| 101 | + html = client.get(DETAIL_URL).get_data(as_text=True) |
| 102 | + assert "quick-review" not in html |
| 103 | + |
| 104 | + |
| 105 | +def test_submitted_item_still_shows_review_and_quick_review(app, client, seed_workflow_data): |
| 106 | + _submitted(seed_workflow_data) |
| 107 | + _login(client, "test:admin") |
| 108 | + |
| 109 | + html = client.get(DETAIL_URL).get_data(as_text=True) |
| 110 | + assert LINE_ACTION.search(html).group(1) == "Review" |
| 111 | + assert "quick-review" in html |
0 commit comments