Recovery not attempted due to timewarp

[PaletzTheWise]

Hello,
I have found an issue with timewarp. Chance of recovery goes down as timewarp factor goes up, sometimes x50 is enough to prevent recovery. I have added some logs and it looks like VesselDestroyEvent is firing but v.altitude is reported negative, thus the condition for recovering is not fulfilled.

private void VesselDestroyEvent(Vessel v)
...
if (v != null && !RecoverAttemptLog.ContainsKey(v.id) && !(HighLogic.LoadedSceneIsFlight && v.isActiveVessel) && (v.mainBody == Planetarium.fetch.Home) && (!v.loaded || v.packed) && (v.altitude < v.mainBody.atmosphereDepth) &&
               (v.situation == Vessel.Situations.FLYING || v.situation == Vessel.Situations.SUB_ORBITAL || v.situation == Vessel.Situations.ORBITING) && !v.isEVA && v.altitude > 100)
{
    RecoverVessel(v, false);
}

Is the altitude check required? I'd imagine for other events it would be dangerous to recover vessels near ground since it could be a fully functional rover or submarine. But the vessel is being destroyed here, perhaps even a rover deserves a chance if it flies and crashes :)

[LOG 21:43:22.848] [SR] VesselDestroyEvent() vessel=Fuel Tank Heavy 2 Probe (unloaded)
[LOG 21:43:22.848] [SR] Controlling mod is null
[LOG 21:43:22.848] [SR] VesselDestroyEvent() not recovering isFirstTry=True, isObserved=False, isHome=True, isLoaded=True, isWithinAtmosphere=True, isFlyingOrOrbiting=True, isEva=False, altitude=81.7866229285719
[LOG 21:43:22.849] [Vessel Fuel Tank Heavy 2 Probe]: Vessel was destroyed.
[WRN 21:43:22.849] [F: 67135]: Vessel Fuel Tank Heavy 2 Probe crashed through terrain on Kerbin.

[magico13]

I believe that altitude check was originally added because the VesselDestroyEvent is fired on more cases than just the vessel being actually destroyed. For instance, it is fired on scene changes. But if the altitude is <0 it is probably due to timewarp like you're seeing so that could be an option. There also were additional checks for scene changes added later so it might be that the > 100 check could be removed. I can really easily make a build that has that removed if you want to try it.

[magico13]

Here's a build with that check removed: http://magico13.net:8080/job/StageRecovery%20Beta/38/

[PaletzTheWise]

Thanks,
Though it was not necessary since I have my own fork and I have figured out how to deploy changes in my KSP :)
I'll test it and I'm quite confident it will fix the timewarp issue. The hard part is to verify nothing else broke as a side-effect...