more tests

Author: magicprinc

src/main/java/com/trivago/fastutilconcurrentwrapper/util/JBytes.java

@@ -148,7 +148,8 @@ public static byte[] concatOrSame (byte @Nullable [] a, byte @Nullable [] b) {
 		System.arraycopy(b,0, c,len1,  len2);
 		return c;
 	}
-	/** @see #concatOrSame */
+
+	/** Similar to {@link #concatOrSame}, but if only one array is not empty → returns cloned array */
 	public static byte[] concatClone (byte @Nullable [] a, byte @Nullable [] b) {
 		int len1;
 		if (a == null || (len1 = a.length) <= 0){
@@ -167,6 +168,7 @@ public static byte[] concatClone (byte @Nullable [] a, byte @Nullable [] b) {
 		return c;
 	}
 
+	/** Concat multiple byte arrays */
 	public static byte[] concatMulti (byte @Nullable [] @Nullable ... byteArrays) {
 		if (CFUtil.blankVarargs(byteArrays))
 				return EMPTY_ARRAY;
@@ -207,6 +209,7 @@ public static long bytesToLong (byte[] bytes) {
 	 * All methods in this class will throw an {@linkplain NullPointerException} if {@code null} is
 	 * passed in as a method parameter for a byte array.
 	 * @see java.io.DataOutputStream
+	 * @see java.io.DataInputStream
 	 * @see jdk.internal.util.ByteArray
 	 * @see jdk.internal.util.ByteArrayLittleEndian
 	 */

src/test/java/com/trivago/fastutilconcurrentwrapper/intkey/PrimitiveConcurrentMapTest.java

@@ -48,8 +48,10 @@ void _hashLong () {
 	void longsAreSame () {
 		long total = 0, t = System.nanoTime();
 		for (long i = Integer.MIN_VALUE; i <= Integer.MAX_VALUE; i++){
-			assertEquals(CFUtil.bucket(Long.valueOf(i), 4_000_000), CFUtil.bucket(i, 4_000_000));
-			assertEquals(CFUtil.bucket((int)i, 4_000_000), CFUtil.bucket(i, 4_000_000));
+			int hc = CFUtil.bucket(i, 4_000_000);
+			assertEquals(CFUtil.bucket(Long.valueOf(i), 4_000_000), hc);
+			assertEquals(CFUtil.bucket((int)i, 4_000_000), hc);
+			assertTrue(hc >= 0 && hc < 4_000_000);
 			total++;
 		}
 		t = System.nanoTime() - t;
@@ -65,13 +67,22 @@ void longsAreSame () {
 		var r = ThreadLocalRandom.current();
 		for (int z = 0; z < 4_000_000; z++){
 			long i = r.nextLong();
-			assertEquals(CFUtil.bucket(Long.valueOf(i), 4_000_000), CFUtil.bucket(i, 4_000_000));
+			int hc = CFUtil.bucket(i, 4_000_000);
+			assertEquals(CFUtil.bucket(Long.valueOf(i), 4_000_000), hc);
+			assertTrue(hc >= 0 && hc < 4_000_000);
+
 			i = Long.MIN_VALUE + z;
-			assertEquals(CFUtil.bucket(Long.valueOf(i), 4_000_000), CFUtil.bucket(i, 4_000_000));
-			assertEquals(CFUtil.bucket(Long.hashCode(i), 4_000_000), CFUtil.bucket(i, 4_000_000));
+			hc = CFUtil.bucket(i, 4_000_000);
+			assertEquals(CFUtil.bucket(Long.valueOf(i), 4_000_000), hc);
+			assertEquals(CFUtil.bucket(Long.hashCode(i), 4_000_000), hc);
+			assertTrue(hc >= 0 && hc < 4_000_000);
+
 			i = Long.MAX_VALUE - z;
-			assertEquals(CFUtil.bucket(Long.valueOf(i), 4_000_000), CFUtil.bucket(i, 4_000_000));
-			assertEquals(CFUtil.bucket(Long.hashCode(i), 4_000_000), CFUtil.bucket(i, 4_000_000));
+			hc = CFUtil.bucket(i, Integer.MAX_VALUE);
+			assertEquals(CFUtil.bucket(Long.valueOf(i), Integer.MAX_VALUE), hc);
+			assertEquals(CFUtil.bucket(Long.hashCode(i), Integer.MAX_VALUE), hc);
+			assertTrue(hc >= 0 && hc < Integer.MAX_VALUE);
+
 			total++;
 		}
 		assertEquals(4_000_000, total);