Skip to content

Commit b6a4a53

Browse files
authored
Merge pull request #63 from magillus/develop
DART::IO dependency deprecation on `fimber` package
2 parents 20f5497 + b83bd5f commit b6a4a53

File tree

18 files changed

+1553
-342
lines changed

18 files changed

+1553
-342
lines changed

fimber/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## [0.3.3] - Deprecating dart:io dependency
2+
3+
- Removing FileLogging and moving it to separate package: `fimber_io`
4+
- 0.4.0 version will remove dependency on dart::io - so that Fimber can be used in Web projects.
5+
16
## [0.3.2] - Bug fix for Time rolling tree.
27

38
- [\#52 issue](https://github.com/magillus/flutter-fimber/issues/52) Fix for check of new file format based on timeSpan intervals.

fimber/README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,6 +125,8 @@ Due to nature of auto-tag generation from stacktrace this block only does it onc
125125
});
126126
```
127127

128+
## **Deprecated** moved to `fimber_io` package
129+
128130
### Custom line formatters
129131

130132
Use custom line formatters to define your logging format.

fimber/lib/file_log.dart

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import 'dart:async';
22
import 'dart:core';
3-
import 'dart:io';
3+
import 'dart:io'; // todo deprecate
44

55
import 'package:fimber/colorize.dart';
66
import 'package:fimber/filename_format.dart';
@@ -10,6 +10,7 @@ import 'package:fimber/fimber.dart';
1010
/// This tree if planted will post short formatted (elapsed time and message)
1111
/// output into file specified in constructor.
1212
/// Note: Mostly for testing right now
13+
@Deprecated("Use `fimber_io` package to get benefits of dart:io with Fimber.")
1314
class FimberFileTree extends CustomFormatTree with CloseableTree {
1415
/// Output current log file name.
1516
String outputFileName;
@@ -39,14 +40,14 @@ class FimberFileTree extends CustomFormatTree with CloseableTree {
3940
_maxBufferSize = maxBufferSize;
4041
_bufferWriteInterval =
4142
Stream.periodic(Duration(milliseconds: bufferWriteInterval), (i) {
42-
// group calls
43-
var dumpBuffer = _logBuffer;
44-
_logBuffer = [];
45-
_bufferSize = 0;
46-
return dumpBuffer;
47-
}).listen((newLines) async {
48-
_flushBuffer(newLines);
49-
});
43+
// group calls
44+
var dumpBuffer = _logBuffer;
45+
_logBuffer = [];
46+
_bufferSize = 0;
47+
return dumpBuffer;
48+
}).listen((newLines) async {
49+
_flushBuffer(newLines);
50+
});
5051
}
5152

5253
void _checkSizeForFlush() {
@@ -113,6 +114,7 @@ class FimberFileTree extends CustomFormatTree with CloseableTree {
113114
/// SizeRolling file tree.
114115
/// It will create new log file with an index every time current
115116
/// one reach [maxDataSize]
117+
@Deprecated("Use `fimber_io` package to get benefits of dart:io with Fimber.")
116118
class SizeRollingFileTree extends RollingFileTree {
117119
/// Maximum size allowed for the log file before rolls to new.
118120
DataSize maxDataSize;
@@ -131,9 +133,9 @@ class SizeRollingFileTree extends RollingFileTree {
131133
/// will create new log file.
132134
SizeRollingFileTree(this.maxDataSize,
133135
{logFormat = CustomFormatTree.defaultFormat,
134-
this.filenamePrefix = "log_",
135-
this.filenamePostfix = ".txt",
136-
logLevels = CustomFormatTree.defaultLevels})
136+
this.filenamePrefix = "log_",
137+
this.filenamePostfix = ".txt",
138+
logLevels = CustomFormatTree.defaultLevels})
137139
: super(logFormat: logFormat, logLevels: logLevels) {
138140
detectFileIndex();
139141
}
@@ -236,6 +238,7 @@ class SizeRollingFileTree extends RollingFileTree {
236238

237239
/// Time base rolling file tree.
238240
/// It will use time span to roll logging to next file.
241+
@Deprecated("Use `fimber_io` package to get benefits of dart:io with Fimber.")
239242
class TimedRollingFileTree extends RollingFileTree {
240243
/// Number of seconds in an hour
241244
static const int hourlyTime = 60 * 60;

0 commit comments

Comments
 (0)