improve siptrace

Author: callcenter-magnus

classic/src/view/sipTrace/Controller.js

@@ -21,50 +21,77 @@
 Ext.define('MBilling.view.sipTrace.Controller', {
     extend: 'Ext.ux.app.ViewController',
     alias: 'controller.siptrace',
-    onNewFilter: function(btn) {
+    onNewFilter: function (btn) {
         var me = this,
             module = me.getView();
         Ext.widget('siptracefilter', {
             title: 'SipTrace',
             list: me.list
         });
     },
-    onDeleteLog: function(btn) {
+    onDeleteLog: function (btn) {
         var me = this;
-        Ext.Msg.confirm(me.titleConfirmation, t('Confirm delete all log file?'), function(btn) {
+        Ext.Msg.confirm(me.titleConfirmation, t('Confirm delete all log file?'), function (btn) {
             if (btn === 'yes') {
                 Ext.Ajax.request({
                     url: 'index.php/sipTrace/destroy',
                     scope: me,
-                    success: function(response) {
+                    success: function (response) {
                         Ext.ux.Alert.alert(me.titleSuccess, t('Success: The SipTrace file was deleted'), 'success');
                         me.store.load();
                     }
                 });
             }
         });
     },
-    onClearAll: function(btn) {
+    onClearAll: function (btn) {
         var me = this;
         Ext.Ajax.request({
             url: 'index.php/sipTrace/clearAll',
             scope: me,
-            success: function(response) {
+            success: function (response) {
                 Ext.ux.Alert.alert(me.titleSuccess, t('Success'), 'success');
                 me.store.load();
             }
         });
     },
-    onExportPcap: function(btn) {
+    onExportPcap: function (btn) {
         var me = this;
         window.open('index.php/sipTrace/export');
     },
-    onDetails: function(btn) {
+    onDetails: function (btn) {
         var me = this,
             callids = [];
-        Ext.each(me.list.getSelectionModel().getSelection(), function(record) {
+
+        Ext.each(me.list.getSelectionModel().getSelection(), function (record) {
             callids.push(record.get('callid'));
         });
-        window.open('index.php/sipTrace/details?callid=' + Ext.encode(callids));
+
+        if (callids.length === 0) {
+            Ext.ux.Alert.alert(me.titleSuccess, t('No records selected.'), 'error');
+            return;
+        }
+
+        if (callids.length > 3) {
+            Ext.ux.Alert.alert(me.titleSuccess, t('Select a maximum of 3 records to view.'), 'error');
+            return;
+        }
+
+        Ext.create('Ext.window.Window', {
+            title: t('SIPTRACE Details'),
+            width: Ext.Element.getViewportWidth() * 0.9,
+            height: Ext.Element.getViewportHeight() * 0.9,
+            modal: true,
+            layout: 'fit',
+            items: [{
+                xtype: 'component',
+                autoEl: {
+                    tag: 'iframe',
+                    src: 'index.php/sipTrace/details?callid=' + encodeURIComponent(Ext.encode(callids)),
+                    style: 'border: none; width: 100%; height: 100%;'
+                }
+            }]
+        }).show();
     }
+
 });

classic/src/view/sipTrace/List.js

@@ -23,7 +23,7 @@ Ext.define('MBilling.view.sipTrace.List', {
     requires: ['MBilling.view.sipTrace.Filter'],
     alias: 'widget.siptracelist',
     store: 'SipTrace',
-    initComponent: function() {
+    initComponent: function () {
         var me = this;
         me.buttonImportCsv = false
         me.buttonCsv = false;
@@ -81,15 +81,15 @@ Ext.define('MBilling.view.sipTrace.List', {
         }, {
             header: t('Source'),
             dataIndex: 'fromip',
-            renderer: function(value) {
+            renderer: function (value) {
                 value = value == window.myIP ? '<b><font color="blue">' + value + '</font></b>' : value;
                 return value
             },
             flex: 3
         }, {
             header: t('Destination'),
             dataIndex: 'toip',
-            renderer: function(value) {
+            renderer: function (value) {
                 value = value == window.myIP ? '<b><font color="blue">' + value + '</font></b>' : value;
                 return value
             },

protected/commands/update.sh

@@ -75,7 +75,7 @@ chown -R asterisk:asterisk /var/www/html/mbilling/tmp
 chown -R asterisk:asterisk /var/run/magnus/
 chown -R root:root /root
 chown -R mysql:mysql /var/lib/mysql
-chmod -R 777 /tmp
+chmod -R 1777 /tmp
 chmod -R 755 /usr/local/src/magnus
 chmod -R 555 /var/www/html/mbilling/
 chmod -R 700 /var/www/html/mbilling/resources/reports