fix linting

Author: Alexboiboi

pyproject.toml

@@ -166,4 +166,6 @@ messages_control.disable = [
   "missing-module-docstring",
   "missing-function-docstring",
   "wrong-import-position",
+  "invalid-name", # TODO - review later
+  "protected-access", # TODO - review later
 ]

src/magpylib_material_response/_data/__init__.py

@@ -4,12 +4,12 @@
 
 from __future__ import annotations
 
+import importlib
+import json
+from pathlib import Path
 
-def get_dataset(name):
-    import importlib
-    import json
-    from pathlib import Path
 
+def get_dataset(name):
     name = Path(name).with_suffix("").with_suffix(".json")
     with (
         importlib.resources.path(

src/magpylib_material_response/demag.py

@@ -31,7 +31,7 @@
 logger.configure(**config)
 
 
-def get_susceptibilities(sources, susceptibility):
+def get_susceptibilities(sources, susceptibility=None):
     """Return a list of length (len(sources)) with susceptibility values
     Priority is given at the source level, however if value is not found, it is searched
     up the parent tree, if available. Raises an error if no value is found when reached
@@ -141,6 +141,8 @@ def demag_tensor(
     if pairs_matching and split != 1:
         msg = "Pairs matching does not support splitting"
         raise ValueError(msg)
+    mask_inds = None
+    getH_params = {}
     if max_dist != 0:
         mask_inds, getH_params, pos0, rot0 = filter_distance(
             src_list, max_dist, return_params=False, return_base_geo=True
@@ -158,7 +160,9 @@ def demag_tensor(
         # point matching field and demag tensor
         with timelog(f"getH with unit_pol={unit_pol}", min_log_time=min_log_time):
             if pairs_matching or max_dist != 0:
-                polarization = np.repeat(pol_all, len(src_list), axis=0)[mask_inds]
+                polarization = np.repeat(pol_all, len(src_list), axis=0)
+                if mask_inds is not None:
+                    polarization = polarization[mask_inds]
                 H_unique = magpy.getH(
                     "Cuboid", polarization=polarization, **getH_params
                 )

src/magpylib_material_response/meshing.py

@@ -430,13 +430,15 @@ def mesh_all(
     for child, targ_elems in zip(supported_objs, target_elems_by_child):
         parent = child.parent
         kw = kwargs if parent is None else {}
+        child_meshed = None
         if isinstance(child, magpy.magnet.Cuboid):
             child_meshed = mesh_Cuboid(child, targ_elems, **kw)
         elif isinstance(child, magpy.magnet.Cylinder):
             child_meshed = mesh_Cylinder(child, targ_elems, **kw)
-        child.parent = None
-        if parent is not None:
-            parent.add(child_meshed)
-        else:
-            obj = child_meshed
+        if child_meshed is not None:
+            child.parent = None
+            if parent is not None:
+                parent.add(child_meshed)
+            else:
+                obj = child_meshed
     return obj

src/magpylib_material_response/meshing_utils.py

@@ -176,9 +176,6 @@ def mask_inside_Sphere(obj, positions, tolerance=1e-14):
 def mask_inside_CylinderSegment(obj, positions, tolerance=1e-14):
     """Return mask of provided positions inside a CylinderSegment"""
 
-    def close(arg1, arg2):
-        return np.isclose(arg1, arg2, rtol=tolerance, atol=tolerance)
-
     r1, r2, h, phi1, phi2 = obj.dimension.T
     r1 = abs(r1)
     r2 = abs(r2)

src/magpylib_material_response/polyline.py

@@ -242,21 +242,6 @@ def move_grid_along_polyline(verts: np.ndarray, grid: np.ndarray) -> np.ndarray:
     """
     Move a grid along a polyline, defined by the vertices.
 
-    Parameters
-    ----------
-    verts : np.ndarray, shape (n, d)
-        Array of polyline vertices, where n is the number of vertices and d is the dimension.
-    grid : np.ndarray, shape (m, d)
-        Array of grid points to move along the polyline, where m is the number of points.
-
-    Returns
-    -------
-    np.ndarray, shape (m, n, d)
-        Array of moved grid points along the polyline, with the same dimensions as the input grid.
-    """
-    """
-    Move a grid along a polyline, defined by the vertices.
-
     Parameters
     ----------
     verts : np.ndarray, shape (n, d)

tests/test_meshing.py

@@ -110,7 +110,7 @@ def test_slice_Cuboid2():
     np.testing.assert_allclose(cm[0].position, [0.0, 0.0, -0.45])
     np.testing.assert_allclose(cm[1].position, [0.0, 0.0, 0.05])
 
-    with pytest.raises(ValueError, match="Shift must be between 0 and 1 (exclusive)"):
+    with pytest.raises(ValueError, match=r"Shift must be between 0 and 1 *."):
         slice_Cuboid(c, shift=0, axis="y")