Skip to content

Commit 4c79182

Browse files
overmightymahesh-attarde
authored andcommitted
Revert "[libc][math][c23] Implement C23 math function asinpif16" (llvm#150756)
Reverts llvm#146226 The MPFR test uses `mpfr_asinpi` which requires MPFR 4.2.0 or later, but the Buildbots are running an older version of MPFR. See https://lab.llvm.org/buildbot/#/builders/104/builds/27743 for example. I said I was going to revert the PR until we have a workaround for older versions of MPFR, but then I forgot and I just disabled the entrypoints which doesn't fix the Buildbot builds.
1 parent e04eb86 commit 4c79182

File tree

16 files changed

+1
-338
lines changed

16 files changed

+1
-338
lines changed

libc/config/linux/aarch64/entrypoints.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,6 @@ if(LIBC_TYPES_HAS_FLOAT16)
660660
list(APPEND TARGET_LIBM_ENTRYPOINTS
661661
# math.h C23 _Float16 entrypoints
662662
# libc.src.math.acoshf16
663-
libc.src.math.asinpif16
664663
libc.src.math.canonicalizef16
665664
libc.src.math.ceilf16
666665
libc.src.math.copysignf16

libc/config/linux/x86_64/entrypoints.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,6 @@ if(LIBC_TYPES_HAS_FLOAT16)
703703
libc.src.math.acospif16
704704
libc.src.math.asinf16
705705
libc.src.math.asinhf16
706-
libc.src.math.asinpif16
707706
libc.src.math.atanf16
708707
libc.src.math.atanhf16
709708
libc.src.math.canonicalizef16

libc/docs/headers/math/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ Higher Math Functions
259259
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
260260
| asinh | |check| | | | |check| | | 7.12.5.2 | F.10.2.2 |
261261
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
262-
| asinpi | | | | |check| | | 7.12.4.9 | F.10.1.9 |
262+
| asinpi | | | | | | 7.12.4.9 | F.10.1.9 |
263263
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+
264264
| atan | |check| | 1 ULP | | |check| | | 7.12.4.3 | F.10.1.3 |
265265
+-----------+------------------+-----------------+------------------------+----------------------+------------------------+------------------------+----------------------------+

libc/include/math.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -79,13 +79,6 @@ functions:
7979
arguments:
8080
- type: _Float16
8181
guard: LIBC_TYPES_HAS_FLOAT16
82-
- name: asinpif16
83-
standards:
84-
- stdc
85-
return_type: _Float16
86-
arguments:
87-
- type: _Float16
88-
guard: LIBC_TYPES_HAS_FLOAT16
8982
- name: atan
9083
standards:
9184
- stdc

libc/src/math/CMakeLists.txt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ add_math_entrypoint_object(asinh)
5858
add_math_entrypoint_object(asinhf)
5959
add_math_entrypoint_object(asinhf16)
6060

61-
add_math_entrypoint_object(asinpif16)
62-
6361
add_math_entrypoint_object(atan)
6462
add_math_entrypoint_object(atanf)
6563
add_math_entrypoint_object(atanf16)

libc/src/math/asinpif16.h

Lines changed: 0 additions & 21 deletions
This file was deleted.

libc/src/math/generic/CMakeLists.txt

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -3918,25 +3918,6 @@ add_entrypoint_object(
39183918
libc.src.__support.macros.properties.types
39193919
)
39203920

3921-
add_entrypoint_object(
3922-
asinpif16
3923-
SRCS
3924-
asinpif16.cpp
3925-
HDRS
3926-
../asinpif16.h
3927-
DEPENDS
3928-
libc.hdr.errno_macros
3929-
libc.hdr.fenv_macros
3930-
libc.src.__support.FPUtil.cast
3931-
libc.src.__support.FPUtil.except_value_utils
3932-
libc.src.__support.FPUtil.fenv_impl
3933-
libc.src.__support.FPUtil.fp_bits
3934-
libc.src.__support.FPUtil.multiply_add
3935-
libc.src.__support.FPUtil.polyeval
3936-
libc.src.__support.FPUtil.sqrt
3937-
libc.src.__support.macros.optimization
3938-
)
3939-
39403921
add_entrypoint_object(
39413922
atanhf
39423923
SRCS

libc/src/math/generic/asinpif16.cpp

Lines changed: 0 additions & 127 deletions
This file was deleted.

libc/test/src/math/CMakeLists.txt

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2282,17 +2282,6 @@ add_fp_unittest(
22822282
libc.src.math.asinf16
22832283
)
22842284

2285-
add_fp_unittest(
2286-
asinpif16_test
2287-
NEED_MPFR
2288-
SUITE
2289-
libc-math-unittests
2290-
SRCS
2291-
asinpif16_test.cpp
2292-
DEPENDS
2293-
libc.src.math.asinpif16
2294-
)
2295-
22962285
add_fp_unittest(
22972286
acosf_test
22982287
NEED_MPFR

libc/test/src/math/asinpif16_test.cpp

Lines changed: 0 additions & 40 deletions
This file was deleted.

0 commit comments

Comments
 (0)