Skip to content

Commit 701d049

Browse files
ellishgmahesh-attarde
authored andcommitted
[lld][macho] Rename test to fix spelling (llvm#160938)
The test name had a typo from llvm#140307. Fix it. I realized cstring ordering is not supported when string deduplication is turned off. We could easily call `buildCStringPriorities()` in `CStringSection::finalizeContents()`, but I worry it might harm build performance since it creates multiple vectors and searches though maps. If users are not deduplicating strings, they probably won't care to order them, but it would be good to support this.
1 parent d208b59 commit 701d049

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

lld/MachO/SyntheticSections.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1687,6 +1687,9 @@ void CStringSection::writeTo(uint8_t *buf) const {
16871687

16881688
void CStringSection::finalizeContents() {
16891689
uint64_t offset = 0;
1690+
// TODO: Call buildCStringPriorities() to support cstring ordering when
1691+
// deduplication is off, although this may negatively impact build
1692+
// performance.
16901693
for (CStringInputSection *isec : inputs) {
16911694
for (const auto &[i, piece] : llvm::enumerate(isec->pieces)) {
16921695
if (!piece.live)
File renamed without changes.

0 commit comments

Comments
 (0)