[MLIR] Apply clang-tidy fixes for llvm-else-after-return in TransformOps.cpp (NFC)

joker-eph · mahesh-attarde · commit a4661dcf9fe6 · 2025-10-02T21:17:09.000-07:00
diff --git a/mlir/lib/Dialect/Transform/IR/TransformOps.cpp b/mlir/lib/Dialect/Transform/IR/TransformOps.cpp
@@ -616,11 +616,10 @@ DiagnosedSilenceableFailure transform::ApplyConversionPatternsOp::apply(
       if (diag.succeeded()) {
         // Tracking failure is the only failure.
         return trackingFailure;
-      } else {
-        diag.attachNote() << "tracking listener also failed: "
-                          << trackingFailure.getMessage();
-        (void)trackingFailure.silence();
       }
+      diag.attachNote() << "tracking listener also failed: "
+                        << trackingFailure.getMessage();
+      (void)trackingFailure.silence();
     }
 
     if (!diag.succeeded())

Original file line number	Diff line number	Diff line change
`@@ -616,11 +616,10 @@ DiagnosedSilenceableFailure transform::ApplyConversionPatternsOp::apply(`
`616`	`616`	`if (diag.succeeded()) {`
`617`	`617`	`// Tracking failure is the only failure.`
`618`	`618`	`return trackingFailure;`
`619`		`- } else {`
`620`		`- diag.attachNote() << "tracking listener also failed: "`
`621`		`- << trackingFailure.getMessage();`
`622`		`- (void)trackingFailure.silence();`
`623`	`619`	`}`
	`620`	`+ diag.attachNote() << "tracking listener also failed: "`
	`621`	`+ << trackingFailure.getMessage();`
	`622`	`+ (void)trackingFailure.silence();`
`624`	`623`	`}`
`625`	`624`
`626`	`625`	`if (!diag.succeeded())`