Skip to content

Commit b858825

Browse files
RKSimonmahesh-attarde
authored andcommitted
[X86] canCreateUndefOrPoisonForTargetNode/isGuaranteedNotToBeUndefOrPoisonForTargetNode - add X86ISD::PSHUFB handling (llvm#160842)
X86ISD::PSHUFB shuffles can't create undef/poison itself, allowing us to fold freeze(pshufb(x,y)) -> pshufb(freeze(x),freeze(y))
1 parent a6fdd14 commit b858825

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

llvm/lib/Target/X86/X86ISelLowering.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45185,6 +45185,7 @@ bool X86TargetLowering::isGuaranteedNotToBeUndefOrPoisonForTargetNode(
4518545185
case X86ISD::WrapperRIP:
4518645186
return true;
4518745187
case X86ISD::BLENDI:
45188+
case X86ISD::PSHUFB:
4518845189
case X86ISD::PSHUFD:
4518945190
case X86ISD::UNPCKL:
4519045191
case X86ISD::UNPCKH:
@@ -45251,6 +45252,7 @@ bool X86TargetLowering::canCreateUndefOrPoisonForTargetNode(
4525145252
case X86ISD::BLENDV:
4525245253
return false;
4525345254
// SSE target shuffles.
45255+
case X86ISD::PSHUFB:
4525445256
case X86ISD::PSHUFD:
4525545257
case X86ISD::UNPCKL:
4525645258
case X86ISD::UNPCKH:

llvm/test/CodeGen/X86/vector-shuffle-combining-ssse3.ll

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -897,19 +897,9 @@ define i32 @mask_z1z3_v16i8(<16 x i8> %a0) {
897897
}
898898

899899
define <16 x i8> @freeze_pshufb_v16i8(<16 x i8> %a0) {
900-
; SSE-LABEL: freeze_pshufb_v16i8:
901-
; SSE: # %bb.0:
902-
; SSE-NEXT: movdqa {{.*#+}} xmm1 = [15,14,13,12,11,10,9,8,7,6,5,4,3,2,1,0]
903-
; SSE-NEXT: pshufb %xmm1, %xmm0
904-
; SSE-NEXT: pshufb %xmm1, %xmm0
905-
; SSE-NEXT: retq
906-
;
907-
; AVX-LABEL: freeze_pshufb_v16i8:
908-
; AVX: # %bb.0:
909-
; AVX-NEXT: vmovdqa {{.*#+}} xmm1 = [15,14,13,12,11,10,9,8,7,6,5,4,3,2,1,0]
910-
; AVX-NEXT: vpshufb %xmm1, %xmm0, %xmm0
911-
; AVX-NEXT: vpshufb %xmm1, %xmm0, %xmm0
912-
; AVX-NEXT: retq
900+
; CHECK-LABEL: freeze_pshufb_v16i8:
901+
; CHECK: # %bb.0:
902+
; CHECK-NEXT: retq
913903
%s0 = call <16 x i8> @llvm.x86.ssse3.pshuf.b.128(<16 x i8> %a0, <16 x i8> <i8 15, i8 14, i8 13, i8 12, i8 11, i8 10, i8 9, i8 8, i8 7, i8 6, i8 5, i8 4, i8 3, i8 2, i8 1, i8 0>)
914904
%f0 = freeze <16 x i8> %s0
915905
%s1 = call <16 x i8> @llvm.x86.ssse3.pshuf.b.128(<16 x i8> %f0, <16 x i8> <i8 15, i8 14, i8 13, i8 12, i8 11, i8 10, i8 9, i8 8, i8 7, i8 6, i8 5, i8 4, i8 3, i8 2, i8 1, i8 0>)

0 commit comments

Comments
 (0)