Skip to content

Commit d905dc7

Browse files
zhaoqi5mahesh-attarde
authored andcommitted
[LoongArch] Override cost hooks to expose more DAG combine opportunities (llvm#157824)
1 parent 2a0bc20 commit d905dc7

File tree

4 files changed

+35
-26
lines changed

4 files changed

+35
-26
lines changed

llvm/lib/Target/LoongArch/LoongArchISelLowering.cpp

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9559,3 +9559,20 @@ bool LoongArchTargetLowering::shouldScalarizeBinop(SDValue VecOp) const {
95599559
EVT ScalarVT = VecVT.getScalarType();
95609560
return isOperationLegalOrCustomOrPromote(Opc, ScalarVT);
95619561
}
9562+
9563+
bool LoongArchTargetLowering::isExtractSubvectorCheap(EVT ResVT, EVT SrcVT,
9564+
unsigned Index) const {
9565+
if (!isOperationLegalOrCustom(ISD::EXTRACT_SUBVECTOR, ResVT))
9566+
return false;
9567+
9568+
// Extract a 128-bit subvector from index 0 of a 256-bit vector is free.
9569+
return Index == 0;
9570+
}
9571+
9572+
bool LoongArchTargetLowering::isExtractVecEltCheap(EVT VT,
9573+
unsigned Index) const {
9574+
EVT EltVT = VT.getScalarType();
9575+
9576+
// Extract a scalar FP value from index 0 of a vector is free.
9577+
return (EltVT == MVT::f32 || EltVT == MVT::f64) && Index == 0;
9578+
}

llvm/lib/Target/LoongArch/LoongArchISelLowering.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,9 @@ class LoongArchTargetLowering : public TargetLowering {
338338
unsigned Depth) const override;
339339

340340
bool shouldScalarizeBinop(SDValue VecOp) const override;
341+
bool isExtractSubvectorCheap(EVT ResVT, EVT SrcVT,
342+
unsigned Index) const override;
343+
bool isExtractVecEltCheap(EVT VT, unsigned Index) const override;
341344

342345
/// Check if a constant splat can be generated using [x]vldi, where imm[12]
343346
/// is 1.

llvm/test/CodeGen/LoongArch/lasx/scalarize-fp.ll

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@
55
define <8 x float> @fadd_elt0_v8f32(float %a) nounwind {
66
; CHECK-LABEL: fadd_elt0_v8f32:
77
; CHECK: # %bb.0: # %entry
8-
; CHECK-NEXT: # kill: def $f0 killed $f0 def $xr0
9-
; CHECK-NEXT: xvldi $xr1, -1424
10-
; CHECK-NEXT: xvfadd.s $xr0, $xr0, $xr1
8+
; CHECK-NEXT: vldi $vr1, -1168
9+
; CHECK-NEXT: fadd.s $fa0, $fa0, $fa1
1110
; CHECK-NEXT: ret
1211
entry:
1312
%b = insertelement <8 x float> poison, float %a, i32 0
@@ -18,9 +17,8 @@ entry:
1817
define <4 x double> @fadd_elt0_v4f64(double %a) nounwind {
1918
; CHECK-LABEL: fadd_elt0_v4f64:
2019
; CHECK: # %bb.0: # %entry
21-
; CHECK-NEXT: # kill: def $f0_64 killed $f0_64 def $xr0
22-
; CHECK-NEXT: xvldi $xr1, -912
23-
; CHECK-NEXT: xvfadd.d $xr0, $xr0, $xr1
20+
; CHECK-NEXT: vldi $vr1, -912
21+
; CHECK-NEXT: fadd.d $fa0, $fa0, $fa1
2422
; CHECK-NEXT: ret
2523
entry:
2624
%b = insertelement <4 x double> poison, double %a, i32 0
@@ -31,11 +29,8 @@ entry:
3129
define <8 x float> @fsub_splat_v8f32(float %a, float %b) nounwind {
3230
; CHECK-LABEL: fsub_splat_v8f32:
3331
; CHECK: # %bb.0: # %entry
34-
; CHECK-NEXT: # kill: def $f1 killed $f1 def $vr1
35-
; CHECK-NEXT: # kill: def $f0 killed $f0 def $vr0
36-
; CHECK-NEXT: vfsub.s $vr0, $vr0, $vr1
37-
; CHECK-NEXT: xvpermi.d $xr0, $xr0, 68
38-
; CHECK-NEXT: xvrepl128vei.w $xr0, $xr0, 0
32+
; CHECK-NEXT: fsub.s $fa0, $fa0, $fa1
33+
; CHECK-NEXT: xvreplve0.w $xr0, $xr0
3934
; CHECK-NEXT: ret
4035
entry:
4136
%insa = insertelement <8 x float> poison, float %a, i32 0
@@ -49,10 +44,9 @@ entry:
4944
define <4 x double> @fsub_splat_v4f64(double %a) nounwind {
5045
; CHECK-LABEL: fsub_splat_v4f64:
5146
; CHECK: # %bb.0: # %entry
52-
; CHECK-NEXT: # kill: def $f0_64 killed $f0_64 def $xr0
53-
; CHECK-NEXT: xvldi $xr1, -784
54-
; CHECK-NEXT: xvfadd.d $xr0, $xr0, $xr1
55-
; CHECK-NEXT: xvpermi.d $xr0, $xr0, 0
47+
; CHECK-NEXT: vldi $vr1, -784
48+
; CHECK-NEXT: fadd.d $fa0, $fa0, $fa1
49+
; CHECK-NEXT: xvreplve0.d $xr0, $xr0
5650
; CHECK-NEXT: ret
5751
entry:
5852
%insa = insertelement <4 x double> poison, double %a, i32 0

llvm/test/CodeGen/LoongArch/lsx/scalarize-fp.ll

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,8 @@
55
define <4 x float> @fadd_elt0_v4f32(float %a) nounwind {
66
; CHECK-LABEL: fadd_elt0_v4f32:
77
; CHECK: # %bb.0: # %entry
8-
; CHECK-NEXT: # kill: def $f0 killed $f0 def $vr0
9-
; CHECK-NEXT: vldi $vr1, -1424
10-
; CHECK-NEXT: vfadd.s $vr0, $vr0, $vr1
8+
; CHECK-NEXT: vldi $vr1, -1168
9+
; CHECK-NEXT: fadd.s $fa0, $fa0, $fa1
1110
; CHECK-NEXT: ret
1211
entry:
1312
%b = insertelement <4 x float> poison, float %a, i32 0
@@ -18,9 +17,8 @@ entry:
1817
define <2 x double> @fadd_elt0_v2f64(double %a) nounwind {
1918
; CHECK-LABEL: fadd_elt0_v2f64:
2019
; CHECK: # %bb.0: # %entry
21-
; CHECK-NEXT: # kill: def $f0_64 killed $f0_64 def $vr0
2220
; CHECK-NEXT: vldi $vr1, -912
23-
; CHECK-NEXT: vfadd.d $vr0, $vr0, $vr1
21+
; CHECK-NEXT: fadd.d $fa0, $fa0, $fa1
2422
; CHECK-NEXT: ret
2523
entry:
2624
%b = insertelement <2 x double> poison, double %a, i32 0
@@ -31,9 +29,8 @@ entry:
3129
define <4 x float> @fsub_splat_v4f32(float %b) nounwind {
3230
; CHECK-LABEL: fsub_splat_v4f32:
3331
; CHECK: # %bb.0: # %entry
34-
; CHECK-NEXT: # kill: def $f0 killed $f0 def $vr0
35-
; CHECK-NEXT: vldi $vr1, -1424
36-
; CHECK-NEXT: vfsub.s $vr0, $vr1, $vr0
32+
; CHECK-NEXT: vldi $vr1, -1168
33+
; CHECK-NEXT: fsub.s $fa0, $fa1, $fa0
3734
; CHECK-NEXT: vreplvei.w $vr0, $vr0, 0
3835
; CHECK-NEXT: ret
3936
entry:
@@ -48,9 +45,7 @@ entry:
4845
define <2 x double> @fsub_splat_v2f64(double %a, double %b) nounwind {
4946
; CHECK-LABEL: fsub_splat_v2f64:
5047
; CHECK: # %bb.0: # %entry
51-
; CHECK-NEXT: # kill: def $f1_64 killed $f1_64 def $vr1
52-
; CHECK-NEXT: # kill: def $f0_64 killed $f0_64 def $vr0
53-
; CHECK-NEXT: vfsub.d $vr0, $vr0, $vr1
48+
; CHECK-NEXT: fsub.d $fa0, $fa0, $fa1
5449
; CHECK-NEXT: vreplvei.d $vr0, $vr0, 0
5550
; CHECK-NEXT: ret
5651
entry:

0 commit comments

Comments
 (0)