[ACME] Fix wildcard certificate conflict with MAILCOW_HOSTNAME#7124
Merged
FreddleSpl0it merged 1 commit intostagingfrom Mar 12, 2026
Merged
[ACME] Fix wildcard certificate conflict with MAILCOW_HOSTNAME#7124FreddleSpl0it merged 1 commit intostagingfrom
FreddleSpl0it merged 1 commit intostagingfrom
Conversation
Contributor
|
The patch fixes the problem for me. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
Fixes ACME DNS-01 challenge failures when using wildcard certificates that cover the MAILCOW_HOSTNAME. Previously, when
ADDITIONAL_SANcontained a wildcard domain (e.g.,*.example.com) andMAILCOW_HOSTNAMEwas a subdomain of that wildcard (e.g.,mail.example.com), Let's Encrypt would reject the certificate request with the error: "Domain name 'mail.example.com' is redundant with a wildcard domain in the same request."This PR adds detection to skip adding
MAILCOW_HOSTNAMEto the certificate request when it's already covered by a wildcard inADDITIONAL_SAN.Fixes:
Affected Containers