Skip to content

[ACME] Fix wildcard certificate conflict with MAILCOW_HOSTNAME#7124

Merged
FreddleSpl0it merged 1 commit intostagingfrom
fix/7112
Mar 12, 2026
Merged

[ACME] Fix wildcard certificate conflict with MAILCOW_HOSTNAME#7124
FreddleSpl0it merged 1 commit intostagingfrom
fix/7112

Conversation

@FreddleSpl0it
Copy link
Collaborator

Contribution Guidelines

What does this PR include?

Short Description

Fixes ACME DNS-01 challenge failures when using wildcard certificates that cover the MAILCOW_HOSTNAME. Previously, when ADDITIONAL_SAN contained a wildcard domain (e.g., *.example.com) and MAILCOW_HOSTNAME was a subdomain of that wildcard (e.g., mail.example.com), Let's Encrypt would reject the certificate request with the error: "Domain name 'mail.example.com' is redundant with a wildcard domain in the same request."

This PR adds detection to skip adding MAILCOW_HOSTNAME to the certificate request when it's already covered by a wildcard in ADDITIONAL_SAN.

Fixes:

Affected Containers

  • acme-mailcow

@svengo
Copy link
Contributor

svengo commented Mar 11, 2026

The patch fixes the problem for me. Thank you!

@FreddleSpl0it FreddleSpl0it merged commit abd6fe8 into staging Mar 12, 2026
2 checks passed
@FreddleSpl0it FreddleSpl0it deleted the fix/7112 branch March 12, 2026 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants