improvements for service status display

[dneuhaeuser]

When Mailscanner is in Milter mode (MTA = msmail) the service status reports a different process count for postfix.

For consistency I suggest to use the same ps command as without Milter mode.
Parameter "--no-headers" should also be added in both cases, otherwise postfix is reported as running when it isn't and the process count is too high by 1 because the ps header line is counted.

Also, with Mailscanner's "Milter Dispatcher = postfork" and the system idling, the status displays:
"MSMilter: YES | 0 children", which is confusing.
I suggest to display the process count when it is 1.

These are my improvements:

--- functions.php.bak   2022-10-22 01:40:28.000000000 +0200
+++ functions.php       2022-10-22 02:06:57.000000000 +0200
@@ -459,7 +459,7 @@
         // is MTA running
         $mta = get_conf_var('mta');
         if ($mta === 'msmail') {
-            exec('ps ax | grep postfix | grep -v grep | grep -v php', $output);
+            exec('ps --no-headers -U postfix -u postfix | grep -v MailScanner | grep -v "MailWatch SQL" | grep -v MSMilter', $output);
             if (count($output) > 0) {
                 $running = $yes;
             } else {
@@ -473,9 +473,12 @@
             exec('ps ax | grep MSMilter | grep -v grep', $output);
             if (count($output) > 0) {
                 $running = $yes;
-                $procs = count($output) - 1 . ' ' . __('children03');
             } else {
                 $running = $no;
+           }
+            if (count($output) > 1) {
+                $procs = count($output) - 1 . ' ' . __('children03');
+            } else {
                 $procs = count($output) . ' ' . __('procs03');
             }
             echo '    <tr><td>' . 'MSMilter' . __('colon99') . '</td>'
@@ -483,7 +486,7 @@
         } else {
             $psExecCommand = "ps ax | grep $mta | grep -v grep | grep -v php";
             if ($mta === 'postfix') {
-                $psExecCommand = 'ps -U postfix -u postfix | grep -v MailScanner | grep -v "MailWatch SQL"';
+                $psExecCommand = 'ps --no-headers -U postfix -u postfix | grep -v MailScanner | grep -v "MailWatch SQL"';
             }
             exec($psExecCommand, $output);
             if (count($output) > 0) {

[endelwar]

ps --no-headers won't work on a BSD system: I don't think that is a necessary parameter as successive grep should cut headers.

Do you mind opening a PR for this enhancement?

[dneuhaeuser]

ok, here is the PR: #1263