Skip to content

Commit 0e773f7

Browse files
committed
chore: remove redundant as assertions
1 parent 451ae7f commit 0e773f7

File tree

3 files changed

+4
-17
lines changed

3 files changed

+4
-17
lines changed

packages/react-components/react-accordion/library/src/components/AccordionPanel/useAccordionPanel.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as React from 'react';
22
import { getIntrinsicElementProps, slot } from '@fluentui/react-utilities';
33
import { useTabsterAttributes } from '@fluentui/react-tabster';
4-
import { presenceMotionSlot, type PresenceMotionSlotProps } from '@fluentui/react-motion';
4+
import { presenceMotionSlot } from '@fluentui/react-motion';
55
import { Collapse } from '@fluentui/react-motion-components-preview';
66
import { useAccordionContext_unstable } from '../../contexts/accordion';
77
import type { AccordionPanelProps, AccordionPanelState } from './AccordionPanel.types';
@@ -24,11 +24,7 @@ export const useAccordionPanel_unstable = (
2424
open,
2525
components: {
2626
root: 'div',
27-
// TODO: remove once React v18 slot API is modified
28-
// This is a problem at the moment due to UnknownSlotProps assumption
29-
// that `children` property is `ReactNode`, which in this case is not valid
30-
// as PresenceComponentProps['children'] is `ReactElement`
31-
collapseMotion: Collapse as React.FC<PresenceMotionSlotProps>,
27+
collapseMotion: Collapse,
3228
},
3329
root: slot.always(
3430
getIntrinsicElementProps('div', {

packages/react-components/react-motion/library/src/slots/presenceMotionSlot.test.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,7 @@ const TestMotion = jest.fn(
2121
const TestComponent: React.FC<TestComponentProps> = props => {
2222
const state: TestComponentState = {
2323
components: {
24-
// TODO: remove once React v18 slot API is modified
25-
// This is a problem at the moment due to UnknownSlotProps assumption
26-
// that `children` property is `ReactNode`, which in this case is not valid
27-
// as PresenceComponentProps['children'] is `ReactElement`
28-
presenceMotion: TestMotion as React.FC<PresenceMotionSlotProps>,
24+
presenceMotion: TestMotion,
2925
},
3026
presenceMotion: presenceMotionSlot(props.presenceMotion, {
3127
elementType: TestMotion,

packages/react-components/react-tree/library/src/hooks/useRootTree.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { getIntrinsicElementProps, useEventCallback, slot } from '@fluentui/reac
22
import type { TreeCheckedChangeData, TreeProps, TreeState } from '../Tree';
33
import * as React from 'react';
44
import { Collapse } from '@fluentui/react-motion-components-preview';
5-
import { PresenceMotionSlotProps } from '@fluentui/react-motion';
65
import { TreeContextValue, TreeItemRequest } from '../contexts/treeContext';
76
import { createCheckedItems } from '../utils/createCheckedItems';
87
import { treeDataTypes } from '../utils/tokens';
@@ -80,11 +79,7 @@ export function useRootTree(
8079
return {
8180
components: {
8281
root: 'div',
83-
// TODO: remove once React v18 slot API is modified
84-
// This is a problem at the moment due to UnknownSlotProps assumption
85-
// that `children` property is `ReactNode`, which in this case is not valid
86-
// as PresenceComponentProps['children'] is `ReactElement`
87-
collapseMotion: Collapse as React.FC<PresenceMotionSlotProps>,
82+
collapseMotion: Collapse,
8883
},
8984
contextType: 'root',
9085
selectionMode,

0 commit comments

Comments
 (0)