Skip to content

Commit 4d8f87a

Browse files
Anush2303Anush
andauthored
fix(react-charts): fix heatmap y-axis labels and vertical bar chart bar size (microsoft#35181)
Co-authored-by: Anush <[email protected]>
1 parent f3bcc9c commit 4d8f87a

File tree

5 files changed

+1250
-1242
lines changed

5 files changed

+1250
-1242
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "fix v9 chart bugs",
4+
"packageName": "@fluentui/react-charts",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

packages/charts/react-charts/library/src/components/GroupedVerticalBarChart/GroupedVerticalBarChart.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,12 @@ interface GVSingleDataPoint {
7171
export const GroupedVerticalBarChart: React.FC<GroupedVerticalBarChartProps> = React.forwardRef<
7272
HTMLDivElement,
7373
GroupedVerticalBarChartProps
74-
>((props = { maxBarWidth: 24, xAxisCategoryOrder: 'default' }, forwardedRef) => {
74+
>((_props, forwardedRef) => {
75+
const props: GroupedVerticalBarChartProps = {
76+
xAxisCategoryOrder: 'default',
77+
maxBarWidth: 24,
78+
..._props,
79+
};
7580
const _tooltipId: string = useId('GVBCTooltipId_');
7681
const _emptyChartId: string = useId('_GVBC_empty');
7782
const _useRtl: boolean = useRtl();

packages/charts/react-charts/library/src/components/HeatMapChart/HeatMapChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ export const HeatMapChart: React.FunctionComponent<HeatMapChartProps> = React.fo
120120
if (xAxisType === XAxisTypes.NumericAxis || xAxisType === XAxisTypes.DateAxis) {
121121
domainNRangeValue = { dStartValue: 0, dEndValue: 0, rStartValue: 0, rEndValue: 0 };
122122
} else {
123-
domainNRangeValue = domainRangeOfXStringAxis(margins, width, isRTL);
123+
domainNRangeValue = domainRangeOfXStringAxis(_margins.current, width, isRTL);
124124
}
125125
return domainNRangeValue;
126126
}

packages/charts/react-charts/library/src/components/VerticalBarChart/VerticalBarChart.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,12 @@ const MIN_DOMAIN_MARGIN = 8;
7474
export const VerticalBarChart: React.FunctionComponent<VerticalBarChartProps> = React.forwardRef<
7575
HTMLDivElement,
7676
VerticalBarChartProps
77-
>((props = { xAxisCategoryOrder: 'default' }, forwardedRef) => {
77+
>((_props, forwardedRef) => {
78+
const props: VerticalBarChartProps = {
79+
xAxisCategoryOrder: 'default',
80+
maxBarWidth: 24,
81+
..._props,
82+
};
7883
let _points: VerticalBarChartDataPoint[] = [];
7984
let _barWidth: number = 0;
8085
let _colors: string[];

0 commit comments

Comments
 (0)