Skip to content

Commit 51eb72a

Browse files
fix(react-spinner): ensure intrinsic width to avoid spinner clipping (microsoft#35068)
Co-authored-by: Marcos Moura <[email protected]>
1 parent 28df5f7 commit 51eb72a

File tree

3 files changed

+32
-0
lines changed

3 files changed

+32
-0
lines changed

apps/vr-tests-react-components/src/stories/Spinner.stories.tsx

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,3 +112,27 @@ export const Animation = () => (
112112
);
113113

114114
export const AnimationRTL = getStoryVariant(Animation, RTL);
115+
116+
export const SpinnerMinWidth = () => (
117+
<div
118+
style={{
119+
display: 'flex',
120+
}}
121+
>
122+
<Spinner />
123+
<span>
124+
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore
125+
magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo
126+
consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.
127+
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum. Sed
128+
ut perspiciatis unde omnis iste natus error sit voluptatem accusantium doloremque laudantium, totam rem aperiam,
129+
eaque ipsa quae ab illo inventore veritatis et quasi architecto beatae vitae dicta sunt explicabo. Nemo enim ipsam
130+
voluptatem quia voluptas sit aspernatur aut odit aut fugit, sed quia consequuntur magni dolores eos qui ratione
131+
voluptatem sequi nesciunt. Neque porro quisquam est, qui dolorem ipsum quia dolor sit amet, consectetur, adipisci
132+
velit, sed quia non numquam eius modi tempora incidunt ut labore et dolore magnam aliquam quaerat voluptatem. Ut
133+
enim ad minima veniam, quis nostrum exercitationem ullam corporis suscipit laboriosam, nisi ut aliquid ex ea
134+
commodi consequatur? Quis autem vel eum iure reprehenderit qui in ea voluptate velit esse quam nihil molestiae
135+
consequatur, vel illum qui dolorem eum fugiat quo voluptas nulla pariatur?
136+
</span>
137+
</div>
138+
);
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "fix: set min-width to min-content to prevent spinner clipping",
4+
"packageName": "@fluentui/react-spinner",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

packages/react-components/react-spinner/library/src/components/Spinner/useSpinnerStyles.styles.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ const useRootBaseClassName = makeResetStyles({
2525
lineHeight: '0',
2626
gap: '8px',
2727
overflow: 'hidden', // prevents height changes from rotating children
28+
minWidth: 'min-content',
2829
});
2930

3031
const useRootStyles = makeStyles({

0 commit comments

Comments
 (0)