Skip to content

Commit 551b944

Browse files
Anush2303Anush
andauthored
fix(react-charts): remove default culture (microsoft#35175)
Co-authored-by: Anush <[email protected]>
1 parent a3aa99f commit 551b944

File tree

9 files changed

+17
-10
lines changed

9 files changed

+17
-10
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "patch",
3+
"comment": "remove default culture in v9 charts",
4+
"packageName": "@fluentui/react-charts",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

packages/charts/react-charts/library/src/components/FunnelChart/FunnelChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ export const FunnelChart: React.FunctionComponent<FunnelChartProps> = React.forw
485485
{...props.calloutProps}
486486
XValue={calloutProps?.hoverXValue as string}
487487
yCalloutValue={calloutProps?.YValue as string}
488-
culture={props.culture ?? 'en-us'}
488+
culture={props.culture}
489489
clickPosition={clickPosition}
490490
isPopoverOpen={isPopoverOpen}
491491
color={calloutProps?.color}

packages/charts/react-charts/library/src/components/GroupedVerticalBarChart/GroupedVerticalBarChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ export const GroupedVerticalBarChart: React.FC<GroupedVerticalBarChartProps> = R
336336
YValue: yCalloutValue ? yCalloutValue : dataForHoverCard,
337337
YValueHover,
338338
hoverXValue,
339-
culture: props.culture ?? 'en-us',
339+
culture: props.culture,
340340
isCartesian: true,
341341
...props.calloutProps,
342342
...getAccessibleDataObject(callOutAccessibilityData, 'text', false),

packages/charts/react-charts/library/src/components/HorizontalBarChart/HorizontalBarChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ export const HorizontalBarChart: React.FunctionComponent<HorizontalBarChartProps
458458
<ChartPopover
459459
xCalloutValue={xCalloutValue}
460460
yCalloutValue={yCalloutValue}
461-
culture={props.culture ?? 'en-us'}
461+
culture={props.culture}
462462
clickPosition={clickPosition}
463463
isPopoverOpen={isPopoverOpen}
464464
legend={legend!}

packages/charts/react-charts/library/src/components/HorizontalBarChartWithAxis/HorizontalBarChartWithAxis.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ export const HorizontalBarChartWithAxis: React.FunctionComponent<HorizontalBarCh
157157
legend={point.legend}
158158
YValue={point.yAxisCalloutData || point.y}
159159
color={color}
160-
culture={props.culture ?? 'en-us'}
160+
culture={props.culture}
161161
clickPosition={clickPosition}
162162
isPopoverOpen={isPopoverOpen}
163163
/>

packages/charts/react-charts/library/src/components/LineChart/LineChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1713,7 +1713,7 @@ export const LineChart: React.FunctionComponent<LineChartProps> = React.forwardR
17131713
clickPosition: clickPosition,
17141714
isPopoverOpen: isPopoverOpen,
17151715
isCalloutForStack: props.isCalloutForStack,
1716-
culture: props.culture ?? 'en-us',
1716+
culture: props.culture,
17171717
isCartesian: true,
17181718
customCallout: {
17191719
customizedCallout: _getCustomizedCallout() !== null ? _getCustomizedCallout()! : undefined,

packages/charts/react-charts/library/src/components/ScatterChart/ScatterChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -717,7 +717,7 @@ export const ScatterChart: React.FunctionComponent<ScatterChartProps> = React.fo
717717
clickPosition,
718718
isPopoverOpen,
719719
isCalloutForStack: true,
720-
culture: props.culture ?? 'en-us',
720+
culture: props.culture,
721721
isCartesian: true,
722722
};
723723
const tickParams = {

packages/charts/react-charts/library/src/components/VerticalBarChart/VerticalBarChart.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,7 @@ export const VerticalBarChart: React.FunctionComponent<VerticalBarChartProps> =
352352
return (
353353
<>
354354
<ChartPopover
355-
culture={props.culture ?? 'en-us'}
355+
culture={props.culture}
356356
clickPosition={clickPosition}
357357
isPopoverOpen={isPopoverOpen}
358358
legend={item.legend!}
@@ -374,7 +374,7 @@ export const VerticalBarChart: React.FunctionComponent<VerticalBarChartProps> =
374374
XValue={_props.xAxisCalloutData || (_props.x as string)}
375375
xCalloutValue={xCalloutValue}
376376
yCalloutValue={yCalloutValue}
377-
culture={props.culture ?? 'en-us'}
377+
culture={props.culture}
378378
clickPosition={clickPosition}
379379
isPopoverOpen={isPopoverOpen}
380380
legend={_props.legend!}
@@ -1198,7 +1198,7 @@ export const VerticalBarChart: React.FunctionComponent<VerticalBarChartProps> =
11981198
clickPosition: clickPosition,
11991199
isPopoverOpen: isPopoverOpen,
12001200
isCalloutForStack: _isHavingLine && (_noLegendHighlighted() || _getHighlightedLegend().length > 1),
1201-
culture: props.culture ?? 'en-us',
1201+
culture: props.culture,
12021202
isCartesian: true,
12031203
customCallout: {
12041204
customizedCallout: _getCustomizedCallout() != null ? _getCustomizedCallout()! : undefined,

packages/charts/react-charts/library/src/components/VerticalStackedBarChart/VerticalStackedBarChart.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -733,7 +733,7 @@ export const VerticalStackedBarChart: React.FunctionComponent<VerticalStackedBar
733733
function _renderCallout(props?: VSChartDataPoint): JSXElement | null {
734734
return props ? (
735735
<ChartPopover
736-
culture={props.culture ?? 'en-us'}
736+
culture={props.culture}
737737
XValue={props.xAxisCalloutData}
738738
xCalloutValue={xCalloutValue}
739739
yCalloutValue={yCalloutValue}

0 commit comments

Comments
 (0)