Merge pull request #481 from robinborst95/feature/addon-paths

Add support for translations in actual addons

Author: Mikek2252

.gitignore

@@ -36,6 +36,9 @@ build/Release
 node_modules/
 jspm_packages/
 
+# Include node modules used in tests
+!fixtures/**/node_modules
+
 # TypeScript v1 declaration files
 typings/
 

README.md

@@ -43,6 +43,26 @@ To prevent that from happening you can configure a `whitelist`, which accepts an
 array of regular expressions that will be checked when looking for unused
 translations.
 
+### `externalPaths`
+
+If your application uses translations provided by (external) addons, then those
+translations will show up as missing by default. In order to include such translations,
+you can define `externalPaths` in the configuration file as follows:
+
+```js
+export default {
+  externalPaths: ['my-addon'],
+};
+```
+
+This example will try to find translation files in `node_modules/my-addon/translations`.
+Patterns supported by [`globby`](https://www.npmjs.com/package/globby) are also
+possible here, e.g. this:
+```js
+externalPaths: ['@*/*']
+```
+will look up translations in scoped addons like `node_modules/@company/scoped-addon/translations`.
+
 ### `--fix`
 If your application has a lot of unused translations you can run the command with
 the `--fix` to remove them. Remember to double check your translations as dynamic

__snapshots__/test.js.snap

@@ -44,6 +44,22 @@ exports[`Test Fixtures emblem 1`] = `
 
 exports[`Test Fixtures emblem 2`] = `Map {}`;
 
+exports[`Test Fixtures external-addon-translations 1`] = `
+"[1/4] 🔍  Finding JS and HBS files...
+[2/4] 🔍  Searching for translations keys in JS and HBS files...
+[3/4] ⚙️   Checking for unused translations...
+[4/4] ⚙️   Checking for missing translations...
+
+ 👏  No unused translations were found!
+
+ ⚠️   Found 1 missing translations!
+
+   - other-external-addon.used-by-app-translation (used in app/templates/application.hbs)
+"
+`;
+
+exports[`Test Fixtures external-addon-translations 2`] = `Map {}`;
+
 exports[`Test Fixtures in-repo-translations 1`] = `
 "[1/4] 🔍  Finding JS and HBS files...
 [2/4] 🔍  Searching for translations keys in JS and HBS files...

fixtures/external-addon-translations/app/controllers/application.js

@@ -0,0 +1,7 @@
+import Controller from '@ember/controller';
+
+export default class ApplicationController extends Controller {
+  get foo() {
+    return this.intl.t('js-translation');
+  }
+}

fixtures/external-addon-translations/app/templates/application.hbs

@@ -0,0 +1,4 @@
+{{t "hbs-translation"}}
+{{t "external-addon.used-by-app-translation"}}
+{{t "other-external-addon.used-by-app-translation"}}
+{{t "company.scoped-addon.used-by-app-translation"}}