Skip to content

Commit 9bfe428

Browse files
committed
Fix alarmed off state incorrectly setting _is_on to True
Remove `self._is_on = True` from alarmed/off/state.py __init__. This line contradicted the IsOff mixin, which defines is_on as False. The bug caused: - KNX plugin to not send on/off commands during alarmed state toggles (both alarmed_on and alarmed_off incorrectly reported is_on=True) - Zone lights to stop toggling when alarmed - Lights to get stuck in forced_off after alarmed transitions The state now correctly inherits is_on=False from the IsOff mixin, allowing proper KNX command generation during toggle transitions. Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com>
1 parent 2adabf1 commit 9bfe428

File tree

1 file changed

+0
-1
lines changed
  • home/appliance/light/zone/state/alarmed/off

1 file changed

+0
-1
lines changed

home/appliance/light/zone/state/alarmed/off/state.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,5 @@ def __init__(self, events=None, events_disabled=None):
4949
self.alarmed_on = home.appliance.light.zone.state.alarmed.on.State
5050
self.forced_on = home.appliance.light.zone.state.forced.on.State
5151
self.forced_off = home.appliance.light.zone.state.forced.off.State
52-
self._is_on = True
5352

5453
super(State, self).__init__(events, events_disabled)

0 commit comments

Comments
 (0)