Commit ed46403
committed
Add behave hook to pre-commit and CI
Pre-commit / CI:
- Add local behave hook (language: python, all project deps listed)
- Add behave step to GitHub Actions workflow
Bug fixes in sound player state machine:
- fade_in/callable.Forced: was calling compute_new_state(state, "base", ...)
but "base" is not a registered output state for fade_in, causing a silent
KeyError and leaving the state in fade_in instead of transitioning to
forced_off. Fix: use get_new_state(state, "forced_off") for forced.Off.
- sound_player.feature: rows @1.3 and @1.45 expected off after
sleepiness.Awake from an off-with-elapsed-On setup, but the auto-inject
(elapsed.Event.Off injected on fade_in→off) means the off state always
has elapsed=Off after a fade-in cycle, so sleepiness.Awake correctly
transitions to fade_in. Update expected state to fade_in.
Fix scheduler trigger type check
- Fix scheduler trigger type comparison: change `type` from @Property to
a class variable in Trigger, state.Trigger, and protocol.Trigger so that
class-level comparisons (e.g. Trigger.type == "APPLIANCE STATE") work
correctly; this fixes 5 failing unit tests where _schedule_by_trigger_fork
was never called
Improve documentation: replace sphinx-gherkindoc, add docs target, fix English
- Replace broken sphinx-gherkindoc (incompatible with Sphinx 9) with a
lightweight custom script docs/gherkindoc.py that converts .feature files
to RST code-block pages using only the Python standard library
- Update docs/Makefile to use the new script via the PYTHON variable
- Fix numerous English issues across all RST documentation files and README:
Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 7fd922e commit ed46403
File tree
51 files changed
+6856
-5949
lines changed- .github/workflows
- docs
- source
- appliance
- features
- home
- appliance/sound/player/state/fade_in
- features
- scheduler/trigger
- date
- protocol
- state
- entering
- delay
- exiting
- tests
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
51 files changed
+6856
-5949
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
31 | 35 | | |
32 | 36 | | |
33 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
0 commit comments