Skip to content

Commit 550d552

Browse files
majorimimajorimi
committed
Fixed unit tests and XML commits.
1 parent 03a75e2 commit 550d552

File tree

3 files changed

+36
-25
lines changed

3 files changed

+36
-25
lines changed

‎src/Majorsoft.Blazor.Components.Collapse.Tests/CollapsePanelTest.cs‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public void CollapsePanel_should_rendered_correctly_html_attributes()
2727
var id = div.FirstElementChild.GetAttribute("id");
2828
div.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" title=""text"" >
2929
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);"" ></div>
30-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 200px;"" ></div>
30+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" ></div>
3131
</div>");
3232
}
3333

@@ -43,7 +43,7 @@ public void CollapsePanel_should_rendered_correctly_Disabled()
4343
var id = div.GetAttribute("id");
4444
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" disabled="""" >
4545
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);"" ></div>
46-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 200px;"" ></div>
46+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" ></div>
4747
</div>");
4848
}
4949

@@ -61,13 +61,13 @@ public void CollapsePanel_should_rendered_correctly_CommonHeader()
6161
var id = div.GetAttribute("id");
6262
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
6363
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);"">Common header</div>
64-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 200px;"" ></div>
64+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" ></div>
6565
</div>");
6666

6767
div.Click();
6868
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
6969
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);"">Common header</div>
70-
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; height: 0px;"" ></div>
70+
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; max-height: 0px;"" ></div>
7171
</div>");
7272
}
7373

@@ -83,13 +83,13 @@ public void CollapsePanel_should_rendered_correctly_ExpandedHeaderContent()
8383
var id = div.GetAttribute("id");
8484
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
8585
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);"">Expanded header</div>
86-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 200px;"" ></div>
86+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" ></div>
8787
</div>");
8888

8989
div.Click();
9090
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
9191
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);""></div>
92-
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; height: 0px;"" ></div>
92+
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; max-height: 0px;"" ></div>
9393
</div>");
9494
}
9595

@@ -105,13 +105,13 @@ public void CollapsePanel_should_rendered_correctly_CollapsedHeaderContent()
105105
var id = div.GetAttribute("id");
106106
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
107107
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);""></div>
108-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 200px;"" ></div>
108+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" ></div>
109109
</div>");
110110

111111
div.Click();
112112
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
113113
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);"">Collapsed header</div>
114-
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; height: 0px;"" ></div>
114+
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; max-height: 0px;"" ></div>
115115
</div>");
116116
}
117117

@@ -128,13 +128,13 @@ public void CollapsePanel_should_rendered_correctly_ExpandedColor()
128128
var id = div.GetAttribute("id");
129129
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
130130
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(255,0,0);"">Expanded header</div>
131-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 200px;"" ></div>
131+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" ></div>
132132
</div>");
133133

134134
div.Click();
135135
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
136136
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);""></div>
137-
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; height: 0px;"" ></div>
137+
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; max-height: 0px;"" ></div>
138138
</div>");
139139
}
140140

@@ -151,13 +151,13 @@ public void CollapsePanel_should_rendered_correctly_CollapsedColor()
151151
var id = div.GetAttribute("id");
152152
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
153153
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);""></div>
154-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 200px;"" ></div>
154+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" ></div>
155155
</div>");
156156

157157
div.Click();
158158
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
159159
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(255,0,0);"">Collapsed header</div>
160-
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; height: 0px;"" ></div>
160+
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; max-height: 0px;"" ></div>
161161
</div>");
162162
}
163163

@@ -173,27 +173,27 @@ public async Task CollapsePanel_should_rendered_correctly_HoverColor()
173173
var id = div.GetAttribute("id");
174174
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
175175
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);""></div>
176-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 200px;"" ></div>
176+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" ></div>
177177
</div>");
178178

179179
await div.TriggerEventAsync("onmouseenter", new MouseEventArgs());
180180
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
181181
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(255,0,0);""></div>
182-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 200px;"" ></div>
182+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" ></div>
183183
</div>");
184184
await div.TriggerEventAsync("onmouseleave", new MouseEventArgs());
185185

186186

187187
div.Click();
188188
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
189189
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);""></div>
190-
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; height: 0px;"" ></div>
190+
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; max-height: 0px;"" ></div>
191191
</div>");
192192

193193
await div.TriggerEventAsync("onmouseenter", new MouseEventArgs());
194194
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
195195
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(255,0,0);""></div>
196-
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; height: 0px;"" ></div>
196+
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; max-height: 0px;"" ></div>
197197
</div>");
198198
}
199199

@@ -211,14 +211,14 @@ public void CollapsePanel_should_rendered_correctly_Content()
211211
var id = div.GetAttribute("id");
212212
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
213213
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);"">Expanded header</div>
214-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 200px;"" >Content...</div>
214+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" >Content...</div>
215215
</div>");
216216

217217
rendered.SetParametersAndRender(parameters => parameters
218218
.Add(p => p.Collapsed, true));
219219
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
220220
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);"">Collapsed header</div>
221-
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; height: 0px;"" >Content...</div>
221+
<div class=""collapseContent animate"" style=""opacity: 0; overflow: hidden; max-height: 0px;"" >Content...</div>
222222
</div>");
223223
}
224224

@@ -234,7 +234,7 @@ public void CollapsePanel_should_rendered_correctly_ContentHeight()
234234
var id = div.GetAttribute("id");
235235
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
236236
<div id=""{id}"" class=""collapseHeader animate"" style=""background-color: rgb(211,211,211);"" ></div>
237-
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; height: 55px;"" ></div>
237+
<div class=""collapseContent animate"" style=""opacity: 1; overflow: hidden; max-height: 55px;"" ></div>
238238
</div>");
239239
}
240240

@@ -250,7 +250,7 @@ public void CollapsePanel_should_rendered_correctly_Animate()
250250
var id = div.GetAttribute("id");
251251
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
252252
<div id=""{id}"" class=""collapseHeader"" style=""background-color: rgb(211,211,211);"" ></div>
253-
<div class=""collapseContent"" style=""opacity: 1; overflow: hidden; height: 200px;"" ></div>
253+
<div class=""collapseContent"" style=""opacity: 1; overflow: hidden; max-height: 200px;"" ></div>
254254
</div>");
255255
}
256256

@@ -267,7 +267,7 @@ public void CollapsePanel_should_rendered_correctly_ShowContentOverflow()
267267
var id = div.GetAttribute("id");
268268
rendered.MarkupMatches(@$"<div class=""collapsePanel"" tabindex=""200"" >
269269
<div id=""{id}"" class=""collapseHeader"" style=""background-color: rgb(211,211,211);"" ></div>
270-
<div class=""collapseContent"" style=""opacity: 1; overflow: auto; height: 200px;"" ></div>
270+
<div class=""collapseContent"" style=""opacity: 1; overflow: auto; max-height: 200px;"" ></div>
271271
</div>");
272272
}
273273
}

‎src/Majorsoft.Blazor.Components.Collapse/CollapsePanel.razor‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@
8888
[Parameter] public int ContentHeight { get; set; } = 200;
8989

9090
/// <summary>
91-
/// Sets the max-height if Content panel <see href="ContentHeight"> is set to 0 (auto).
91+
/// Sets the max-height if Content panel <see cref="ContentHeight"/> is set to 0 (auto).
9292
/// https://css-tricks.com/using-css-transitions-auto-dimensions/
9393
/// </summary>
9494
[Parameter] public int MaxAllowedContentHeight { get; set; } = 200;
@@ -120,7 +120,7 @@
120120

121121
/// <summary>
122122
/// Determines to apply CSS animation and transition on Collapse state changes or not.
123-
/// Note: in case of Content panel <see href="ContentHeight"> is set to 0 (auto), then use <see href="MaxAllowedContentHeight"> to set max-height CSS property which will be animated.
123+
/// Note: in case of Content panel <see cref="ContentHeight"/> is set to 0 (auto), then use <see cref="MaxAllowedContentHeight"/> to set max-height CSS property which will be animated.
124124
/// Also important based on max-height value transition speed for expand/collapse might differ!
125125
/// </summary>
126126
[Parameter] public bool Animate { get; set; } = true;

‎src/Majorsoft.Blazor.Components.Collapse/Majorsoft.Blazor.Components.Collapse.xml‎

Lines changed: 13 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)