Merge pull request #18 from majusko/feature/issue-12-configurable-delimiter

resolves #12

Author: majusko

README.md

@@ -91,6 +91,7 @@ pulsar.connectionTimeoutSec=10
 pulsar.operationTimeoutSec=15
 pulsar.startingBackoffIntervalMs=100
 pulsar.maxBackoffIntervalSec=10
+pulsar.consumerNameDelimiter=
 ```
 
 Properties explained:
@@ -104,6 +105,7 @@ Properties explained:
 - `pulsar.operationTimeoutSec` - Operation timeout.
 - `pulsar.startingBackoffIntervalMs` - Duration of time for a backoff interval (Retry algorithm).
 - `pulsar.maxBackoffIntervalSec` - The maximum duration of time for a backoff interval (Retry algorithm).
+- `pulsar.consumerNameDelimiter` - Consumer names are connection of bean name and method with a delimiter. By default there is no delimiter and words are connected together.
 
 ## Contributing
 

src/main/java/io/github/majusko/pulsar/PulsarProperties.java

@@ -13,6 +13,7 @@ public class PulsarProperties {
     private Integer operationTimeoutSec = 15;
     private Integer startingBackoffIntervalMs = 100;
     private Integer maxBackoffIntervalSec = 10;
+    private String consumerNameDelimiter = "";
 
     public String getServiceUrl() {
         return serviceUrl;
@@ -85,4 +86,12 @@ public Integer getMaxBackoffIntervalSec() {
     public void setMaxBackoffIntervalSec(Integer maxBackoffIntervalSec) {
         this.maxBackoffIntervalSec = maxBackoffIntervalSec;
     }
+
+    public String getConsumerNameDelimiter() {
+        return consumerNameDelimiter;
+    }
+
+    public void setConsumerNameDelimiter(String consumerNameDelimiter) {
+        this.consumerNameDelimiter = consumerNameDelimiter;
+    }
 }

src/main/java/io/github/majusko/pulsar/collector/ConsumerCollector.java

@@ -1,9 +1,9 @@
 package io.github.majusko.pulsar.collector;
 
 import io.github.majusko.pulsar.annotation.PulsarConsumer;
+import org.springframework.beans.factory.annotation.Value;
 import org.springframework.beans.factory.config.BeanPostProcessor;
 import org.springframework.context.annotation.Configuration;
-import org.springframework.stereotype.Component;
 
 import java.util.Arrays;
 import java.util.Map;
@@ -14,6 +14,9 @@
 @Configuration
 public class ConsumerCollector implements BeanPostProcessor {
 
+    @Value("${pulsar.consumerNameDelimiter:}")
+    private String consumerNameDelimiter;
+
     private Map<String, ConsumerHolder> consumers = new ConcurrentHashMap<>();
 
     @Override
@@ -23,7 +26,7 @@ public Object postProcessBeforeInitialization(Object bean, String beanName) {
         consumers.putAll(Arrays.stream(beanClass.getDeclaredMethods())
             .filter($ -> $.isAnnotationPresent(PulsarConsumer.class))
             .collect(Collectors.toMap(
-                method -> beanClass.getName() + "#" + method.getName(),
+                method -> beanClass.getName() + consumerNameDelimiter + method.getName(),
                 method -> new ConsumerHolder(method.getAnnotation(PulsarConsumer.class), method, bean))));
 
         return bean;

src/test/java/io/github/majusko/pulsar/PulsarJavaSpringBootStarterApplicationTests.java

@@ -6,20 +6,14 @@
 import io.github.majusko.pulsar.consumer.ConsumerBuilder;
 import io.github.majusko.pulsar.producer.ProducerFactory;
 import io.github.majusko.pulsar.producer.PulsarTemplate;
+import org.apache.commons.lang3.tuple.ImmutablePair;
 import org.apache.pulsar.client.api.Consumer;
 import org.apache.pulsar.client.api.PulsarClientException;
-import org.apache.commons.lang3.tuple.ImmutablePair;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
-import org.junit.jupiter.api.extension.ExtendWith;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
 import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.context.annotation.ComponentScan;
-import org.springframework.context.annotation.FilterType;
 import org.springframework.context.annotation.Import;
-import org.springframework.test.context.ContextConfiguration;
-import org.springframework.test.context.junit.jupiter.SpringExtension;
 
 import java.util.HashSet;
 import java.util.List;
@@ -62,7 +56,7 @@ void testConsumerRegistration1() throws Exception {
     @Test
     void testConsumerRegistration2() {
         final Class<TestConsumerConfiguration> clazz = TestConsumerConfiguration.class;
-        final String descriptor = clazz.getName() + "#" + clazz.getMethods()[0].getName();
+        final String descriptor = clazz.getName() + clazz.getMethods()[0].getName();
         final ConsumerHolder consumerHolder = consumerCollector.getConsumer(descriptor).orElse(null);
 
         Assertions.assertNotNull(consumerHolder);