Skip to content

Commit e9ef8f4

Browse files
authored
Merge pull request #8 from majusko/hotfix/adding-test-coverage
Hotfix/adding test coverage
2 parents a389dcf + 4d55256 commit e9ef8f4

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

src/main/java/io/github/majusko/pulsar/collector/ConsumerCollector.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
import io.github.majusko.pulsar.annotation.PulsarConsumer;
44
import org.springframework.beans.factory.config.BeanPostProcessor;
5+
import org.springframework.context.annotation.Configuration;
56
import org.springframework.stereotype.Component;
67

78
import java.util.Arrays;
@@ -10,7 +11,7 @@
1011
import java.util.concurrent.ConcurrentHashMap;
1112
import java.util.stream.Collectors;
1213

13-
@Component
14+
@Configuration
1415
public class ConsumerCollector implements BeanPostProcessor {
1516

1617
private Map<String, ConsumerHolder> consumers = new ConcurrentHashMap<>();
@@ -25,6 +26,8 @@ public Object postProcessBeforeInitialization(Object bean, String beanName) {
2526
method -> beanClass.getName() + "#" + method.getName(),
2627
method -> new ConsumerHolder(method.getAnnotation(PulsarConsumer.class), method, bean))));
2728

29+
System.out.println(consumers.toString());
30+
2831
return bean;
2932
}
3033

src/test/java/io/github/majusko/pulsar/PulsarJavaSpringBootStarterApplicationTests.java

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package io.github.majusko.pulsar;
22

33
import io.github.majusko.pulsar.collector.ConsumerCollector;
4+
import io.github.majusko.pulsar.collector.ConsumerHolder;
45
import io.github.majusko.pulsar.constant.Serialization;
56
import io.github.majusko.pulsar.consumer.ConsumerBuilder;
67
import io.github.majusko.pulsar.producer.ProducerFactory;
@@ -26,7 +27,7 @@
2627
import java.util.Set;
2728

2829
@SpringBootTest
29-
@Import(TestProducerConfiguration.class)
30+
@Import({TestProducerConfiguration.class, TestConsumerConfiguration.class})
3031
class PulsarJavaSpringBootStarterApplicationTests {
3132

3233
@Autowired
@@ -58,17 +59,17 @@ void testConsumerRegistration1() throws Exception {
5859
Assertions.assertEquals("mock-topic", consumer.getTopic());
5960
}
6061

61-
// @Test
62-
// void testConsumerRegistration2() throws Exception {
63-
// final Class<TestConsumerConfiguration> clazz = TestConsumerConfiguration.class;
64-
// final String descriptor = clazz.getName() + "#" + clazz.getDeclaredMethods()[0].getName();
65-
// final ConsumerHolder consumerHolder = consumerCollector.getConsumer(descriptor).orElseThrow(Exception::new);
66-
//
67-
// Assert.assertNotNull(consumerHolder);
68-
// Assert.assertEquals("mock-topic", consumerHolder.getAnnotation().topic());
69-
// Assert.assertEquals(TestConsumerConfiguration.class, consumerHolder.getBean().getClass());
70-
// Assert.assertEquals("mockTheListener", consumerHolder.getHandler().getName());
71-
// }
62+
@Test
63+
void testConsumerRegistration2() {
64+
final Class<TestConsumerConfiguration> clazz = TestConsumerConfiguration.class;
65+
final String descriptor = clazz.getName() + "#" + clazz.getMethods()[0].getName();
66+
final ConsumerHolder consumerHolder = consumerCollector.getConsumer(descriptor).orElse(null);
67+
68+
Assertions.assertNotNull(consumerHolder);
69+
Assertions.assertEquals("mock-topic", consumerHolder.getAnnotation().topic());
70+
Assertions.assertEquals(TestConsumerConfiguration.class, consumerHolder.getBean().getClass());
71+
Assertions.assertEquals("mockTheListener", consumerHolder.getHandler().getName());
72+
}
7273

7374
@Test
7475
void testProducerRegistration() {

0 commit comments

Comments
 (0)