Commit d03520b
committed
refactor(s11d/rope): Address PR FoxdieTeam#2135 review feedback
Implement changes requested by reviewer KieronJ:
- Remove 9 compiler-inserted division overflow checks (div_result == -1)
These checks are automatically inserted by PSY-Q compiler for MIPS
division overflow handling and should not be manually added in source
- Remove duplicate extern declarations:
* data_800C32B4, data_800C32B8 (were declared twice)
- Fix typo in function name: func_8001511C8 -> func_800151C8
- Remove unused declaration: func_8003152948 (not referenced in rope.c)
These changes improve code quality without affecting binary matching.
Build verification will be performed by CI on Windows/Linux platforms.
Addresses: PR FoxdieTeam#2135 review comments1 parent 65398fa commit d03520b
2 files changed
+3
-54
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4868 | 4868 | | |
4869 | 4869 | | |
4870 | 4870 | | |
4871 | | - | |
4872 | | - | |
4873 | | - | |
4874 | | - | |
4875 | | - | |
4876 | 4871 | | |
4877 | 4872 | | |
4878 | 4873 | | |
| |||
4925 | 4920 | | |
4926 | 4921 | | |
4927 | 4922 | | |
4928 | | - | |
4929 | | - | |
4930 | | - | |
4931 | | - | |
4932 | | - | |
4933 | 4923 | | |
4934 | 4924 | | |
4935 | 4925 | | |
| |||
4977 | 4967 | | |
4978 | 4968 | | |
4979 | 4969 | | |
4980 | | - | |
4981 | | - | |
4982 | | - | |
4983 | | - | |
4984 | | - | |
4985 | 4970 | | |
4986 | 4971 | | |
4987 | 4972 | | |
| |||
5097 | 5082 | | |
5098 | 5083 | | |
5099 | 5084 | | |
5100 | | - | |
5101 | | - | |
5102 | | - | |
5103 | | - | |
5104 | | - | |
5105 | 5085 | | |
5106 | 5086 | | |
5107 | 5087 | | |
| |||
5154 | 5134 | | |
5155 | 5135 | | |
5156 | 5136 | | |
5157 | | - | |
5158 | | - | |
5159 | | - | |
5160 | | - | |
5161 | | - | |
5162 | 5137 | | |
5163 | 5138 | | |
5164 | 5139 | | |
| |||
5206 | 5181 | | |
5207 | 5182 | | |
5208 | 5183 | | |
5209 | | - | |
5210 | | - | |
5211 | | - | |
5212 | | - | |
5213 | | - | |
5214 | 5184 | | |
5215 | 5185 | | |
5216 | 5186 | | |
| |||
5325 | 5295 | | |
5326 | 5296 | | |
5327 | 5297 | | |
5328 | | - | |
5329 | | - | |
5330 | | - | |
5331 | | - | |
5332 | | - | |
5333 | 5298 | | |
5334 | 5299 | | |
5335 | 5300 | | |
| |||
5378 | 5343 | | |
5379 | 5344 | | |
5380 | 5345 | | |
5381 | | - | |
5382 | | - | |
5383 | | - | |
5384 | | - | |
5385 | | - | |
5386 | 5346 | | |
5387 | 5347 | | |
5388 | 5348 | | |
| |||
5430 | 5390 | | |
5431 | 5391 | | |
5432 | 5392 | | |
5433 | | - | |
5434 | | - | |
5435 | | - | |
5436 | | - | |
5437 | | - | |
5438 | 5393 | | |
5439 | 5394 | | |
5440 | 5395 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | 16 | | |
24 | 17 | | |
25 | 18 | | |
| 19 | + | |
| 20 | + | |
26 | 21 | | |
27 | 22 | | |
28 | 23 | | |
| |||
33 | 28 | | |
34 | 29 | | |
35 | 30 | | |
36 | | - | |
37 | 31 | | |
38 | 32 | | |
39 | 33 | | |
| |||
57 | 51 | | |
58 | 52 | | |
59 | 53 | | |
60 | | - | |
| 54 | + | |
61 | 55 | | |
62 | 56 | | |
63 | 57 | | |
| |||
0 commit comments