add unit test

Author: makara4code

.claude/settings.local.json

@@ -23,7 +23,8 @@
       "Bash(npm run build:*)",
       "Bash(uv add:*)",
       "Bash(dir:*)",
-      "Bash(mkdir:*)"
+      "Bash(mkdir:*)",
+      "Bash(uv run pytest:*)"
     ],
     "deny": [],
     "ask": []

backend/app/crud.py

@@ -0,0 +1,50 @@
+# Backwards compatibility layer for tests
+# CRUD operations are now in app/modules/*/repository.py
+
+import uuid
+from typing import Any
+
+from sqlmodel import Session
+
+from app.modules.users.repository import UserRepository
+from app.modules.users.models import User
+from app.modules.users.schemas import UserCreate, UserCreateOAuth, UserUpdate
+from app.modules.items.repository import ItemRepository
+from app.modules.items.models import Item
+from app.modules.items.schemas import ItemCreate
+
+
+def create_user(*, session: Session, user_create: UserCreate) -> User:
+    """Create a new user with password."""
+    repo = UserRepository(session)
+    return repo.create(user_create)
+
+
+def create_user_oauth(*, session: Session, user_create: UserCreateOAuth) -> User:
+    """Create a new user via OAuth."""
+    repo = UserRepository(session)
+    return repo.create_oauth(user_create)
+
+
+def update_user(*, session: Session, db_user: User, user_in: UserUpdate) -> Any:
+    """Update an existing user."""
+    repo = UserRepository(session)
+    return repo.update(db_user, user_in)
+
+
+def get_user_by_email(*, session: Session, email: str) -> User | None:
+    """Get user by email."""
+    repo = UserRepository(session)
+    return repo.get_by_email(email)
+
+
+def authenticate(*, session: Session, email: str, password: str) -> User | None:
+    """Authenticate user by email and password."""
+    repo = UserRepository(session)
+    return repo.authenticate(email, password)
+
+
+def create_item(*, session: Session, item_in: ItemCreate, owner_id: uuid.UUID) -> Item:
+    """Create a new item."""
+    repo = ItemRepository(session)
+    return repo.create(item_in, owner_id)

backend/app/models.py

@@ -0,0 +1,33 @@
+# Re-export models for backwards compatibility with tests
+# Models are now organized in app/modules/*/models.py
+
+from app.modules.users.models import User
+from app.modules.users.schemas import (
+    UserCreate,
+    UserPublic,
+    UserRegister,
+    UserUpdate,
+    UserUpdateMe,
+    UpdatePassword,
+)
+from app.modules.items.models import Item
+from app.modules.items.schemas import ItemCreate, ItemPublic, ItemUpdate
+from app.modules.shortener.models import ShortUrl
+
+__all__ = [
+    # Users
+    "User",
+    "UserCreate",
+    "UserPublic",
+    "UserRegister",
+    "UserUpdate",
+    "UserUpdateMe",
+    "UpdatePassword",
+    # Items
+    "Item",
+    "ItemCreate",
+    "ItemPublic",
+    "ItemUpdate",
+    # Shortener
+    "ShortUrl",
+]

backend/tests/api/routes/test_redirect.py

@@ -0,0 +1,122 @@
+from fastapi.testclient import TestClient
+from sqlmodel import Session
+
+from app.modules.shortener.schemas import ShortUrlCreate, ShortUrlUpdate
+from app.modules.shortener.service import ShortUrlService
+from tests.utils.shortener import create_random_short_url
+from tests.utils.utils import random_lower_string
+
+
+def test_redirect_to_url_success(client: TestClient, db: Session) -> None:
+    """Test successful redirect to original URL."""
+    short_url = create_random_short_url(db)
+
+    response = client.get(
+        f"/s/{short_url.short_code}",
+        follow_redirects=False,
+    )
+    assert response.status_code == 307
+    assert response.headers["location"] == short_url.original_url
+
+
+def test_redirect_not_found(client: TestClient) -> None:
+    """Test redirect returns 404 for non-existent short code."""
+    response = client.get(
+        f"/s/nonexistent{random_lower_string()[:6]}",
+        follow_redirects=False,
+    )
+    assert response.status_code == 404
+    # Should return HTML error page
+    assert "Link Not Found" in response.text
+
+
+def test_redirect_inactive_url(client: TestClient, db: Session) -> None:
+    """Test redirect returns 410 for deactivated short URL."""
+    short_url = create_random_short_url(db)
+
+    # Deactivate the short URL
+    service = ShortUrlService(db)
+    service.repository.update(
+        db_short_url=short_url,
+        short_url_in=ShortUrlUpdate(is_active=False),
+    )
+
+    response = client.get(
+        f"/s/{short_url.short_code}",
+        follow_redirects=False,
+    )
+    assert response.status_code == 410
+    # Should return HTML error page
+    assert "Link Deactivated" in response.text
+
+
+def test_redirect_increments_click_count(client: TestClient, db: Session) -> None:
+    """Test that redirect increments the click count."""
+    short_url = create_random_short_url(db)
+    initial_count = short_url.click_count
+
+    # Make a redirect request
+    response = client.get(
+        f"/s/{short_url.short_code}",
+        follow_redirects=False,
+    )
+    assert response.status_code == 307
+
+    # Refresh and check click count
+    db.refresh(short_url)
+    assert short_url.click_count == initial_count + 1
+
+
+def test_redirect_multiple_clicks(client: TestClient, db: Session) -> None:
+    """Test that multiple redirects properly increment click count."""
+    short_url = create_random_short_url(db)
+    initial_count = short_url.click_count
+
+    # Make multiple redirect requests
+    for i in range(3):
+        response = client.get(
+            f"/s/{short_url.short_code}",
+            follow_redirects=False,
+        )
+        assert response.status_code == 307
+
+    # Refresh and check click count
+    db.refresh(short_url)
+    assert short_url.click_count == initial_count + 3
+
+
+def test_redirect_no_cache_headers(client: TestClient, db: Session) -> None:
+    """Test that redirect response includes no-cache headers."""
+    short_url = create_random_short_url(db)
+
+    response = client.get(
+        f"/s/{short_url.short_code}",
+        follow_redirects=False,
+    )
+    assert response.status_code == 307
+    assert "no-store" in response.headers.get("cache-control", "")
+    assert response.headers.get("pragma") == "no-cache"
+
+
+def test_redirect_inactive_no_click_increment(client: TestClient, db: Session) -> None:
+    """Test that inactive URLs don't increment click count."""
+    short_url = create_random_short_url(db)
+    initial_count = short_url.click_count
+
+    # Deactivate the short URL
+    service = ShortUrlService(db)
+    service.repository.update(
+        db_short_url=short_url,
+        short_url_in=ShortUrlUpdate(is_active=False),
+    )
+
+    # Try to access
+    response = client.get(
+        f"/s/{short_url.short_code}",
+        follow_redirects=False,
+    )
+    assert response.status_code == 410
+
+    # Click count should not have changed
+    db.refresh(short_url)
+    assert short_url.click_count == initial_count