Skip to content

Commit 0370a1b

Browse files
chore: fix/check tooling improvements with turbo (#8304)
1 parent 5e621cf commit 0370a1b

File tree

20 files changed

+217
-621
lines changed

20 files changed

+217
-621
lines changed

apps/admin/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
"preview": "react-router build && serve -s build/client -l 3001",
1212
"start": "serve -s build/client -l 3001",
1313
"clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist && rm -rf build",
14-
"check:lint": "eslint . --max-warnings=485",
14+
"check:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --max-warnings=485",
1515
"check:types": "react-router typegen && tsc --noEmit",
16-
"check:format": "prettier --check .",
17-
"fix:lint": "eslint . --fix --max-warnings=485",
18-
"fix:format": "prettier --write ."
16+
"check:format": "prettier . --cache --check",
17+
"fix:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --fix --max-warnings=485",
18+
"fix:format": "prettier . --cache --write"
1919
},
2020
"dependencies": {
2121
"@bprogress/core": "catalog:",

apps/live/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
"build": "tsc --noEmit && tsdown",
1616
"dev": "tsdown --watch --onSuccess \"node --env-file=.env .\"",
1717
"start": "node --env-file=.env .",
18-
"check:lint": "eslint . --max-warnings=160",
18+
"check:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --max-warnings=160",
1919
"check:types": "tsc --noEmit",
20-
"check:format": "prettier --check .",
21-
"fix:lint": "eslint . --fix --max-warnings=160",
22-
"fix:format": "prettier --write .",
20+
"check:format": "prettier . --cache --check",
21+
"fix:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --fix --max-warnings=160",
22+
"fix:format": "prettier . --cache --write",
2323
"clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist"
2424
},
2525
"author": "Plane Software Inc.",

apps/space/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
"preview": "react-router build && PORT=3002 react-router-serve ./build/server/index.js",
1111
"start": "PORT=3002 react-router-serve ./build/server/index.js",
1212
"clean": "rm -rf .turbo && rm -rf .next && rm -rf .react-router && rm -rf node_modules && rm -rf dist && rm -rf build",
13-
"check:lint": "eslint . --max-warnings=932",
13+
"check:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --max-warnings=932",
1414
"check:types": "react-router typegen && tsc --noEmit",
15-
"check:format": "prettier --check .",
16-
"fix:lint": "eslint . --fix --max-warnings=932",
17-
"fix:format": "prettier --write ."
15+
"check:format": "prettier . --cache --check",
16+
"fix:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --fix --max-warnings=932",
17+
"fix:format": "prettier . --cache --write"
1818
},
1919
"dependencies": {
2020
"@bprogress/core": "catalog:",

apps/web/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@
1010
"preview": "react-router build && serve -s build/client -l 3000",
1111
"start": "serve -s build/client -l 3000",
1212
"clean": "rm -rf .turbo && rm -rf .next && rm -rf .react-router && rm -rf node_modules && rm -rf dist && rm -rf build",
13-
"check:lint": "eslint . --max-warnings=14367",
13+
"check:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --max-warnings=14367",
1414
"check:types": "react-router typegen && tsc --noEmit",
15-
"check:format": "prettier --check .",
16-
"fix:lint": "eslint . --fix --max-warnings=14367",
17-
"fix:format": "prettier --write ."
15+
"check:format": "prettier . --cache --check",
16+
"fix:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --fix --max-warnings=14367",
17+
"fix:format": "prettier . --cache --write"
1818
},
1919
"dependencies": {
2020
"@atlaskit/pragmatic-drag-and-drop": "catalog:",

eslint.config.mjs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,6 @@ export default defineConfig([
100100
"@typescript-eslint/restrict-plus-operands": "warn",
101101
"@typescript-eslint/restrict-template-expressions": "warn",
102102
"@typescript-eslint/unbound-method": "warn",
103-
"import/consistent-type-specifier-style": ["error", "prefer-top-level"],
104103
"jsdoc/require-jsdoc": "off",
105104
"jsx-a11y/alt-text": "warn",
106105
"jsx-a11y/anchor-is-valid": "warn",
@@ -136,7 +135,10 @@ export default defineConfig([
136135
"react-hooks/rules-of-hooks": "warn",
137136
"react-hooks/set-state-in-effect": "warn",
138137
"react-hooks/static-components": "warn",
139-
"react-refresh/only-export-components": "warn",
138+
"react-refresh/only-export-components": [
139+
"warn",
140+
{ allowExportNames: ["meta", "links", "headers", "loader", "action"] },
141+
],
140142
"react/display-name": "warn",
141143
"react/jsx-no-target-blank": "warn",
142144
"react/no-unknown-property": "warn",
@@ -158,6 +160,7 @@ export default defineConfig([
158160
"import/internal-regex": "^@plane/",
159161
},
160162
rules: {
163+
"import/consistent-type-specifier-style": ["error", "prefer-top-level"],
161164
"import/no-unresolved": ["error", { ignore: ["next/link", "next/navigation", "next/script"] }],
162165
},
163166
},

packages/constants/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77
"scripts": {
88
"dev": "tsdown --watch",
99
"build": "tsdown",
10-
"check:lint": "eslint . --max-warnings=30",
10+
"check:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --max-warnings=30",
1111
"check:types": "tsc --noEmit",
12-
"check:format": "prettier --check .",
13-
"fix:lint": "eslint . --fix --max-warnings=30",
14-
"fix:format": "prettier --write .",
12+
"check:format": "prettier . --cache --check",
13+
"fix:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --fix --max-warnings=30",
14+
"fix:format": "prettier . --cache --write",
1515
"clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist"
1616
},
1717
"dependencies": {

packages/decorators/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@
1212
"scripts": {
1313
"build": "tsdown",
1414
"dev": "tsdown --watch",
15-
"check:lint": "eslint . --max-warnings=29",
15+
"check:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --max-warnings=29",
1616
"check:types": "tsc --noEmit",
17-
"check:format": "prettier --check .",
18-
"fix:lint": "eslint . --fix --max-warnings=29",
19-
"fix:format": "prettier --write .",
17+
"check:format": "prettier . --cache --check",
18+
"fix:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --fix --max-warnings=29",
19+
"fix:format": "prettier . --cache --write",
2020
"clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist"
2121
},
2222
"devDependencies": {

packages/editor/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818
"scripts": {
1919
"build": "tsc && tsdown",
2020
"dev": "tsdown --watch",
21-
"check:lint": "eslint . --max-warnings=1435",
21+
"check:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --max-warnings=1435",
2222
"check:types": "tsc --noEmit",
23-
"check:format": "prettier --check .",
24-
"fix:lint": "eslint . --fix --max-warnings=1435",
25-
"fix:format": "prettier --write .",
23+
"check:format": "prettier . --cache --check",
24+
"fix:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --fix --max-warnings=1435",
25+
"fix:format": "prettier . --cache --write",
2626
"clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist"
2727
},
2828
"peerDependencies": {

packages/editor/src/core/hooks/use-yjs-setup.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ export const useYjsSetup = ({ docId, serverUrl, authToken, onStateChange }: UseY
187187

188188
provider.on("close", handleClose);
189189

190-
setYjsSession({ provider, ydoc: provider.document as Y.Doc });
190+
setYjsSession({ provider, ydoc: provider.document });
191191

192192
// Handle page visibility changes (sleep/wake, tab switching)
193193
const handleVisibilityChange = (event?: Event) => {

packages/hooks/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515
"scripts": {
1616
"build": "tsdown",
1717
"dev": "tsdown --watch",
18-
"check:lint": "eslint . --max-warnings=60",
18+
"check:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --max-warnings=60",
1919
"check:types": "tsc --noEmit",
20-
"check:format": "prettier --check .",
21-
"fix:lint": "eslint . --fix --max-warnings=60",
22-
"fix:format": "prettier --write .",
20+
"check:format": "prettier . --cache --check",
21+
"fix:lint": "eslint . --cache --cache-location node_modules/.cache/eslint/ --fix --max-warnings=60",
22+
"fix:format": "prettier . --cache --write",
2323
"clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist"
2424
},
2525
"dependencies": {

0 commit comments

Comments
 (0)