Skip to content

Commit 1f89fcd

Browse files
fix: update event tracking to use created_at from response in cycle and issue creation, and reorganize imports in workspace components
1 parent 9941459 commit 1f89fcd

File tree

5 files changed

+19
-18
lines changed

5 files changed

+19
-18
lines changed

apps/web/core/components/cycles/modal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export function CycleCreateUpdateModal(props: CycleModalProps) {
7272
if (currentWorkspace && currentUser) {
7373
const role = getWorkspaceRoleByWorkspaceSlug(currentWorkspace.slug);
7474
trackCycleCreated(
75-
{ id: res.id, created_at: new Date().toISOString() },
75+
{ id: res.id, created_at: res?.created_at ?? "" },
7676
{ id: projectId },
7777
currentWorkspace,
7878
currentUser,

apps/web/core/components/issues/issue-layouts/quick-add/root.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { setPromiseToast } from "@plane/propel/toast";
1212
import type { IProject, TIssue, EIssueLayoutTypes } from "@plane/types";
1313
import { cn, createIssuePayload } from "@plane/utils";
1414
// helpers
15-
import { captureError, captureSuccess } from "@/helpers/event-tracker.helper";
15+
import { captureError } from "@/helpers/event-tracker.helper";
1616
// plane web imports
1717
import { QuickAddIssueFormRoot } from "@/plane-web/components/issues/quick-add";
1818
// local imports
@@ -142,7 +142,7 @@ export const QuickAddIssueRoot = observer(function QuickAddIssueRoot(props: TQui
142142
if (currentWorkspace && currentUser && quickAddRes) {
143143
const role = getWorkspaceRoleByWorkspaceSlug(currentWorkspace.slug);
144144
trackWorkItemCreated(
145-
{ id: quickAddRes.id, created_at: new Date().toISOString() },
145+
{ id: quickAddRes.id, created_at: quickAddRes.created_at ?? "" },
146146
{ id: projectId.toString() },
147147
currentWorkspace,
148148
currentUser,

apps/web/core/components/onboarding/steps/workspace/create.tsx

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
import { useState } from "react";
1+
import { CircleCheck } from "lucide-react";
22
import { observer } from "mobx-react";
3+
import { useState } from "react";
34
import { Controller, useForm } from "react-hook-form";
4-
import { CircleCheck } from "lucide-react";
55
// plane imports
66
import {
77
ORGANIZATION_SIZE,
@@ -16,16 +16,16 @@ import type { IUser, IWorkspace } from "@plane/types";
1616
import { Spinner } from "@plane/ui";
1717
import { cn } from "@plane/utils";
1818
// helpers
19-
import { captureError, captureSuccess } from "@/helpers/event-tracker.helper";
19+
import { captureError } from "@/helpers/event-tracker.helper";
2020
// hooks
2121
import { useWorkspace } from "@/hooks/store/use-workspace";
2222
import { useUser, useUserPermissions, useUserProfile, useUserSettings } from "@/hooks/store/user";
2323
// plane-web imports
2424
import { getIsWorkspaceCreationDisabled } from "@/plane-web/helpers/instance.helper";
2525
import { WorkspaceService } from "@/plane-web/services";
2626
// local components
27-
import { CommonOnboardingHeader } from "../common";
2827
import { getUserRoleString, trackWorkspaceCreated } from "@/plane-web/helpers/event-tracker-v2.helper";
28+
import { CommonOnboardingHeader } from "../common";
2929

3030
type Props = {
3131
user: IUser | undefined;
@@ -85,12 +85,13 @@ export const WorkspaceCreateStep = observer(function WorkspaceCreateStep({
8585
message: t("workspace_creation.toast.success.message"),
8686
});
8787

88+
await fetchWorkspaces();
89+
const role = getWorkspaceRoleByWorkspaceSlug(workspaceResponse.slug);
90+
8891
if (currentUser) {
89-
const role = getWorkspaceRoleByWorkspaceSlug(workspaceResponse.slug);
9092
trackWorkspaceCreated(workspaceResponse, currentUser, getUserRoleString(role));
9193
}
9294

93-
await fetchWorkspaces();
9495
await completeStep(workspaceResponse.id);
9596
onComplete(formData.organization_size === "Just myself");
9697
} catch {

apps/web/core/components/pages/modals/create-page-modal.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,10 @@ import { setToast, TOAST_TYPE } from "@plane/propel/toast";
1313
import type { EPageStoreType } from "@/plane-web/hooks/store";
1414
import { usePageStore } from "@/plane-web/hooks/store";
1515
// local imports
16-
import { PageForm } from "./page-form";
17-
import { useUser, useUserPermissions } from "@/hooks/store/user";
1816
import { useWorkspace } from "@/hooks/store/use-workspace";
17+
import { useUser, useUserPermissions } from "@/hooks/store/user";
1918
import { getUserRoleString, trackPageCreated } from "@/plane-web/helpers/event-tracker-v2.helper";
19+
import { PageForm } from "./page-form";
2020

2121
type Props = {
2222
workspaceSlug: string;
@@ -69,7 +69,7 @@ export function CreatePageModal(props: Props) {
6969
if (!workspaceSlug || !projectId) return;
7070

7171
try {
72-
const pageData = await createPage?.(pageFormData);
72+
const pageData = await createPage(pageFormData);
7373
if (pageData) {
7474
if (currentWorkspace && currentUser) {
7575
const role = getWorkspaceRoleByWorkspaceSlug(currentWorkspace.slug);

apps/web/core/components/workspace/delete-workspace-form.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import React from "react";
1+
import { AlertTriangle } from "lucide-react";
22
import { observer } from "mobx-react";
33
import { Controller, useForm } from "react-hook-form";
4-
import { AlertTriangle } from "lucide-react";
54
// types
65
import { WORKSPACE_TRACKER_EVENTS } from "@plane/constants";
76
import { useTranslation } from "@plane/i18n";
@@ -11,12 +10,12 @@ import type { IWorkspace } from "@plane/types";
1110
// ui
1211
import { Input } from "@plane/ui";
1312
// hooks
14-
import { cn } from "@plane/utils";
15-
import { captureError, captureSuccess } from "@/helpers/event-tracker.helper";
13+
import { captureError } from "@/helpers/event-tracker.helper";
1614
import { useWorkspace } from "@/hooks/store/use-workspace";
1715
import { useUser, useUserPermissions, useUserSettings } from "@/hooks/store/user";
1816
import { useAppRouter } from "@/hooks/use-app-router";
1917
import { getUserRoleString, trackWorkspaceDeleted } from "@/plane-web/helpers/event-tracker-v2.helper";
18+
import { cn } from "@plane/utils";
2019

2120
type Props = {
2221
data: IWorkspace | null;
@@ -69,8 +68,9 @@ export const DeleteWorkspaceForm = observer(function DeleteWorkspaceForm(props:
6968
handleClose();
7069
router.push(getWorkspaceRedirectionUrl());
7170

72-
if (currentUser && data) {
73-
const role = getWorkspaceRoleByWorkspaceSlug(data.slug);
71+
const role = getWorkspaceRoleByWorkspaceSlug(data.slug);
72+
73+
if (currentUser) {
7474
trackWorkspaceDeleted(data, currentUser, getUserRoleString(role));
7575
}
7676

0 commit comments

Comments
 (0)