Skip to content

Commit 2caf23f

Browse files
fix: background task metadata (#5909)
1 parent b33328d commit 2caf23f

File tree

4 files changed

+16
-20
lines changed

4 files changed

+16
-20
lines changed

apiserver/plane/app/views/asset/base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def delete(self, request, workspace_id, asset_key):
5050
asset_key = str(workspace_id) + "/" + asset_key
5151
file_asset = FileAsset.objects.get(asset=asset_key)
5252
file_asset.is_deleted = True
53-
file_asset.save()
53+
file_asset.save(update_fields=["is_deleted"])
5454
return Response(status=status.HTTP_204_NO_CONTENT)
5555

5656

@@ -59,7 +59,7 @@ def restore(self, request, workspace_id, asset_key):
5959
asset_key = str(workspace_id) + "/" + asset_key
6060
file_asset = FileAsset.objects.get(asset=asset_key)
6161
file_asset.is_deleted = False
62-
file_asset.save()
62+
file_asset.save(update_fields=["is_deleted"])
6363
return Response(status=status.HTTP_204_NO_CONTENT)
6464

6565

@@ -96,5 +96,5 @@ def delete(self, request, asset_key):
9696
asset=asset_key, created_by=request.user
9797
)
9898
file_asset.is_deleted = True
99-
file_asset.save()
99+
file_asset.save(update_fields=["is_deleted"])
100100
return Response(status=status.HTTP_204_NO_CONTENT)

apiserver/plane/app/views/asset/v2.py

Lines changed: 9 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ def asset_delete(self, asset_id):
3434
return
3535
asset.is_deleted = True
3636
asset.deleted_at = timezone.now()
37-
asset.save()
37+
asset.save(update_fields=["is_deleted", "deleted_at"])
3838
return
3939

4040
def entity_asset_save(self, asset_id, entity_type, asset, request):
@@ -209,8 +209,7 @@ def patch(self, request, asset_id):
209209
# update the attributes
210210
asset.attributes = request.data.get("attributes", asset.attributes)
211211
# save the asset
212-
asset.created_by = request.user
213-
asset.save()
212+
asset.save(update_fields=["is_uploaded", "attributes"])
214213
return Response(status=status.HTTP_204_NO_CONTENT)
215214

216215
def delete(self, request, asset_id):
@@ -221,7 +220,7 @@ def delete(self, request, asset_id):
221220
self.entity_asset_delete(
222221
entity_type=asset.entity_type, asset=asset, request=request
223222
)
224-
asset.save()
223+
asset.save(update_fields=["is_deleted", "deleted_at"])
225224
return Response(status=status.HTTP_204_NO_CONTENT)
226225

227226

@@ -280,7 +279,7 @@ def asset_delete(self, asset_id):
280279
# Mark the asset as deleted
281280
asset.is_deleted = True
282281
asset.deleted_at = timezone.now()
283-
asset.save()
282+
asset.save(update_fields=["is_deleted", "deleted_at"])
284283
return
285284

286285
def entity_asset_save(self, asset_id, entity_type, asset, request):
@@ -460,8 +459,7 @@ def patch(self, request, slug, asset_id):
460459
# update the attributes
461460
asset.attributes = request.data.get("attributes", asset.attributes)
462461
# save the asset
463-
asset.created_by = request.user
464-
asset.save()
462+
asset.save(update_fields=["is_uploaded", "attributes"])
465463
return Response(status=status.HTTP_204_NO_CONTENT)
466464

467465
def delete(self, request, slug, asset_id):
@@ -472,7 +470,7 @@ def delete(self, request, slug, asset_id):
472470
self.entity_asset_delete(
473471
entity_type=asset.entity_type, asset=asset, request=request
474472
)
475-
asset.save()
473+
asset.save(update_fields=["is_deleted", "deleted_at"])
476474
return Response(status=status.HTTP_204_NO_CONTENT)
477475

478476
def get(self, request, slug, asset_id):
@@ -551,7 +549,7 @@ def post(self, request, slug, asset_id):
551549
asset = FileAsset.all_objects.get(id=asset_id, workspace__slug=slug)
552550
asset.is_deleted = False
553551
asset.deleted_at = None
554-
asset.save()
552+
asset.save(update_fields=["is_deleted", "deleted_at"])
555553
return Response(status=status.HTTP_204_NO_CONTENT)
556554

557555

@@ -692,8 +690,7 @@ def patch(self, request, slug, project_id, pk):
692690
# update the attributes
693691
asset.attributes = request.data.get("attributes", asset.attributes)
694692
# save the asset
695-
asset.created_by = request.user
696-
asset.save()
693+
asset.save(update_fields=["is_uploaded", "attributes"])
697694
return Response(status=status.HTTP_204_NO_CONTENT)
698695

699696
@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])
@@ -708,7 +705,7 @@ def delete(self, request, slug, project_id, pk):
708705
asset.is_deleted = True
709706
asset.deleted_at = timezone.now()
710707
# Save the asset
711-
asset.save()
708+
asset.save(update_fields=["is_deleted", "deleted_at"])
712709
return Response(status=status.HTTP_204_NO_CONTENT)
713710

714711
@allow_permission([ROLE.ADMIN, ROLE.MEMBER, ROLE.GUEST])

apiserver/plane/bgtasks/storage_metadata_task.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ def get_asset_object_metadata(asset_id):
1919
object_name=asset.asset.name
2020
)
2121
# Save the asset
22-
asset.save()
22+
asset.save(update_fields=["storage_metadata"])
2323
return
2424
except FileAsset.DoesNotExist:
2525
return

apiserver/plane/space/views/asset.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -169,8 +169,7 @@ def patch(self, request, anchor, pk):
169169
# update the attributes
170170
asset.attributes = request.data.get("attributes", asset.attributes)
171171
# save the asset
172-
asset.created_by = request.user
173-
asset.save()
172+
asset.save(update_fields=["attributes", "is_uploaded"])
174173
return Response(status=status.HTTP_204_NO_CONTENT)
175174

176175
def delete(self, request, anchor, pk):
@@ -194,7 +193,7 @@ def delete(self, request, anchor, pk):
194193
asset.is_deleted = True
195194
asset.deleted_at = timezone.now()
196195
# Save the asset
197-
asset.save()
196+
asset.save(update_fields=["is_deleted", "deleted_at"])
198197
return Response(status=status.HTTP_204_NO_CONTENT)
199198

200199

@@ -219,7 +218,7 @@ def post(self, request, anchor, asset_id):
219218
)
220219
asset.is_deleted = False
221220
asset.deleted_at = None
222-
asset.save()
221+
asset.save(update_fields=["is_deleted", "deleted_at"])
223222
return Response(status=status.HTTP_204_NO_CONTENT)
224223

225224

0 commit comments

Comments
 (0)